openai-image-gen: validate --background and --style options by shuofengzhang · Pull Request #36762 · openclaw/openclaw

shuofengzhang · 2026-03-05T21:54:22Z

What changed

Added validation for --background and --style in skills/openai-image-gen/scripts/gen.py.
Normalized accepted values to lowercase before sending requests.
Warned and ignored those flags when the selected model does not support them instead of silently discarding them.
Added unit tests for valid, invalid, empty-input, and incompatible-model warning paths in skills/openai-image-gen/scripts/test_gen.py.
Added a changelog entry with contributor attribution.

Why

Invalid values previously failed late with API errors.
Incompatible models could silently drop --background / --style, which is confusing CLI behavior.
Early validation and explicit warnings make the tool behavior predictable and avoid unnecessary failed requests.

Testing

✅ python3 -m ruff check skills/openai-image-gen/scripts/test_gen.py
✅ python3 -m pytest -q skills/openai-image-gen/scripts/test_gen.py (14 passed)

Fixes #36763

greptile-apps · 2026-03-05T21:57:19Z

Greptile Summary

This PR adds early CLI validation for the --background and --style flags in skills/openai-image-gen/scripts/gen.py, preventing unnecessary API calls and surfacing clearer error messages when invalid values are supplied. The implementation is straightforward and correct, with appropriate case-normalization before forwarding values to the API.

Key changes:

normalize_background: validates --background (transparent/opaque/auto) only for gpt-image-* models; silently no-ops for other models.
normalize_style: validates --style (vivid/natural) only for dall-e-3; silently no-ops for other models.
Both functions are called once in main() before the generation loop, exiting with code 2 on validation failure.
Six new unit tests added covering valid, normalized-case, and invalid inputs.

Minor issue:

The test suite does not cover the empty-string input code path (if not value: return "") that is present in both helper functions. This is a real code path that executes when the user omits the flag (default empty string), and should be explicitly tested.

Confidence Score: 4/5

Safe to merge; validation logic is correct with appropriate error handling, though test coverage for empty-input code paths should be added.
The implementation correctly validates and normalizes --background and --style flags with appropriate model-specific logic. The code handles both valid and invalid inputs correctly, with defensive error messages. The primary gap is incomplete test coverage: the empty-string code path (present in both normalize functions at lines 84-85 and 101-102) is not covered by tests, though this represents real usage when flags are omitted. This is a test completeness issue rather than a logic bug, hence a 4/5 rather than 5/5.
skills/openai-image-gen/scripts/test_gen.py — add tests for empty and whitespace inputs on supported models

_{Last reviewed commit: 0677a5f}

skills/openai-image-gen/scripts/test_gen.py

vincentkoc · 2026-03-06T16:00:14Z

Pushed a follow-up cleanup to this branch.

The diff now includes the added empty-input coverage, warning coverage for incompatible models, a changelog entry with attribution, and the Python import-order fix that was tripping skills-python. I reran python3 -m ruff check skills/openai-image-gen/scripts/test_gen.py and python3 -m pytest -q skills/openai-image-gen/scripts/test_gen.py locally before pushing.

* main: Mattermost: harden interaction callback binding (openclaw#38057) WhatsApp: honor outbound mediaMaxMb (openclaw#38097) openai-image-gen: validate --background and --style options (openclaw#36762) Docs: align BlueBubbles media cap wording Telegram/Discord: honor outbound mediaMaxMb uploads (openclaw#38065) CI: run changed-scope on main pushes Skills/nano-banana-pro: clarify MEDIA token comment (openclaw#38063) nano-banana-pro: respect explicit --resolution when editing images (openclaw#36880) CI: drop unused install-smoke bootstrap fix(nano-banana-pro): remove space after MEDIA: token in generate_image.py (openclaw#18706) docs: context engine docs(config): list the context engine plugin slot docs(plugins): add context-engine manifest kind example docs(plugins): document context engine slots and registration docs(protocol): document slash-delimited schema lookup plugin ids docs(tools): document slash-delimited config schema lookup paths fix(session): tighten direct-session webchat routing matching (openclaw#37867) feature(context): extend plugin system to support custom context management (openclaw#22201) Gateway: allow slash-delimited schema lookup paths

…#36762) * openai-image-gen: validate --background and --style inputs * Skills/openai-image-gen: warn on ignored background and style flags * Skills/openai-image-gen: cover empty and warning cases * Changelog: note openai image flag validation * Skills/openai-image-gen: fix Python import order --------- Co-authored-by: Vincent Koc <[email protected]>

…#36762) Co-authored-by: Vincent Koc <[email protected]> (cherry picked from commit 20038fb9556b8f46e6a4eec8f8cd0b1e3cb12c87)

openclaw-barnacle bot added the size: S label Mar 5, 2026

shuofengzhang mentioned this pull request Mar 5, 2026

openai-image-gen: validate --background and --style CLI options #36763

Closed

greptile-apps bot reviewed Mar 5, 2026

View reviewed changes

skills/openai-image-gen/scripts/test_gen.py Show resolved Hide resolved

shuofengzhang and others added 4 commits March 6, 2026 10:52

openai-image-gen: validate --background and --style inputs

c278d91

Skills/openai-image-gen: warn on ignored background and style flags

cc8fb85

Skills/openai-image-gen: cover empty and warning cases

7f4b2b3

Changelog: note openai image flag validation

9d232d2

vincentkoc force-pushed the fix/openai-image-gen-validate-background-style branch from 323c010 to 9d232d2 Compare March 6, 2026 15:54

Skills/openai-image-gen: fix Python import order

c643239

vincentkoc self-assigned this Mar 6, 2026

vincentkoc merged commit 20038fb into openclaw:main Mar 6, 2026
23 checks passed

vincentkoc mentioned this pull request Mar 6, 2026

openai-image-gen: validate and normalize --output-format #36648

Merged

github-actions bot mentioned this pull request Mar 6, 2026

📡 Upstream Digest — 2026-03-06 16:31 UTC curtismercier/openclaw-mods#193

Open

alexyyyander mentioned this pull request Mar 7, 2026

fix/gateway token mismatch 38617 #38676

Closed

alexey-pelykh mentioned this pull request Mar 10, 2026

Cherry-pick: changelog entries, docs, gutted-layer release notes remoteclaw/remoteclaw#832

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

openai-image-gen: validate --background and --style options#36762

openai-image-gen: validate --background and --style options#36762
vincentkoc merged 5 commits intoopenclaw:mainfrom
shuofengzhang:fix/openai-image-gen-validate-background-style

shuofengzhang commented Mar 5, 2026 •

edited by vincentkoc

Loading

Uh oh!

greptile-apps bot commented Mar 5, 2026

Uh oh!

Uh oh!

vincentkoc commented Mar 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

shuofengzhang commented Mar 5, 2026 • edited by vincentkoc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed

Why

Testing

Uh oh!

greptile-apps bot commented Mar 5, 2026

Greptile Summary

Confidence Score: 4/5

Uh oh!

Uh oh!

vincentkoc commented Mar 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shuofengzhang commented Mar 5, 2026 •

edited by vincentkoc

Loading