openai-image-gen: validate and normalize --output-format#36648
Conversation
Greptile SummaryThis PR adds Key strengths:
Minor test gaps:
Confidence Score: 4/5
Last reviewed commit: 4189b01 |
c619daa to
de7f8e0
Compare
|
Pushed a follow-up cleanup to this branch. The diff now includes the added pass-through / empty-input coverage, warning coverage for incompatible models, a changelog entry with attribution, and the Python import-order fix that was tripping |
c5bff22 to
3bb32a9
Compare
|
Rebased this branch onto current The overlap in Local verification on the rebased branch:
|
) * openai-image-gen: validate and normalize output format * Skills/openai-image-gen: cover output-format edge cases * Changelog: note openai image output format validation --------- Co-authored-by: Vincent Koc <[email protected]>
) * openai-image-gen: validate and normalize output format * Skills/openai-image-gen: cover output-format edge cases * Changelog: note openai image output format validation --------- Co-authored-by: Vincent Koc <[email protected]>
) * openai-image-gen: validate and normalize output format * Skills/openai-image-gen: cover output-format edge cases * Changelog: note openai image output format validation --------- Co-authored-by: Vincent Koc <[email protected]>
) * openai-image-gen: validate and normalize output format * Skills/openai-image-gen: cover output-format edge cases * Changelog: note openai image output format validation --------- Co-authored-by: Vincent Koc <[email protected]>
) * openai-image-gen: validate and normalize output format * Skills/openai-image-gen: cover output-format edge cases * Changelog: note openai image output format validation --------- Co-authored-by: Vincent Koc <[email protected]>
) * openai-image-gen: validate and normalize output format * Skills/openai-image-gen: cover output-format edge cases * Changelog: note openai image output format validation --------- Co-authored-by: Vincent Koc <[email protected]>
) Co-authored-by: Vincent Koc <[email protected]> (cherry picked from commit 81f22ae1095fca18e1b61425a5b73b2deda2e1a5)
) Co-authored-by: Vincent Koc <[email protected]> (cherry picked from commit 81f22ae1095fca18e1b61425a5b73b2deda2e1a5)
What changed
normalize_output_format()inskills/openai-image-gen/scripts/gen.pyto normalize and validate--output-formatfor GPT image models.jpgtojpegfor user convenience.--output-formatwhen the selected model does not support that flag.Why
Testing
python3 -m ruff check skills/openai-image-gen/scripts/test_gen.pypython3 -m pytest -q skills/openai-image-gen/scripts/test_gen.py(11 passed)Fixes #36649