feat(hooks): workspace events subscription hook by JoshuaLelon · Pull Request #36302 · openclaw/openclaw

JoshuaLelon · 2026-03-05T14:59:34Z

Summary

Adds Google Workspace Events subscription hook via gws events +subscribe, giving agents real-time awareness of Calendar changes, Drive file updates, Chat messages, etc.
Follows the Gmail gws pattern exactly: config → runtime resolver → arg builder → bridge (NDJSON→hook POST) → watcher (spawn + restart) → lifecycle wrapper → gateway startup/reload
Adds openclaw webhooks events setup and openclaw webhooks events run CLI commands

Changes

New files (8):

src/hooks/ws-events.ts — runtime config types, resolver, arg builder
src/hooks/ws-events-bridge.ts — CloudEvent NDJSON → hook payload transform
src/hooks/ws-events-watcher.ts — process lifecycle (spawn, restart, stop)
src/hooks/ws-events-watcher-lifecycle.ts — thin wrapper with env skip + logging
src/hooks/ws-events-ops.ts — setup + run command implementations
src/hooks/ws-events.test.ts — 13 tests for config resolver + arg builder
src/hooks/ws-events-bridge.test.ts — 13 tests for CloudEvent transform + NDJSON handler
docs/automation/workspace-events.md — documentation

Modified files (8):

src/config/types.hooks.ts — HooksWorkspaceEventsConfig type
src/config/zod-schema.hooks.ts — HooksWorkspaceEventsSchema
src/config/zod-schema.ts — wire schema into parent hooks object
src/gateway/hooks-mapping.ts — "workspace-events" preset + allowUnsafeExternalContent
src/gateway/config-reload-plan.ts — restartWsEventsWatcher plan field + reload rule
src/gateway/server-startup.ts — start watcher on boot
src/gateway/server-reload-handlers.ts — handle watcher restart on config change
src/cli/webhooks-cli.ts — events setup + events run subcommands

Dependencies

Depends on feat(hooks): support gws as alternative to gog for Gmail Pub/Sub #35506 (gws/06-gmail-hooks-gws) for postToHookUrl, ensureDependency("gws", ...), and the NDJSON bridge pattern

Test plan

pnpm build — no type errors
pnpm check — lint/format clean
26/26 workspace events tests pass
41/41 existing Gmail tests still pass
21/21 hooks-mapping tests still pass
Manual: openclaw webhooks events setup --target '//chat.googleapis.com/spaces/X' --event-types 'google.workspace.chat.message.v1.created' --project P

🤖 Generated with Claude Code

greptile-apps · 2026-03-05T15:03:38Z

Greptile Summary

This PR adds a Google Workspace Events subscription hook that wires real-time Calendar, Drive, and Chat changes into OpenClaw's agent hook system via the gws events +subscribe CLI. It follows the existing Gmail hook pattern (config types → resolver → arg builder → NDJSON bridge → watcher → lifecycle wrapper → gateway wiring) and adds openclaw webhooks events setup / run CLI commands. The implementation is well-structured and tests provide good coverage of the config resolver and bridge transform.

Key issues found:

Logic bug — openclaw webhooks events run only restarts once after a crash (src/hooks/ws-events-ops.ts): The restart handler in runWsEventsService is attached as a closure to the first child object. When the process crashes and a new child is spawned, the handler is not re-attached. The module-level fallback from spawnGwsEventsSubscribe is also a no-op in this path because currentConfig (module-level) is never set. After the second crash, gws stays down silently.
Dead config fields (src/config/types.hooks.ts): model and thinking are declared on HooksWorkspaceEventsConfig and exposed in the Zod schema, but are never read at runtime (unlike Gmail, which routes them through resolveHooksGmailModel). Users who configure these will see no effect.
Misleading ?? "unknown" guard (src/hooks/ws-events-bridge.ts): "".split(".").pop() returns "" rather than undefined, so the fallback never fires for empty event types, producing a malformed summary string with a leading space.

Confidence Score: 3/5

Safe to merge with caution — the gateway-managed watcher path is correct, but the CLI events run command has a restart reliability bug that will leave gws down after a second crash.
The core architecture (config, schema, gateway startup/reload, NDJSON bridge) is sound and well-tested. The single critical issue is confined to runWsEventsService in the CLI path: the restart loop breaks silently after the first recovery. This doesn't affect the gateway-managed watcher (which uses the correct module-level lifecycle), but makes openclaw webhooks events run unreliable for long-running use. Two additional style issues (dead model/thinking config fields, misleading pop fallback) are minor but should be addressed before the feature is considered complete.
src/hooks/ws-events-ops.ts — restart loop logic needs fixing for the CLI events run command.

_{Last reviewed commit: b908f48}

src/hooks/ws-events-ops.ts

src/hooks/ws-events-bridge.ts

src/config/types.hooks.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b908f48174

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/gateway/server-startup.ts

src/gateway/config-reload-plan.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e3e6dba2c6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/hooks/ws-events-ops.ts

src/gateway/hooks-mapping.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0fcdd5fe06

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-08T15:15:44Z

src/hooks/ws-events-ops.ts

+  defaultRuntime.log(`Starting gws ${args.join(" ")}`);
+
+  let shuttingDown = false;
+  let child = spawnGwsEventsSubscribe(runtimeConfig);


Replace gateway watcher spawner in CLI run loop

runWsEventsService calls spawnGwsEventsSubscribe, but that helper is wired for gateway mode and always schedules a 5s restart timer on child exit unless the watcher module’s own global shuttingDown flag is set. In the CLI path, SIGINT/SIGTERM only flips a local shuttingDown, so an intentional stop of openclaw webhooks events run still leaves the gateway timer alive, delaying clean process exit (and potentially racing with the CLI restart loop). Use a CLI-specific spawner (or share shutdown state) so manual shutdown does not queue watcher restarts.

Useful? React with 👍 / 👎.

…ubscribe

- Fix restart-loop: respawned child now gets exit handler via attachExitHandler pattern - Fix ?? vs || in buildEventSummary so empty string falls back to 'unknown' - Add stopWsEventsWatcher() call to gateway shutdown handler - Add hooks.workspaceEvents.model startup validation (mirrors gmail model check) - Factor out resolveHooksModel helper shared by gmail and ws-events

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9adcf031f1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-09T14:12:55Z

src/hooks/ws-events-watcher.ts

+    setTimeout(() => {
+      if (shuttingDown || !currentConfig) {
+        return;
+      }
+      watcherProcess = spawnGwsEventsSubscribe(currentConfig);


Clear pending restart timer before respawning watcher

The exit handler schedules an unconditional 5s restart timer, but that timer is never cancelled when stopWsEventsWatcher() runs. If gws crashes, then a config reload triggers stop/start before the 5s elapses, startWsEventsWatcher() resets shuttingDown and currentConfig, so the stale timer also spawns another child process; this creates duplicate subscriptions and leaves one process untracked by watcherProcess on later shutdowns.

Useful? React with 👍 / 👎.

openclaw-barnacle bot added docs Improvements or additions to documentation gateway Gateway runtime cli CLI command changes size: XL labels Mar 5, 2026

greptile-apps bot reviewed Mar 5, 2026

View reviewed changes

src/hooks/ws-events-ops.ts Outdated Show resolved Hide resolved

src/hooks/ws-events-bridge.ts Show resolved Hide resolved

src/config/types.hooks.ts Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Mar 5, 2026

View reviewed changes

src/gateway/server-startup.ts Show resolved Hide resolved

src/gateway/config-reload-plan.ts Show resolved Hide resolved

JoshuaLelon force-pushed the gws/07-events-hook branch from 60cc62e to e3e6dba Compare March 8, 2026 14:31

chatgpt-codex-connector bot reviewed Mar 8, 2026

View reviewed changes

src/hooks/ws-events-ops.ts Outdated Show resolved Hide resolved

src/gateway/hooks-mapping.ts Show resolved Hide resolved

openclaw-barnacle bot added the app: macos App: macos label Mar 8, 2026

JoshuaLelon mentioned this pull request Mar 8, 2026

fix(swiftformat): exclude generated security policy from formatters #39969

Merged

3 tasks

openclaw-barnacle bot added the agents Agent runtime and tooling label Mar 8, 2026

chatgpt-codex-connector bot reviewed Mar 8, 2026

View reviewed changes

JoshuaLelon added 4 commits March 9, 2026 09:05

feat(hooks): add workspace events subscription hook via gws events +s…

9223663

…ubscribe

hooks: add installMethod param to ensureDependency for npm installs

93058ec

test: update ws-events-bridge test for ?? to || fallback change

9adcf03

JoshuaLelon force-pushed the gws/07-events-hook branch from 82b504e to 9adcf03 Compare March 9, 2026 14:05

openclaw-barnacle bot removed the app: macos App: macos label Mar 9, 2026

chatgpt-codex-connector bot reviewed Mar 9, 2026

View reviewed changes

JoshuaLelon closed this Mar 12, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(hooks): workspace events subscription hook#36302

feat(hooks): workspace events subscription hook#36302
JoshuaLelon wants to merge 4 commits intoopenclaw:mainfrom
JoshuaLelon:gws/07-events-hook

JoshuaLelon commented Mar 5, 2026

Uh oh!

greptile-apps bot commented Mar 5, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 8, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

JoshuaLelon commented Mar 5, 2026

Summary

Changes

Dependencies

Test plan

Uh oh!

greptile-apps bot commented Mar 5, 2026

Greptile Summary

Confidence Score: 3/5

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant