Doctor: handle SecretRef apiKey in memory-search health check#35755
Closed
echoVic wants to merge 1 commit intoopenclaw:mainfrom
Closed
Doctor: handle SecretRef apiKey in memory-search health check#35755echoVic wants to merge 1 commit intoopenclaw:mainfrom
echoVic wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Contributor
Greptile SummaryThis PR fixes a crash in Changes:
Confidence Score: 5/5
Last reviewed commit: e32d37e |
18 tasks
Contributor
|
Thanks for the contribution here, and for helping narrow down the SecretRef doctor crash. We merged #36835, which supersedes this PR and fixes the broader doctor/memory SecretRef surface in one place, including the related runtime embedding paths. I’m closing this as superseded by #36835, but I appreciate the fix and the investigation that went into it. |
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agents.defaults.memorySearch.remote.apiKeyin doctor health checksSecretRefvalues as valid configured API key inputopenclaw doctorno longer crashes on SecretRef-shaped API keysTesting
Closes #35444