fix(discovery): add missing domain to wideArea Zod config schema#35615
Merged
altaywtf merged 2 commits intoopenclaw:mainfrom Mar 13, 2026
Merged
fix(discovery): add missing domain to wideArea Zod config schema#35615altaywtf merged 2 commits intoopenclaw:mainfrom
altaywtf merged 2 commits intoopenclaw:mainfrom
Conversation
Contributor
Greptile SummaryThis PR fixes a schema gap where Changes:
Confidence Score: 5/5
Last reviewed commit: c697172 |
Contributor
Author
|
@altaywtf This is ready for review — CI passes, no conflicts. Could you take a look? Thanks! |
c697172 to
99d396b
Compare
99d396b to
72eacb7
Compare
The wideArea schema uses .strict() but was missing the domain field that is defined in WideAreaDiscoveryConfig type (types.gateway.ts:21) and used across gateway, CLI, and infrastructure code for unicast DNS-SD discovery. Users setting discovery.wideArea.domain in their config get a validation error. Add the field to the schema and a regression test.
72eacb7 to
d81d332
Compare
Member
|
Merged via squash.
Thanks @ingyukoh! |
mrosmarin
added a commit
to mrosmarin/openclaw
that referenced
this pull request
Mar 13, 2026
* main: (168 commits) fix: stabilize macos daemon onboarding fix(ui): keep shared auth on insecure control-ui connects (openclaw#45088) docs(plugins): clarify workspace shadowing fix(node-host): harden perl approval binding fix(node-host): harden pnpm approval binding fix(discovery): add missing domain to wideArea Zod config schema (openclaw#35615) chore(gitignore): add docker-compose override (openclaw#42879) feat(ios): add onboarding welcome pager (openclaw#45054) fix(signal): add groups config to Signal channel schema (openclaw#27199) fix: restore web fetch firecrawl config in runtime zod schema (openclaw#42583) fix: polish Android QR scanner onboarding (openclaw#45021) fix(android): use Google Code Scanner for onboarding QR fix(config): add missing params field to agents.list[] validation schema (openclaw#41171) docs(contributing): update Android app ownership fix(agents): rephrase session reset prompt to avoid Azure content filter (openclaw#43403) test(config): cover requiresOpenAiAnthropicToolPayload in compat schema fixture fix(agents): respect explicit user compat overrides for non-native openai-completions (openclaw#44432) Android: fix HttpURLConnection leak in TalkModeVoiceResolver (openclaw#43780) Docker: add OPENCLAW_TZ timezone support (openclaw#34119) fix(agents): avoid injecting memory file twice on case-insensitive mounts (openclaw#26054) ...
z-hao-wang
pushed a commit
to z-hao-wang/openclaw
that referenced
this pull request
Mar 13, 2026
…nclaw#35615) Merged via squash. Prepared head SHA: d81d332 Co-authored-by: ingyukoh <[email protected]> Co-authored-by: altaywtf <[email protected]> Reviewed-by: @altaywtf
frankekn
pushed a commit
to xinhuagu/openclaw
that referenced
this pull request
Mar 14, 2026
…nclaw#35615) Merged via squash. Prepared head SHA: d81d332 Co-authored-by: ingyukoh <[email protected]> Co-authored-by: altaywtf <[email protected]> Reviewed-by: @altaywtf
hougangdev
pushed a commit
to hougangdev/clawdbot
that referenced
this pull request
Mar 14, 2026
…nclaw#35615) Merged via squash. Prepared head SHA: d81d332 Co-authored-by: ingyukoh <[email protected]> Co-authored-by: altaywtf <[email protected]> Reviewed-by: @altaywtf
ecochran76
pushed a commit
to ecochran76/openclaw
that referenced
this pull request
Mar 14, 2026
…nclaw#35615) Merged via squash. Prepared head SHA: d81d332 Co-authored-by: ingyukoh <[email protected]> Co-authored-by: altaywtf <[email protected]> Reviewed-by: @altaywtf
5 tasks
Interstellar-code
pushed a commit
to Interstellar-code/operator1
that referenced
this pull request
Mar 16, 2026
…nclaw#35615) Merged via squash. Prepared head SHA: d81d332 Co-authored-by: ingyukoh <[email protected]> Co-authored-by: altaywtf <[email protected]> Reviewed-by: @altaywtf (cherry picked from commit af4731a)
sbezludny
pushed a commit
to sbezludny/openclaw
that referenced
this pull request
Mar 27, 2026
…nclaw#35615) Merged via squash. Prepared head SHA: d81d332 Co-authored-by: ingyukoh <[email protected]> Co-authored-by: altaywtf <[email protected]> Reviewed-by: @altaywtf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35614
Summary
domainfield to wideArea schema inzod-schema.tsconfig.schema-regressions.test.tsProblem
The wideArea schema uses
.strict()but was missing thedomainfield that is:types.gateway.ts:21)Users setting
discovery.wideArea.domainget a validation error.Test plan
accepts discovery.wideArea.domain for unicast DNS-SD