fix(cron): apply responsePrefix to direct delivery payloads#35469
Open
ethanperezz wants to merge 1 commit intoopenclaw:mainfrom
Open
fix(cron): apply responsePrefix to direct delivery payloads#35469ethanperezz wants to merge 1 commit intoopenclaw:mainfrom
ethanperezz wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Cron direct delivery (delivery.mode: "announce" with direct path) was sending raw response text without applying the configured responsePrefix. Interactive replies correctly resolve the prefix via resolveEffectiveMessagesConfig, but the cron deliverViaDirect path skipped this step entirely. Resolve responsePrefix for the delivery channel/account and prepend it to payload text, matching the behavior of route-reply and heartbeat delivery paths. Fixes openclaw#29600 Co-Authored-By: Claude Opus 4.6 <[email protected]>
Contributor
Greptile SummaryThis PR fixes a bug where the Key changes:
The implementation is symmetric with the interactive reply path and also correctly applies to the fallback case (announce fails → direct delivery), since Confidence Score: 4/5
Last reviewed commit: 0aed3a7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deliverViaDirect) was sending raw response text without applying the configuredresponsePrefixresolveEffectiveMessagesConfig, but the cron direct delivery path skipped this stepresponsePrefixfor the delivery channel/account and prepends it to payload text, matching the behavior ofroute-replyand heartbeat delivery pathsChange Type
Scope
Linked Issue
User-visible / Behavior Changes
responsePrefix(e.g.[Thames]) matching interactive reply behaviorSecurity Impact
Test plan
responsePrefix: "auto"is applied to cron direct delivery messagesresponsePrefixper-channel/account resolution works for cron delivery🤖 Generated with Claude Code