fix(security): use Object.hasOwn to prevent prototype pollution bypass#35011
fix(security): use Object.hasOwn to prevent prototype pollution bypass#35011davidemanuelDEV wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Greptile SummarySecurity Fix: Prototype Pollution PreventionThis PR makes a focused security hardening by replacing the The vulnerability: The The fix: Assessment: This is a minimal, correct security fix with no side effects. The change is straightforward and uses the idiomatic modern replacement pattern. Confidence Score: 5/5
Last reviewed commit: 3f94ab3 |
|
Hello @davidemanuelDEV, thank you very much for your contribution. I really appreciate your work. Since we already have another pull request that was opened earlier (#34929) addressing this issue, I recommend commenting on the other pull request if you would like to suggest any changes. Thank you very much nevertheless. cc @shakkernerd, could you please close this so that we don’t run into confusion with multiple PRs? Thanks! |
|
Thanks for the work, @davidemanuelDEV. This issue has been addressed by maintainer-selected PR #34982 (tracking issue #34926).\n\nTo keep the queue clean, I’m closing this as a duplicate. |
Fixes #34926. Replaces
inoperator withObject.hasOwn()inhasExplicitProviderAccountConfigto prevent prototype chain traversal that could allow specially crafted accountIds like__proto__to bypass the check.