fix(cron): skip delivery target resolution when delivery mode is none#34518
Open
kaxo-io wants to merge 3 commits intoopenclaw:mainfrom
Open
fix(cron): skip delivery target resolution when delivery mode is none#34518kaxo-io wants to merge 3 commits intoopenclaw:mainfrom
kaxo-io wants to merge 3 commits intoopenclaw:mainfrom
Conversation
Contributor
Greptile SummaryThis PR fixes a bug where Key changes:
Confidence Score: 5/5
Last reviewed commit: 58a2f2d |
0313d5c to
e378959
Compare
|
This pull request has been automatically marked as stale due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
delivery.modeis not requested (includingnone)messageChannelinto embedded cron runs when delivery is disableddelivery.mode=none+channel:last)Why
resolveDeliveryTarget()was being called unconditionally, which could still resolve/fallback channel routing even when cron delivery was disabled. That allowedchannel:lastpaths to leak into runtime routing and surface as message delivery failures.Tests
npx vitest run src/cron/isolated-agent/run.delivery-mode-none-channel-last.test.ts src/cron/delivery.test.tsnpx vitest run src/cron/isolated-agent/run.*.test.tsFixes #30393