fix: recognize Feishu @bot mention by open_id despite display-name alias#34345
fix: recognize Feishu @bot mention by open_id despite display-name alias#34345aerelune wants to merge 2 commits intoopenclaw:mainfrom
Conversation
Greptile SummaryThis PR fixes a false-negative in Feishu bot mention detection by removing the strict display-name equality guard ( Key changes:
The logic change is correct and well-tested. The only remaining issue is the dead Confidence Score: 4/5
Last reviewed commit: e6a3cab |
Additional Comments (1)
|
|
Follow-up done per review suggestion:
Validation:
Commit: |
7adf8c6 to
bb5725e
Compare
Summary
Fix Feishu group mention matching to rely on stable
open_id, avoiding false negatives when the bot display name differs across aliases/app contexts.Changes
mention.name === botNamegate incheckBotMentionedparseFeishuMessageEventopen_idmatchesTesting
pnpm -s vitest run extensions/feishu/src/bot.checkBotMentioned.test.ts(15 passed)Fixes #34271