fix(mac): default release app builds to universal binaries#33891
fix(mac): default release app builds to universal binaries#33891steipete merged 5 commits intoopenclaw:mainfrom
Conversation
Greptile SummaryThis PR fixes a recurring regression where release builds of the macOS app were produced as arm64-only artifacts from Apple Silicon hosts, blocking Intel Mac users. It does this by hardening Changes:
Confidence Score: 3/5
Last reviewed commit: 54f86ec |
Additional Comments (1)
This note still says "Defaults to the current architecture ( |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04679eb318
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| BUILD_CONFIG=release \ | ||
| SIGN_IDENTITY="Developer ID Application: <Developer Name> (<TEAMID>)" \ | ||
| scripts/package-mac-app.sh | ||
| scripts/package-mac-dist.sh |
There was a problem hiding this comment.
Keep the basic release command from requiring notarization
This example now runs scripts/package-mac-dist.sh, but that script unconditionally enables notarization unless SKIP_NOTARIZE=1 is set, and scripts/notarize-mac-artifact.sh exits when no NOTARYTOOL_PROFILE or key-based auth is present. As a result, the first “Build & package” command now fails in setups that only have signing configured (or intentionally skip notarization), which makes the primary checklist path non-runnable unless extra undocumented env vars are added.
Useful? React with 👍 / 👎.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Additional Comments (1)
The first code block now calls # Both of these are now no-ops — package-mac-dist.sh already produces them
ditto -c -k --sequesterRsrc --keepParent dist/OpenClaw.app dist/OpenClaw-2026.3.2.zip
scripts/create-dmg.sh dist/OpenClaw.app dist/OpenClaw-2026.3.2.dmgIn the notarized path this is merely wasteful, but it could actively mislead a release engineer into thinking extra manual steps are required, or cause confusion if the output files differ (e.g. a version mismatch in the filename). Consider removing or clearly marking these steps as "only needed if you ran |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
a524f3d to
68e8235
Compare
|
Landed via temp rebase onto main.
Thanks @cgdusek! |
* main: (70 commits) Refactor release hardening follow-ups (openclaw#39959) docs: clarify bot review conversation ownership (openclaw#39942) fix: harden talk silence timeout parsing (openclaw#39607) (thanks @danodoesdesign) talk: add configurable silence timeout transcript-policy: use named Set for anthropic signature-excluded providers transcript-policy: don't preserve thinking signatures for kimi-coding (openclaw#39798) fix: land mac universal release defaults (openclaw#33891) (thanks @cgdusek) Docs: clarify notarization handoff in mac release flow Docs: mark basic mac dist example as non-notarized Docs: clarify release build arch defaults for mac packaging macOS: default release app builds to universal binaries fix(issue-39839): address tool-call extra params parsing for kimi anthropic-messages docs: use alphabetical provider ordering fix: follow up openclaw#39321 and openclaw#38445 landings docs: note /landpr merge process fix: land Brave llm-context gaps (openclaw#33383) (thanks @thirumaleshp) feat: add Brave Search LLM Context API mode for web_search fix(feishu): restore @larksuiteoapi/node-sdk in root dependencies refactor: tighten codex inline api fallback follow-up macOS: set speech recognition taskHint for Talk Mode mic capture ...
|
is there still no release that incorporates this? v3.7 still can't be installed |
Summary
scripts/package-mac-app.shto universal arch builds (BUILD_ARCHS=all) whenBUILD_CONFIG=releaseandBUILD_ARCHSis unsetBUILD_ARCHSstill wins)docs/platforms/mac/release.mdrelease command to usescripts/package-mac-dist.sh(the release packaging path)BUILD_ARCHS=allso it doesn't work on Intel(x86_64) Mac anymore #28376Why
Release artifacts were repeatedly built arm64-only from Apple Silicon hosts. This blocks Intel Macs at launch time. The fix hardens the build script so release builds are universal by default even when operators invoke
package-mac-app.shdirectly.Local Validation
pnpm checkpnpm testBoth passed locally on this branch.