CLI: resolve exec SecretRefs before security audit in status command#33695
Closed
abel-zer0 wants to merge 1 commit intoopenclaw:mainfrom
Closed
CLI: resolve exec SecretRefs before security audit in status command#33695abel-zer0 wants to merge 1 commit intoopenclaw:mainfrom
abel-zer0 wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Contributor
Greptile SummaryThis PR fixes a crash in Key changes:
Confidence Score: 5/5
Last reviewed commit: 3af76fd |
Contributor
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openclaw statuscrashes withunresolved SecretReferror when channel credentials use exec SecretRefs (e.g. Slack tokens via 1Password)statusCommand()passes rawloadConfig()directly torunSecurityAudit(), which walks intoresolveSlackBotToken()→assertSecretInputResolved()and throwsresolveCommandSecretRefsViaGateway()before the audit, matching the existing pattern instatus-all.tsandmessage.tsTest plan
pnpm buildpasses (type-check)openclaw statusno longer crashes with exec SecretRefs configuredopenclaw status --jsonworks correctly🤖 Generated with Claude Code