fix: sessions navigation, DM thread display, and DM thread delivery regression by Lukavyi · Pull Request #3368 · openclaw/openclaw

Lukavyi · 2026-01-28T14:15:04Z

Summary

Fixes #3367

Three related fixes for Telegram DM topics:

Display: Adds ThreadLabel so DM topic sessions show their thread ID
Navigation: Fixes clicking a session in Sessions tab redirecting to Main instead of the selected session
Delivery: Fixes bot replies going to General instead of the originating DM thread (regression from commit 9154971)

Changes

src/telegram/bot-message-context.ts: Set ThreadLabel: "Thread: N" for non-group messages with messageThreadId; introduce effectiveThreadId for correct outbound delivery in DM threads
src/telegram/bot-message-context.dm-threads.test.ts: Add tests for ThreadLabel in DM threads
ui/src/ui/app-lifecycle.ts: Read URL session param before syncTabWithLocation overwrites it with localStorage value

Problem 1: Display

All DM topic sessions showed the same display name. Now each shows its thread ID (Thread: 42, Thread: 99).

Problem 2: Navigation

Clicking a session in the Sessions tab redirected to Main instead of the clicked session.

Root cause: syncTabWithLocation() was called before applySettingsFromUrl(), overwriting the URL ?session= param with localStorage.

Fix: Call applySettingsFromUrl() first.

Problem 3: DM Thread Delivery (regression)

Commit 9154971 (fix(telegram): ignore message_thread_id for non-forum group sessions) changed resolveTelegramForumThreadId to return undefined when is_forum is false. This correctly fixed reply-chain pollution in regular groups, but broke DM thread delivery:

Telegram Bot API never sets is_forum=true for private chats (only supergroups)
context.resolvedThreadId (used by bot-message-dispatch.ts for draft streaming and reply delivery) became undefined for all DM threads
Replies, typing indicators, and voice recording indicators all went to General

Fix: Introduce effectiveThreadId = isGroup ? resolvedThreadId : messageThreadId — uses raw messageThreadId for DMs (bypassing the forum gate) while preserving forum-resolved value for groups.

Testing

pnpm test src/telegram/bot-message-context.dm-threads.test.ts

All 7 tests pass, including 2 new tests for ThreadLabel.

Greptile Overview

Greptile Summary

This PR fixes three related Telegram DM-topic regressions: (1) adds a ThreadLabel payload field so DM topic sessions can be distinguished in the Sessions UI, (2) ensures URL settings (including ?session=) are applied before syncTabWithLocation() overwrites state from localStorage, and (3) restores correct DM-thread outbound routing by using a DM-specific thread id (message_thread_id) for typing indicators and dispatch context when is_forum is absent (private chats never set is_forum=true).

The changes integrate into the existing Telegram context builder (buildTelegramMessageContext) by adjusting how thread IDs are computed and emitted, and into the UI lifecycle by reordering initialization to preserve URL-driven navigation.

Confidence Score: 4/5

This PR is generally safe to merge, with one edge-case routing concern around non-group non-DM chat types.
Changes are localized and covered by targeted tests for DM thread session keys/labels; the main remaining risk is that effectiveThreadId is applied to all non-group chats (e.g., channels), which may not support message_thread_id semantics and could cause misrouting or Telegram API errors.
src/telegram/bot-message-context.ts

lobster-biscuit

ndraiman · 2026-01-29T06:13:51Z

src/telegram/bot-message-context.ts

@@ -161,6 +161,9 @@ export const buildTelegramMessageContext = async ({
    isForum,
    messageThreadId,
  });
+  // Effective thread ID for outbound delivery: groups use forum-resolved; DMs use raw messageThreadId
+  // (private chats never set is_forum=true per Telegram Bot API, so resolvedThreadId is always undefined for DMs)
+  const effectiveThreadId = isGroup ? resolvedThreadId : messageThreadId;


had issues with threaded mode on DMs in telegram.
Fixed it for myself, came to open a PR and found you already have it here 🙂🙏

- Add ThreadLabel for DM threads (format: 'Thread: N') - Add unit tests for ThreadLabel in DM threads - Fix UI: read URL session param before syncTabWithLocation overwrites it

Commit 9154971 changed resolveTelegramForumThreadId to return undefined when is_forum is false. This broke DM thread delivery because Telegram Bot API never sets is_forum=true for private chats. Introduce effectiveThreadId that uses raw messageThreadId for DMs while preserving forum-resolved value for groups.

greptile-apps

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-03T03:51:32Z

src/telegram/bot-message-context.ts

+  // Effective thread ID for outbound delivery: groups use forum-resolved; DMs use raw messageThreadId
+  // (private chats never set is_forum=true per Telegram Bot API, so resolvedThreadId is always undefined for DMs)
+  const effectiveThreadId = isGroup ? resolvedThreadId : messageThreadId;
  const { groupConfig, topicConfig } = resolveTelegramGroupConfig(chatId, resolvedThreadId);


[P1] effectiveThreadId applies to all non-group chats, including channels.

const effectiveThreadId = isGroup ? resolvedThreadId : messageThreadId; assumes any non-group chat is a DM where message_thread_id should be honored. However Telegram “channel” chats are also non-group (chat.type === "channel"), and channels don’t support message_thread_id the same way; passing it into sendChatAction / reply routing can misroute or cause API errors depending on message shape. Consider gating this to private chats specifically (e.g. msg.chat.type === "private") so only DM topics use raw messageThreadId.

Prompt To Fix With AI

This is a comment left during a code review. Path: src/telegram/bot-message-context.ts Line: 164:167 Comment: [P1] `effectiveThreadId` applies to all non-group chats, including channels. `const effectiveThreadId = isGroup ? resolvedThreadId : messageThreadId;` assumes any non-group chat is a DM where `message_thread_id` should be honored. However Telegram “channel” chats are also non-group (`chat.type === "channel"`), and channels don’t support `message_thread_id` the same way; passing it into `sendChatAction` / reply routing can misroute or cause API errors depending on message shape. Consider gating this to private chats specifically (e.g. `msg.chat.type === "private"`) so only DM topics use raw `messageThreadId`. How can I resolve this? If you propose a fix, please make it concise.

Glucksberg · 2026-02-08T12:00:36Z

📋 Duplicate triage note: PR #8170 appears to implement the same fix. Consider consolidating efforts or closing one in favor of the other.

steipete · 2026-02-24T05:34:58Z

Closing as AI-assisted stale-fix triage.

Linked issue #3367 ("Sessions navigation fix + DM thread display + DM thread delivery regression") is currently closed and was closed on 2026-02-04T00:57:57Z with state reason completed.
Given that issue is closed, this fix PR is no longer needed in the active queue and is being closed as stale.

If this specific implementation is still needed on current main, please reopen #3368 (or open a new focused fix PR) and reference #3367 for fast re-triage.

openclaw-barnacle bot added channel: telegram Channel integration: telegram app: web-ui App: web-ui labels Jan 28, 2026

Lukavyi changed the title ~~feat(telegram): display thread ID for DM topics in Sessions tab~~ feat(telegram): display thread ID for DM topics + fix Sessions tab navigation Jan 28, 2026

Lukavyi changed the title ~~feat(telegram): display thread ID for DM topics + fix Sessions tab navigation~~ fix(ui): clicking session in Sessions tab navigates to wrong session + add Telegram DM thread display Jan 28, 2026

Lukavyi force-pushed the fix/telegram-dm-thread-display branch from 92f2e59 to 6025fa6 Compare January 28, 2026 14:25

This was referenced Jan 28, 2026

fix(telegram): restore DM thread delivery after forum-only gate #3543

Closed

Sessions navigation fix + DM thread display + DM thread delivery regression #3367

Closed

Lukavyi changed the title ~~fix(ui): clicking session in Sessions tab navigates to wrong session + add Telegram DM thread display~~ fix: sessions navigation, DM thread display, and DM thread delivery regression Jan 28, 2026

ndraiman reviewed Jan 29, 2026

View reviewed changes

Lukavyi added 2 commits January 29, 2026 08:40

feat(telegram): display thread ID for DM topics in Sessions tab

5cad6d3

- Add ThreadLabel for DM threads (format: 'Thread: N') - Add unit tests for ThreadLabel in DM threads - Fix UI: read URL session param before syncTabWithLocation overwrites it

Lukavyi force-pushed the fix/telegram-dm-thread-display branch from 8a67184 to 4ae5687 Compare January 29, 2026 07:40

Lukavyi mentioned this pull request Jan 29, 2026

fix(telegram): preserve messageThreadId for DM reply threads #3916

Closed

Merge branch 'main' into fix/telegram-dm-thread-display

8d29403

greptile-apps bot reviewed Feb 3, 2026

View reviewed changes

thewilloftheshadow force-pushed the main branch from bfc1ccb to f92900f Compare February 15, 2026 18:46

0xble mentioned this pull request Feb 16, 2026

fix(telegram): PR #10942 re-breaks DM topic threading #18168

Closed

Lukavyi mentioned this pull request Feb 17, 2026

[Bug] Telegram DM topics keep breaking: conflicting fixes suppress message_thread_id for private chats #18974

Closed

steipete closed this Feb 24, 2026

hnykda mentioned this pull request Mar 9, 2026

Mattermost: Channel-bound sessions cannot thread replies (dispatcher routing bug) #40924

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: sessions navigation, DM thread display, and DM thread delivery regression#3368

fix: sessions navigation, DM thread display, and DM thread delivery regression#3368
Lukavyi wants to merge 3 commits intoopenclaw:mainfrom
Lukavyi:fix/telegram-dm-thread-display

Lukavyi commented Jan 28, 2026 •

edited

Loading

Uh oh!

ndraiman Jan 29, 2026

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Feb 3, 2026

Uh oh!

Glucksberg commented Feb 8, 2026

Uh oh!

steipete commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Lukavyi commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Problem 1: Display

Problem 2: Navigation

Problem 3: DM Thread Delivery (regression)

Testing

Greptile Overview

Greptile Summary

Confidence Score: 4/5

Uh oh!

ndraiman Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Glucksberg commented Feb 8, 2026

Uh oh!

steipete commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Lukavyi commented Jan 28, 2026 •

edited

Loading