fix(gateway): hot-reload agents.defaults.models allowlist changes#33606
fix(gateway): hot-reload agents.defaults.models allowlist changes#33606hclsys wants to merge 1 commit intoopenclaw:mainfrom
Conversation
The reload plan had a rule for `agents.defaults.model` (singular) but not `agents.defaults.models` (plural — the allowlist array). Because `agents.defaults.models` does not prefix-match `agents.defaults.model.`, it fell through to the catch-all `agents` tail rule (kind=none), so allowlist edits in openclaw.json were silently ignored at runtime. Add a dedicated reload rule so changes to the models allowlist trigger a heartbeat restart, which re-reads the config and serves the updated list to clients. Fixes openclaw#33600 Co-authored-by: HCL <[email protected]> Signed-off-by: HCL <[email protected]>
Greptile SummaryThis PR fixes a silent no-op bug in the gateway config hot-reload system: changes to The fix adds a dedicated Key changes:
Confidence Score: 5/5
Last reviewed commit: a615f0c |
|
Thanks again for this work. This was landed indirectly via the synthesized PR #33831, and your contribution is credited in the changelog and as a co-author on the merge commit. This PR merge/triage workflow is AI-assisted. Closing this PR as superseded by #33831. If anything here looks incorrect or incomplete, reply to reopen and we can reassess. |
Summary
agents.defaults.models(plural — the allowlist array) had no reload rule. Changes to the model allowlist inopenclaw.jsonwere silently ignored at runtime because the path fell through to the catch-allagentstail rule (kind=none).The existing rule for
agents.defaults.model(singular) does not prefix-matchagents.defaults.models— the next character iss, not..Changes
agents.defaults.modelsreload rule withrestart-heartbeatactionTest plan
pnpm vitest run src/gateway/config-reload.test.ts— 22/22 passagents.defaults.model(singular) test still passesagents.defaults.models→restartHeartbeat=true, notnoopPathsFixes #33600
lobster-biscuit