fix(queue): dedupe queued message IDs across drain restarts#33168
fix(queue): dedupe queued message IDs across drain restarts#33168rylena wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Greptile SummaryThis PR fixes a duplicate-message delivery bug in the followup queue by introducing a short-lived, module-level dedupe cache ( The Confidence Score: 4/5
Last reviewed commit: b86b4d9 |
|
This PR should be pushed independently of #33455. #33455 fixes a different issue (duplicate outbound agent), but this bug and PR address the root cause of duplicate incoming messages. It was referenced as fixing #33150, but it's not a real fix for that issue. It might reduce the visible impact, but duplicates would still be delivered to the agent, still burn tokens, and the agent would still need to process them — the outbound dedup just catches duplicate responses. |
Landed from contributor PR #33168 by @rylena. Co-authored-by: Rylen Anil <[email protected]>
|
Landed on 5edcab2 from source commit b86b4d9. What was done:
Thanks @rylena for the fix and repro detail. |
Landed from contributor PR openclaw#33168 by @rylena. Co-authored-by: Rylen Anil <[email protected]>
Landed from contributor PR openclaw#33168 by @rylena. Co-authored-by: Rylen Anil <[email protected]>
Landed from contributor PR openclaw#33168 by @rylena. Co-authored-by: Rylen Anil <[email protected]>
Landed from contributor PR openclaw#33168 by @rylena. Co-authored-by: Rylen Anil <[email protected]>
Landed from contributor PR openclaw#33168 by @rylena. Co-authored-by: Rylen Anil <[email protected]>
Landed from contributor PR openclaw#33168 by @rylena. Co-authored-by: Rylen Anil <[email protected]>
Landed from contributor PR openclaw#33168 by @rylena. Co-authored-by: Rylen Anil <[email protected]>
Landed from contributor PR openclaw#33168 by @rylena. Co-authored-by: Rylen Anil <[email protected]>
Landed from contributor PR openclaw#33168 by @rylena. Co-authored-by: Rylen Anil <[email protected]>
Landed from contributor PR openclaw#33168 by @rylena. Co-authored-by: Rylen Anil <[email protected]>
Landed from contributor PR openclaw#33168 by @rylena. Co-authored-by: Rylen Anil <[email protected]> (cherry picked from commit 5edcab2)
Landed from contributor PR openclaw#33168 by @rylena. Co-authored-by: Rylen Anil <[email protected]> (cherry picked from commit 5edcab2)
Summary
Fixes duplicate queued-message delivery when a channel re-emits the same provider message_id while the agent is busy.
Root cause
Followup queue dedupe only compared against items currently in the in-memory queue. Once a drain completed and the queue was deleted/recreated, a redelivery of the same message_id was accepted as a brand-new queued item.
Changes
Tests
Fixes #33150