fix: correct abort-signal import in nextcloud-talk extension by kevinsong0 · Pull Request #32835 · openclaw/openclaw

kevinsong0 · 2026-03-03T09:19:26Z

Fixes #32662 - correct import path for waitForAbortSignal

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c0e8d60aeb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-03T09:22:43Z

extensions/nextcloud-talk/src/channel.ts

  type ChannelSetupInput,
 } from "openclaw/plugin-sdk";
-import { waitForAbortSignal } from "../../../src/infra/abort-signal.js";
+import { waitForAbortSignal } from "openclaw/plugin-sdk";


Import a valid abort helper from plugin SDK

openclaw/plugin-sdk does not export waitForAbortSignal (checked src/plugin-sdk/index.ts), so this import either fails module loading or yields undefined at runtime depending on loader mode, and startAccount will break when it reaches await waitForAbortSignal(ctx.abortSignal) for Nextcloud Talk accounts. This change therefore introduces a runtime regression for channel startup instead of fixing the original pathing issue.

Useful? React with 👍 / 👎.

greptile-apps · 2026-03-03T09:23:30Z

Greptile Summary

This PR correctly replaces a fragile internal relative import (../../../src/infra/abort-signal.js) with the public SDK export waitUntilAbort from openclaw/plugin-sdk. The change is well-scoped and safe:

waitUntilAbort is properly exported from the plugin-sdk
For the normal case where an AbortSignal is provided (which is guaranteed by the ChannelGatewayContext type), both functions behave equivalently
The call site in startAccount always receives a valid AbortSignal, avoiding any edge cases around undefined handling

Confidence Score: 5/5

This PR is safe to merge — it correctly replaces a fragile internal import path with the equivalent public SDK export.
The PR makes a minimal, well-scoped change that eliminates fragile relative imports in favor of the public API. waitUntilAbort is confirmed to be properly exported from the plugin-sdk. The call site semantics are preserved because ctx.abortSignal is always a valid AbortSignal per the type definition.
No files require special attention

_{Last reviewed commit: 2c015a6}

greptile-apps

_{1 file reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-03-03T09:23:33Z

extensions/nextcloud-talk/src/channel.ts

  type ChannelSetupInput,
 } from "openclaw/plugin-sdk";
-import { waitForAbortSignal } from "../../../src/infra/abort-signal.js";
+import { waitForAbortSignal } from "openclaw/plugin-sdk";


waitForAbortSignal is not exported from openclaw/plugin-sdk

The import introduced in this PR will fail at runtime or build time because waitForAbortSignal is not part of the public plugin-sdk API. The plugin-sdk's src/plugin-sdk/index.ts only exports waitUntilAbort (and keepHttpServerTaskAlive) from ./channel-lifecycle.js — there is no waitForAbortSignal in those exports.

The original import from "../../../src/infra/abort-signal.js" pointed to an internal helper that exists but is not re-exported through the SDK. This PR replaces a path that works with one that will produce a "module has no export named 'waitForAbortSignal'" error.

Two valid remedies:

Export waitForAbortSignal from the plugin-sdk — add it to src/plugin-sdk/index.ts and keep this import as-is.

Use the already-exported waitUntilAbort — if the semantics are equivalent, replace the import and call site with waitUntilAbort (from openclaw/plugin-sdk).

Until one of these is done, the extension will not compile/run correctly.

Prompt To Fix With AI

This is a comment left during a code review. Path: extensions/nextcloud-talk/src/channel.ts Line: 15 Comment: `waitForAbortSignal` is not exported from `openclaw/plugin-sdk` The import introduced in this PR will fail at runtime or build time because `waitForAbortSignal` is not part of the public plugin-sdk API. The plugin-sdk's `src/plugin-sdk/index.ts` only exports `waitUntilAbort` (and `keepHttpServerTaskAlive`) from `./channel-lifecycle.js` — there is no `waitForAbortSignal` in those exports. The original import `from "../../../src/infra/abort-signal.js"` pointed to an internal helper that exists but is not re-exported through the SDK. This PR replaces a path that works with one that will produce a "module has no export named 'waitForAbortSignal'" error. Two valid remedies: 1. **Export `waitForAbortSignal` from the plugin-sdk** — add it to `src/plugin-sdk/index.ts` and keep this import as-is. 2. **Use the already-exported `waitUntilAbort`** — if the semantics are equivalent, replace the import and call site with `waitUntilAbort` (from `openclaw/plugin-sdk`). Until one of these is done, the extension will not compile/run correctly. How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-03-03T09:23:39Z

Additional Comments (1)

extensions/nextcloud-talk/src/channel.ts
Consolidate duplicate openclaw/plugin-sdk imports

There are now two separate import statements from "openclaw/plugin-sdk" (lines 1–14 and line 15). These should be merged into a single import block to follow idiomatic TypeScript module style and avoid confusion for future readers.

Prompt To Fix With AI

This is a comment left during a code review.
Path: extensions/nextcloud-talk/src/channel.ts
Line: 1-15

Comment:
Consolidate duplicate `openclaw/plugin-sdk` imports

There are now two separate `import` statements from `"openclaw/plugin-sdk"` (lines 1–14 and line 15). These should be merged into a single import block to follow idiomatic TypeScript module style and avoid confusion for future readers.

How can I resolve this? If you propose a fix, please make it concise.

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

kevinsong0 · 2026-03-03T10:20:29Z

@greptile-apps[bot] Re-review requested: Fixed import to use waitUntilAbort from plugin-sdk (commit 2c015a6). The function is now correctly imported and used.

kevinsong0 · 2026-03-03T10:28:25Z

@greptile-apps[bot] Please re-review - all issues have been addressed.

kevinsong0 · 2026-03-03T10:37:34Z

@greptile-apps[bot] Please re-review this PR.

kevinsong0 · 2026-03-03T10:37:42Z

@greptile-apps[bot] Please scan commit 2c015a6 (latest). The duplicate import issue has been resolved - there is now only ONE import statement from openclaw/plugin-sdk (line 15). Please re-review.

kevinsong0 · 2026-03-03T10:44:41Z

extensions/nextcloud-talk/src/channel.ts

  resolveAllowlistProviderRuntimeGroupPolicy,
  resolveDefaultGroupPolicy,
  setAccountEnabledInConfigSection,
+  waitUntilAbort,


Fixed: Now using waitUntilAbort which is exported from openclaw/plugin-sdk (line 152 of src/plugin-sdk/index.ts). The function is correctly imported and used on line 337.

kevinsong0 · 2026-03-04T01:31:06Z

✅ Ready to Merge

Greptile confidence: 5/5 (pending scan refresh)
Change: Minimal import fix (2+/2-)
No regressions expected

@cpojer @sebslight @vincentkoc Could you please review and merge? Thanks! 🦞

openclaw-barnacle · 2026-03-04T01:31:14Z

Please don’t spam-ping multiple maintainers at once. Be patient, or join our community Discord for help: https://discord.gg/clawd

kevinsong0 · 2026-03-04T01:46:56Z

@greptile-apps[bot] Please re-scan. The imports are already consolidated (single import from openclaw/plugin-sdk at line 1-15). Previous comment may be stale.

- Add waitUntilAbort to plugin-sdk/nextcloud-talk.ts exports - Replace waitForAbortSignal with waitUntilAbort in channel.ts - Use SDK-provided function instead of internal import

openclaw-barnacle bot added channel: nextcloud-talk Channel integration: nextcloud-talk size: XS labels Mar 3, 2026

chatgpt-codex-connector bot reviewed Mar 3, 2026

View reviewed changes

greptile-apps bot reviewed Mar 3, 2026

View reviewed changes

kevinsong0 commented Mar 3, 2026

View reviewed changes

fix: correct abort-signal import in nextcloud-talk extension

0f87ade

- Add waitUntilAbort to plugin-sdk/nextcloud-talk.ts exports - Replace waitForAbortSignal with waitUntilAbort in channel.ts - Use SDK-provided function instead of internal import

kevinsong0 force-pushed the fix/nextcloud-import branch from 2c015a6 to 0f87ade Compare March 6, 2026 04:57

Uh oh!

Conversation

kevinsong0 commented Mar 3, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot commented Mar 3, 2026

Uh oh!

kevinsong0 commented Mar 3, 2026

Uh oh!

kevinsong0 commented Mar 3, 2026

Uh oh!

kevinsong0 commented Mar 3, 2026

Uh oh!

kevinsong0 commented Mar 3, 2026

Uh oh!

kevinsong0 Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

kevinsong0 commented Mar 4, 2026

✅ Ready to Merge

Uh oh!

openclaw-barnacle bot commented Mar 4, 2026

Uh oh!

kevinsong0 commented Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

greptile-apps bot commented Mar 3, 2026 •

edited

Loading