Gateway: allow webchat session label updates#32574
Open
zwright8 wants to merge 1 commit intoopenclaw:mainfrom
Open
Gateway: allow webchat session label updates#32574zwright8 wants to merge 1 commit intoopenclaw:mainfrom
zwright8 wants to merge 1 commit intoopenclaw:mainfrom
Conversation
18 tasks
Contributor
Greptile SummaryThis PR extracts a focused change from #26712 to allow webchat clients to update the Key changes:
Confidence Score: 4/5
Last reviewed commit: 6f8faa3 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+105
to
+111
| function isWebchatLabelOnlyPatch(patch: SessionsPatchParams): boolean { | ||
| const keys = Object.keys(patch).filter((key) => key !== "key"); | ||
| if (keys.length !== 1 || keys[0] !== "label") { | ||
| return false; | ||
| } | ||
| return Object.hasOwn(patch, "label"); | ||
| } |
Contributor
There was a problem hiding this comment.
Redundant Object.hasOwn check
The final return Object.hasOwn(patch, "label") is always true when reached. At that point, the code has already verified that keys[0] === "label" (line 107), and keys is derived from Object.keys(patch) — so if "label" appears in Object.keys(patch), then Object.hasOwn(patch, "label") is necessarily true. The function could be simplified:
Suggested change
| function isWebchatLabelOnlyPatch(patch: SessionsPatchParams): boolean { | |
| const keys = Object.keys(patch).filter((key) => key !== "key"); | |
| if (keys.length !== 1 || keys[0] !== "label") { | |
| return false; | |
| } | |
| return Object.hasOwn(patch, "label"); | |
| } | |
| function isWebchatLabelOnlyPatch(patch: SessionsPatchParams): boolean { | |
| const keys = Object.keys(patch).filter((key) => key !== "key"); | |
| return keys.length === 1 && keys[0] === "label"; | |
| } |
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/gateway/server-methods/sessions.ts
Line: 105-111
Comment:
**Redundant `Object.hasOwn` check**
The final `return Object.hasOwn(patch, "label")` is always `true` when reached. At that point, the code has already verified that `keys[0] === "label"` (line 107), and `keys` is derived from `Object.keys(patch)` — so if `"label"` appears in `Object.keys(patch)`, then `Object.hasOwn(patch, "label")` is necessarily `true`. The function could be simplified:
```suggestion
function isWebchatLabelOnlyPatch(patch: SessionsPatchParams): boolean {
const keys = Object.keys(patch).filter((key) => key !== "key");
return keys.length === 1 && keys[0] === "label";
}
```
How can I resolve this? If you propose a fix, please make it concise.
Contributor
Additional Comments (1)
The test is named Prompt To Fix With AIThis is a comment left during a code review.
Path: src/gateway/server.sessions.gateway-server-sessions-a.test.ts
Line: 1211
Comment:
**Misleading test name**
The test is named `"webchat clients cannot patch or delete sessions"`, but this PR explicitly changes the behavior so that webchat clients *can* patch sessions (specifically label-only patches). The test body now asserts that `patchedLabel.ok` is `true`, which directly contradicts the test description. A future developer reading this test name would be confused about the intended contract.
```suggestion
test("webchat clients can patch label but cannot patch other fields or delete sessions", async () => {
```
How can I resolve this? If you propose a fix, please make it concise. |
zwright8
force-pushed
the
codex/pr26712-gateway-webchat-session-label-update
branch
from
6f8faa3 to
11e4634
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm exec vitest run src/gateway/server.sessions.gateway-server-sessions-a.test.tsContext
This PR is one focused slice extracted from: