fix(errors): simplify auth error message when API key is missing#32170
fix(errors): simplify auth error message when API key is missing#32170ademczuk wants to merge 4 commits intoopenclaw:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 38a7c8ae2e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Greptile SummarySimplified API key error messages by replacing technical details (auth store paths, agentDir) with clear, actionable instructions. When an API key is missing, users now see which environment variable to set and what command to run, rather than internal file paths.
Confidence Score: 5/5
Last reviewed commit: 38a7c8a |
|
Good catch — fixed in 78bfd4e. The command is now The original error had the same issue ( |
78bfd4e to
a9433a8
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a9433a8b56
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Addressed Codex P2 ("Use agent-scoped guidance in missing-key hint") in 5924c21: When |
CI failures: pre-existing upstream issues (not from this PR)Both 1.
|
f4bbf93 to
cc60f43
Compare
When resolveApiKeyForProvider is called with a non-default agentDir, the error now appends the agent-specific auth store path so users know which store needs credentials in multi-agent setups. Addresses Codex P2: "Use agent-scoped guidance in missing-key hint". Co-Authored-By: Claude Opus 4.6 <[email protected]>
cc60f43 to
a1bb45d
Compare
|
Looks like Peter already fixed it. Commit 0e16749 landed on main — fixes both the pairing-store.ts lint errors, the agents-utils.ts lint error, AND bumps the googlechat/memory-core deps (npm audit fix). Both issues are already resolved on main. Please take a look at this @Takhoffman at your leisure. |
Summary
PROVIDER_ENV_MAPconstant to deduplicate the provider → env var mappingBefore
After
Test plan
pnpm check— zero lint errors"no api key found"substring match) still works|/model→ select unconfigured provider → verify clear error messagecc @vincentkoc for review
🤖 Generated with Claude Code