Build: harden A2UI bundle for Windows+WSL shell path(AI-assisted:Codex)#31840
Build: harden A2UI bundle for Windows+WSL shell path(AI-assisted:Codex)#31840ly85206559 wants to merge 12 commits intoopenclaw:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1b198ed5d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Greptile SummaryRefactored A2UI bundling to improve Windows/WSL compatibility by moving core logic from bash to Node.js. The new Key improvements:
The implementation correctly handles the complex Windows/WSL environment where bash shell and Windows Node need to coordinate, addressing the original issue where mixed environments couldn't reliably resolve downstream commands. Confidence Score: 4/5
Last reviewed commit: b1b198e |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f565967323
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ly85206559
force-pushed
the
fix/windows-a2ui-bundle-wsl-path
branch
from
ce0a1ab to
39e8753
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 39e8753254
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ly85206559
force-pushed
the
fix/windows-a2ui-bundle-wsl-path
branch
3 times, most recently
from
65f9be5 to
5cd790d
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5cd790d7ee
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ly85206559
changed the title
|
Windows shard stuck/hung, reran CI please,ths @steipete |
ly85206559
force-pushed
the
fix/windows-a2ui-bundle-wsl-path
branch
5 times, most recently
from
9bbc733 to
fbfd6dc
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fbfd6dc9fd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ly85206559
force-pushed
the
fix/windows-a2ui-bundle-wsl-path
branch
from
0b902fc to
d066533
Compare
|
Hi team, this PR improves A2UI bundling on Windows/WSL (scripts, no product logic). |
|
Quick status update: this PR is up to date with When a maintainer has bandwidth, could someone help with final review/merge? Thanks! PR: #31840 |
1 participant
Summary
scripts/bundle-a2ui.mjsscripts/bundle-a2ui.shas a thin launcher, with Windows+WSL handling fornode.exeWhy
pnpm buildcould fail on Windows whencanvas:a2ui:bundlewas executed throughbash, because the mixed WSL shell + Windows Node environment could not reliably resolve downstream commands.Validation
AI-assisted
pnpm canvas:a2ui:bundle+pnpm build; CI coverspnpm check+pnpm test(including Windows shards).scripts/bundle-a2ui.shis a launcher for mixed WSL bash + Windowsnode.exe.scripts/bundle-a2ui.mjsperforms hash-based incremental bundling, runstsc, and invokesrolldownwith robust Windows/WSL executable fallback logic (including.cmdshims and UNC/WSL path edge cases).Key Review Fixes
.cmdprobe exits non-zero undershell: true(don’t fail-fast; try later candidates).rolldowncandidates after a failed--versionprobe before falling back topnpm dlx..cmdtools with a UNC working directory (e.g.\\wsl.localhost\...) to preventcmd.execwd failures.