Plugins: expose runtime.system.requestHeartbeatNow#31579
Closed
liuxiaopai-ai wants to merge 1 commit intoopenclaw:mainfrom
Closed
Plugins: expose runtime.system.requestHeartbeatNow#31579liuxiaopai-ai wants to merge 1 commit intoopenclaw:mainfrom
liuxiaopai-ai wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Contributor
Greptile SummaryThis PR exposes the existing Key changes:
Implementation quality:
Confidence Score: 5/5
Last reviewed commit: c564d16 |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Describe the problem and fix in 2–5 bullets:
requestHeartbeatNow(...)exists in core heartbeat infra but is not exposed throughPluginRuntime.system, forcing plugins to use/hooks/wakeloopback workarounds.sessionKeywake in-process, and loopback wake only covers main-session behavior.requestHeartbeatNowto plugin runtime system surface (runtime implementation + runtime types), and added runtime test coverage./hooks/wakebehavior; no routing logic changes.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
runtime.system.requestHeartbeatNow({ reason, sessionKey, agentId, coalesceMs })directly.Security Impact (required)
No)No)No)No)No)Yes, explain risk + mitigation:Repro + Verification
Environment
Steps
createPluginRuntime().runtime.system.requestHeartbeatNow({ reason, sessionKey, agentId, coalesceMs }).Expected
requestHeartbeatNowunchanged.Actual
requestHeartbeatNow.Evidence
Attach at least one:
Failing test/log before + passing after
Trace/log snippets
Screenshot/recording
Perf numbers (if relevant)
Updated tests:
src/plugins/runtime/index.test.tsextensions/bluebubbles/src/monitor.test.ts(runtime mock updated for new required system field)Ran:
pnpm test src/plugins/runtime/index.test.ts extensions/bluebubbles/src/monitor.test.tspnpm formatpnpm check(fails in unrelated pre-existing files)Human Verification (required)
What you personally verified (not just CI), and how:
system.requestHeartbeatNowCompatibility / Migration
Yes)No)No)Failure Recovery (if this breaks)
src/plugins/runtime/index.tssrc/plugins/runtime/types.tsPluginRuntimemocksRisks and Mitigations
List only real risks for this PR. Add/remove entries as needed. If none, write
None.PluginRuntime.systemcan break strict mock objects in tests/extensions.