fix(discord): send online presence on ready when no custom presence is configured by Sid-Qin · Pull Request #31333 · openclaw/openclaw

Sid-Qin · 2026-03-02T05:49:15Z

Summary

Problem: Discord bot appears offline (gray status dot) despite functioning correctly. Messages send and receive fine, but the bot never shows as "online" in the Discord user list.
Why it matters: Users see the bot as offline and may think it's broken, even though it's fully operational.
What changed: resolveDiscordPresenceUpdate now returns a minimal { status: "online" } presence object when neither activity nor status is configured, instead of returning null. This ensures DiscordStatusReadyListener always calls gateway.updatePresence() on connect.
What did NOT change: Custom presence configuration (activity text, status, activity type, streaming URL) works exactly the same. Only the "no config" default changed from "no presence update" to "online".

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

Closes Discord bot shows as offline despite being functional #31260

User-visible / Behavior Changes

Discord bots now appear "online" (green status dot) by default when connected, even without explicit presence configuration.
No config changes required — this is a sensible default change.

Security Impact (required)

New permissions/capabilities? No
Secrets/tokens handling changed? No
New/changed network calls? No (presence update was already sent when configured; now it also fires when unconfigured)
Command/tool execution surface changed? No
Data access scope changed? No

Repro + Verification

Environment

OS: macOS / Linux
Runtime: Node.js 22+
Integration: Discord (any bot token)

Steps

Configure a Discord bot without activity or status fields
Start gateway
Check bot status in Discord

Expected

Bot shows as "online" (green)

Actual

Before: Bot shows as "offline" (gray)
After: Bot shows as "online" (green)

Evidence

Failing test/log before + passing after

New test file presence.test.ts with 6 test cases:

Returns online presence when no config provided
Uses configured status
Includes activity when configured
Uses custom activity type by default
Respects explicit activityType
Sets streaming URL for type 1

Human Verification (required)

Verified scenarios: no config (default online); custom status (dnd, idle); activity text with custom type; streaming URL
Edge cases checked: empty strings for activity/status (treated as unconfigured); whitespace-only values
What you did not verify: Live Discord bot with actual gateway connection

Compatibility / Migration

Backward compatible? Yes — bots with explicit presence config are unaffected. Bots without config will now appear online instead of offline.
Config/env changes? No
Migration needed? No

Failure Recovery (if this breaks)

How to disable/revert: Change the return value back to null in resolveDiscordPresenceUpdate when no config is set
Files to restore: src/discord/monitor/presence.ts

Risks and Mitigations

Risk: Users who intentionally want the bot to appear offline would now see it as online
- Mitigation: They can set status: "invisible" explicitly to hide the bot. The previous behavior was undocumented and almost certainly unintentional.

…s configured When neither activity nor status was configured, resolveDiscordPresenceUpdate returned null. The ReadyListener skipped the updatePresence call, so Discord never received a presence update and showed the bot as offline. Return a minimal { status: "online" } presence instead of null so the gateway always sends a presence update on connect. Closes openclaw#31260 Made-with: Cursor

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9e151b1ba2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-02T05:52:06Z

src/discord/monitor/presence.ts


  if (!hasActivity && !hasStatus) {
-    return null;
+    return { since: null, activities: [], status: "online", afk: false };


Update legacy tests for default online presence

This change makes resolveDiscordPresenceUpdate({}) return a non-null object, but src/discord/monitor/monitor.test.ts:714-716 still asserts the no-config case is null, so the Discord monitor test suite becomes internally inconsistent and will fail when run (pnpm test). Please update or remove that legacy assertion so CI reflects the new behavior instead of flagging this as a regression.

Useful? React with 👍 / 👎.

greptile-apps · 2026-03-02T05:53:08Z

Greptile Summary

This PR fixes the Discord bot offline status issue by ensuring a presence update is sent even when no custom presence configuration exists. The change is minimal and well-executed: resolveDiscordPresenceUpdate now returns { status: "online", activities: [] } instead of null when neither activity nor status is configured.

Changed one line in src/discord/monitor/presence.ts (line 24) from returning null to returning a default online presence
Added comprehensive test coverage with 6 test cases covering default behavior, custom status, activities, and edge cases
The fix ensures DiscordStatusReadyListener.handle() in provider.ts always calls gateway.updatePresence() on connect, making the bot appear online
Backward compatible: bots with explicit presence configuration are completely unaffected
Edge cases properly handled: empty strings, whitespace-only values, and undefined/null configs are all treated as "no config"

Confidence Score: 5/5

This PR is safe to merge with minimal risk
The change is a simple one-line fix that correctly addresses the stated problem. The implementation is clean, the test coverage is comprehensive (6 test cases), and the logic properly handles edge cases. The change is backward compatible and doesn't introduce any new dependencies or security concerns. No logical errors, type safety issues, or edge case problems were found.
No files require special attention

_{Last reviewed commit: 9e151b1}

thewilloftheshadow · 2026-03-03T16:49:05Z

Superseded by #33277 (consolidated presence/health work). Please follow the new PR.

thewilloftheshadow · 2026-03-03T18:19:14Z

Superceded by existing commits on main

openclaw-barnacle bot added channel: discord Channel integration: discord size: XS experienced-contributor labels Mar 2, 2026

chatgpt-codex-connector bot reviewed Mar 2, 2026

View reviewed changes

steipete mentioned this pull request Mar 2, 2026

fix(discord): default to online status when no presence config provided #31484

Closed

thewilloftheshadow mentioned this pull request Mar 3, 2026

fix(discord): auto presence health signal #33277

Merged

18 tasks

thewilloftheshadow closed this Mar 3, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(discord): send online presence on ready when no custom presence is configured#31333

fix(discord): send online presence on ready when no custom presence is configured#31333
Sid-Qin wants to merge 1 commit intoopenclaw:mainfrom
Sid-Qin:fix/discord-bot-presence-31260

Sid-Qin commented Mar 2, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 2, 2026

Uh oh!

greptile-apps bot commented Mar 2, 2026

Uh oh!

thewilloftheshadow commented Mar 3, 2026

Uh oh!

thewilloftheshadow commented Mar 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Sid-Qin commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

User-visible / Behavior Changes

Security Impact (required)

Repro + Verification

Environment

Steps

Expected

Actual

Evidence

Human Verification (required)

Compatibility / Migration

Failure Recovery (if this breaks)

Risks and Mitigations

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot commented Mar 2, 2026

Greptile Summary

Confidence Score: 5/5

Uh oh!

thewilloftheshadow commented Mar 3, 2026

Uh oh!

thewilloftheshadow commented Mar 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sid-Qin commented Mar 2, 2026 •

edited

Loading