fix(models): keep openai gpt-5.3-codex on openai provider [AI-assisted]#30849
Closed
liuxiaopai-ai wants to merge 1 commit into
Closed
fix(models): keep openai gpt-5.3-codex on openai provider [AI-assisted]#30849liuxiaopai-ai wants to merge 1 commit into
liuxiaopai-ai wants to merge 1 commit into
Conversation
🔒 Aisle Security Analysis✅ We scanned this PR and did not find any security vulnerabilities. Aisle supplements but does not replace security review. Analyzed PR: #30849 at commit Last updated on: 2026-03-01T17:46:48Z |
Contributor
Greptile SummaryThis PR fixes the forced remapping of Key changes:
Impact:
Confidence Score: 5/5
Last reviewed commit: 641b84d |
This was referenced Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Describe the problem and fix in 2–5 bullets:
openai/gpt-5.3-codexwas force-normalized toopenai-codex/gpt-5.3-codex, which pushes API-key users into Codex OAuth flow and can fail with token/account extraction errors.openaiprovider should not be silently rerouted to a different provider/auth path.openai/gpt-5.3-codexnow stays onopenai.openaiprovider support forgpt-5.3-codexforward-compat model fallback (usingopenai-responses/https://api.openai.com/v1), while preserving existingopenai-codex/github-copilotbehavior.openai-codex/*explicit refs, no auth-profile format changes, no provider usage accounting schema changes.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
openai/gpt-5.3-codexnow remains on provideropenaiinstead of being rerouted toopenai-codex.openaiprovidergpt-5.3-codexvia template cloning.Security Impact (required)
Yes/No) NoYes/No) NoYes/No) NoYes/No) NoYes/No) NoYes, explain risk + mitigation:Repro + Verification
Environment
agents.defaults.model.primary: openai/gpt-5.3-codexSteps
openai/gpt-5.3-codex.openaiand forward-compat fallback resolves model metadata.Expected
openai-codexwhen user explicitly usesopenai.openaifallback model forgpt-5.3-codexremains resolvable.Actual
openaiis preserved and fallback resolution succeeds.Evidence
Attach at least one:
Commands run:
pnpm exec oxfmt --check CHANGELOG.md src/agents/model-selection.ts src/agents/model-selection.test.ts src/agents/model-fallback.test.ts src/agents/model-forward-compat.ts src/agents/pi-embedded-runner/model.test-harness.ts src/agents/pi-embedded-runner/model.forward-compat.test.ts src/agents/pi-embedded-runner/model.test.tspnpm exec vitest run src/agents/model-selection.test.ts src/agents/model-fallback.test.ts src/agents/pi-embedded-runner/model.forward-compat.test.ts src/agents/pi-embedded-runner/model.test.tspnpm exec vitest run src/gateway/session-utils.test.ts src/commands/agent.acp.test.ts src/commands/sessions.model-resolution.test.tspnpm exec vitest run src/agents/model-auth.profiles.test.ts src/commands/models/list.list-command.forward-compat.test.tspnpm buildHuman Verification (required)
What you personally verified (not just CI), and how:
openaiforgpt-5.3-codexrefs.openaicandidate (not forcedopenai-codex) forgpt-5.3-codex.openaiandopenai-codexproviders.Compatibility / Migration
Yes/No) YesYes/No) NoYes/No) NoFailure Recovery (if this breaks)
src/agents/model-selection.tsandsrc/agents/model-forward-compat.ts.openai/gpt-5.3-codexunexpectedly routing back toopenai-codexor unresolved unknown-model errors foropenai/gpt-5.3-codex.Risks and Mitigations
openaitoopenai-codexforgpt-5.3-codexcould observe provider behavior change.openai-codex/*refs are unchanged; forward-compat fallback now supportsopenaiprovider path with dedicated tests.AI-assisted: Yes (Codex). Testing degree: fully tested for this change scope.