Feishu: fallback to create send when reply target is withdrawn#30444
Closed
bmendonca3 wants to merge 1 commit into
Closed
Feishu: fallback to create send when reply target is withdrawn#30444bmendonca3 wants to merge 1 commit into
bmendonca3 wants to merge 1 commit into
Conversation
Contributor
Greptile SummaryImplemented fallback mechanism for Feishu message/card replies when the target message has been withdrawn or deleted. The change prevents user responses from being dropped by detecting specific error codes ( Key changes:
Implementation notes:
Confidence Score: 5/5
Last reviewed commit: 192b8d7 |
Contributor
|
Deep-reviewed and landed on main in 2a252a1 (fix(feishu): harden target routing, dedupe, and reply fallback). Closing this PR as superseded by mainline fixup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Describe the problem and fix in 2–5 bullets:
230011/231003), causing replies to be dropped.message.createsend.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
Security Impact (required)
No)No)No)No)No)Yes, explain risk + mitigation:Repro + Verification
Environment
Steps
replyToMessageId.pnpm vitest extensions/feishu/src/send.reply-fallback.test.ts --runpnpm checkExpected
Actual
Evidence
Attach at least one:
Human Verification (required)
What you personally verified (not just CI), and how:
230011.231003.Compatibility / Migration
Yes)No)No)Failure Recovery (if this breaks)
extensions/feishu/src/send.tsextensions/feishu/src/send.reply-fallback.test.tsRisks and Mitigations
List only real risks for this PR. Add/remove entries as needed. If none, write
None.230011,231003); message-text check is secondary.