fix(cron): wire bashElevated into isolated agentTurn runs#30425
Closed
liuxiaopai-ai wants to merge 1 commit into
Closed
fix(cron): wire bashElevated into isolated agentTurn runs#30425liuxiaopai-ai wants to merge 1 commit into
liuxiaopai-ai wants to merge 1 commit into
Conversation
Contributor
Greptile SummaryThis PR fixes a bug where cron isolated agent runs were missing elevated bash permissions configuration. Previously, Changes:
Implementation notes:
Confidence Score: 5/5
Last reviewed commit: c7186b2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentTurnruns using a cron-event contextbashElevatedintorunEmbeddedPiAgentfor cron isolated runsbashElevatedis propagated to embedded runsFixes #30379.
Why
Previously cron isolated runs omitted
bashElevatedentirely, so exec tool elevated gates always treated elevated mode as disabled.Testing
pnpm exec vitest run src/cron/isolated-agent.skips-delivery-without-whatsapp-recipient-besteffortdeliver-true.test.tspnpm exec oxlint src/cron/isolated-agent/run.ts src/cron/isolated-agent.skips-delivery-without-whatsapp-recipient-besteffortdeliver-true.test.tspnpm exec oxfmt --check src/cron/isolated-agent/run.ts src/cron/isolated-agent.skips-delivery-without-whatsapp-recipient-besteffortdeliver-true.test.ts