Feishu: fix locale-wrapper post parser test by vincentkoc · Pull Request #29576 · openclaw/openclaw

vincentkoc · 2026-02-28T07:56:09Z

Summary

Problem: extensions/feishu/src/post.test.ts expected objects without mediaKeys in locale-wrapper test cases.
Why it matters: parsePostContent now always returns mediaKeys, causing CI test failure.
What changed: Added mediaKeys: [] to both locale-wrapper expectations.
What did NOT change (scope boundary): No parser/runtime behavior changes; test-only update.

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

Closes #
Related #

User-visible / Behavior Changes

None.

Security Impact (required)

New permissions/capabilities? (No)
Secrets/tokens handling changed? (No)
New/changed network calls? (No)
Command/tool execution surface changed? (No)
Data access scope changed? (No)
If any Yes, explain risk + mitigation:

Repro + Verification

Environment

OS: macOS
Runtime/container: Node 22 + pnpm workspace
Model/provider: N/A
Integration/channel (if any): Feishu extension tests
Relevant config (redacted): default local test config

Steps

Run pnpm vitest extensions/feishu/src/post.test.ts before fix.
Observe locale-wrapper test failure due to unexpected mediaKeys field.
Apply expectation update and rerun the same command.

Expected

Test suite passes with parser output shape including mediaKeys.

Actual

After fix, all tests in extensions/feishu/src/post.test.ts pass.

Evidence

Failing test/log before + passing after
Trace/log snippets
Screenshot/recording
Perf numbers (if relevant)

Human Verification (required)

Verified scenarios: locale-wrapper expectations and full post.test.ts file run.
Edge cases checked: both wrapper styles (post.zh_cn and top-level zh_cn).
What you did not verify: full repository test suite.

Compatibility / Migration

Backward compatible? (Yes)
Config/env changes? (No)
Migration needed? (No)
If yes, exact upgrade steps:

Failure Recovery (if this breaks)

How to disable/revert this change quickly: revert this commit.
Files/config to restore: extensions/feishu/src/post.test.ts.
Known bad symptoms reviewers should watch for: none beyond this test regression.

Risks and Mitigations

Risk: Minimal; test expectation could hide an unintended API shape change.
- Mitigation: Change matches current parser contract used in other assertions.

greptile-apps · 2026-02-28T08:00:33Z

Greptile Summary

Fixed test expectations in extensions/feishu/src/post.test.ts to include mediaKeys: [] in locale wrapper assertions. When the mediaKeys field was added to parsePostContent() output in commit 53a2e72, the locale wrapper tests were not updated because they use .toEqual() for exact object matching.

Updated two test expectations on lines 95 and 101 to include mediaKeys: []
Aligns test expectations with the actual parser output type PostParseResult
Test-only change with no runtime behavior impact
Other tests unaffected as they check specific fields rather than full object equality

Confidence Score: 5/5

This PR is safe to merge with no risk
The change is minimal, correct, and test-only. It fixes a test regression by aligning expectations with the actual parser implementation, which already returns mediaKeys in its output type. No production code is modified.
No files require special attention

_{Last reviewed commit: 47eda14}

(cherry picked from commit 26a60fc)

Cherry-pick of upstream f810932.

(cherry picked from commit f810932)

…test fix (#1481) * feat(feishu): extract embedded video/media from post (rich text) messages (openclaw#21786) * feat(feishu): extract embedded video/media from post (rich text) messages Previously, parsePostContent() only extracted embedded images (img tags) from rich text posts, ignoring embedded video/audio (media tags). Users sending post messages with embedded videos would not have the media downloaded or forwarded to the agent. Changes: - Extend parsePostContent() to also collect media tags with file_key - Return new mediaKeys array alongside existing imageKeys - Update resolveFeishuMediaList() to download embedded media files from post messages using the messageResource API - Add appropriate logging for embedded media discovery and download * Feishu: keep embedded post media payloads type-safe * Feishu: format post parser after media tag extraction --------- Co-authored-by: laopuhuluwa <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit 53a2e72) * Feishu: fix locale-wrapper post parser test (openclaw#29576) (cherry picked from commit f810932) --------- Co-authored-by: laopuhuluwa <[email protected]> Co-authored-by: laopuhuluwa <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> Co-authored-by: Vincent Koc <[email protected]>

Feishu: fix locale-wrapper post parser test

47eda14

openclaw-barnacle bot added channel: feishu Channel integration: feishu size: XS maintainer Maintainer-authored PR labels Feb 28, 2026

vincentkoc marked this pull request as ready for review February 28, 2026 07:57

vincentkoc merged commit f810932 into openclaw:main Feb 28, 2026
24 checks passed

github-actions bot mentioned this pull request Feb 28, 2026

📡 Upstream Digest — 2026-02-28 08:19 UTC curtismercier/openclaw-mods#144

Open

stolyarchuk pushed a commit to llmxio/openclaw that referenced this pull request Feb 28, 2026

Feishu: fix locale-wrapper post parser test (openclaw#29576)

2853e22

r4jiv007 pushed a commit to r4jiv007/openclaw that referenced this pull request Feb 28, 2026

Feishu: fix locale-wrapper post parser test (openclaw#29576)

75d80c3

mylukin pushed a commit to mylukin/openclaw that referenced this pull request Feb 28, 2026

Feishu: fix locale-wrapper post parser test (openclaw#29576)

10b8b1a

wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Feb 28, 2026

Feishu: fix locale-wrapper post parser test (openclaw#29576)

26a60fc

wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Feb 28, 2026

Feishu: fix locale-wrapper post parser test (openclaw#29576)

8dbb6cd

(cherry picked from commit 26a60fc)

wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Feb 28, 2026

Feishu: fix locale-wrapper post parser test (openclaw#29576)

d628c28

(cherry picked from commit 26a60fc)

wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Feb 28, 2026

Feishu: fix locale-wrapper post parser test (openclaw#29576)

ee059e9

(cherry picked from commit 26a60fc)

ohmyskyhigh pushed a commit to ohmyskyhigh/openclaw that referenced this pull request Feb 28, 2026

Feishu: fix locale-wrapper post parser test (openclaw#29576)

8702eea

vincentkoc added a commit to Sid-Qin/openclaw that referenced this pull request Feb 28, 2026

Feishu: fix locale-wrapper post parser test (openclaw#29576)

efc62a1

vincentkoc added a commit to rylena/rylen-openclaw that referenced this pull request Feb 28, 2026

Feishu: fix locale-wrapper post parser test (openclaw#29576)

b04f80b

newtontech pushed a commit to newtontech/openclaw-fork that referenced this pull request Feb 28, 2026

Feishu: fix locale-wrapper post parser test (openclaw#29576)

d58e243

wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Mar 1, 2026

Feishu: fix locale-wrapper post parser test (openclaw#29576)

3bd983c

wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Mar 1, 2026

Feishu: fix locale-wrapper post parser test (openclaw#29576)

9fd4ba3

zooqueen added a commit to hanzoai/bot that referenced this pull request Mar 1, 2026

Feishu: fix locale-wrapper post parser test (openclaw#29576)

51e747d

Cherry-pick of upstream f810932.

ansh pushed a commit to vibecode/openclaw that referenced this pull request Mar 2, 2026

Feishu: fix locale-wrapper post parser test (openclaw#29576)

a86fa28

steipete pushed a commit to Sid-Qin/openclaw that referenced this pull request Mar 2, 2026

Feishu: fix locale-wrapper post parser test (openclaw#29576)

adcc196

This was referenced Mar 2, 2026

fix(test): flaky Windows-only failure in subagent-announce.format.test.ts #31298

Closed

fix(test): fix flaky Windows CI failure in subagent-announce.format.test #31299

Closed

safzanpirani pushed a commit to safzanpirani/clawdbot that referenced this pull request Mar 2, 2026

Feishu: fix locale-wrapper post parser test (openclaw#29576)

8d2fea9

steipete pushed a commit to Sid-Qin/openclaw that referenced this pull request Mar 2, 2026

Feishu: fix locale-wrapper post parser test (openclaw#29576)

e91e7de

robertchang-ga pushed a commit to robertchang-ga/openclaw that referenced this pull request Mar 2, 2026

Feishu: fix locale-wrapper post parser test (openclaw#29576)

6f8a697

execute008 pushed a commit to execute008/openclaw that referenced this pull request Mar 2, 2026

Feishu: fix locale-wrapper post parser test (openclaw#29576)

74908a0

dorgonman pushed a commit to kanohorizonia/openclaw that referenced this pull request Mar 3, 2026

Feishu: fix locale-wrapper post parser test (openclaw#29576)

8ba131c

sachinkundu pushed a commit to sachinkundu/openclaw that referenced this pull request Mar 6, 2026

Feishu: fix locale-wrapper post parser test (openclaw#29576)

07c7202

zooqueen added a commit to hanzoai/bot that referenced this pull request Mar 6, 2026

Feishu: fix locale-wrapper post parser test (openclaw#29576)

1698c1c

Cherry-pick of upstream f810932.

zooqueen pushed a commit to hanzoai/bot that referenced this pull request Mar 6, 2026

Feishu: fix locale-wrapper post parser test (openclaw#29576)

1b266fb

Mateljan1 pushed a commit to Mateljan1/openclaw that referenced this pull request Mar 7, 2026

Feishu: fix locale-wrapper post parser test (openclaw#29576)

b8ae8e5

alexey-pelykh mentioned this pull request Mar 10, 2026

Cherry-pick: Feishu adapter — community PRs and fixes remoteclaw/remoteclaw#678

Closed

alexey-pelykh pushed a commit to remoteclaw/remoteclaw that referenced this pull request Mar 16, 2026

Feishu: fix locale-wrapper post parser test (openclaw#29576)

8295d58

(cherry picked from commit f810932)

alexey-pelykh mentioned this pull request Mar 16, 2026

Cherry-pick f81093285: Feishu: fix locale-wrapper post parser test (#29576) remoteclaw/remoteclaw#1480

Closed

alexey-pelykh pushed a commit to remoteclaw/remoteclaw that referenced this pull request Mar 16, 2026

Feishu: fix locale-wrapper post parser test (openclaw#29576)

c59faf3

(cherry picked from commit f810932)

alexey-pelykh mentioned this pull request Mar 16, 2026

Cherry-pick 53a2e72fc+f81093285: feishu post video extraction + locale test fix remoteclaw/remoteclaw#1481

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feishu: fix locale-wrapper post parser test#29576

Feishu: fix locale-wrapper post parser test#29576
vincentkoc merged 1 commit intoopenclaw:mainfrom
vincentkoc:vincentkoc-code/fix-feishu-locale-test-mediakeys

vincentkoc commented Feb 28, 2026

Uh oh!

Uh oh!

greptile-apps bot commented Feb 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

vincentkoc commented Feb 28, 2026

Summary

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

User-visible / Behavior Changes

Security Impact (required)

Repro + Verification

Environment

Steps

Expected

Actual

Evidence

Human Verification (required)

Compatibility / Migration

Failure Recovery (if this breaks)

Risks and Mitigations

Uh oh!

Uh oh!

greptile-apps bot commented Feb 28, 2026

Greptile Summary

Confidence Score: 5/5

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant