Skip to content

fix(android): add missing capability setup surfaces#29502

Merged
obviyus merged 2 commits into
mainfrom
fix/android-capability-settings-onboarding-drift
Feb 28, 2026
Merged

fix(android): add missing capability setup surfaces#29502
obviyus merged 2 commits into
mainfrom
fix/android-capability-settings-onboarding-drift

Conversation

@obviyus

@obviyus obviyus commented Feb 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add missing Android onboarding/setup controls for newly added node capabilities (notifications listener, app updates, photos, contacts, calendar, motion, location)
  • add matching Settings sections and system-intent entry points for those permissions/access toggles
  • fix Android capability advertisement drift by adding notifications, system, and appUpdate capabilities to the shared protocol + registry manifest
  • extend capability parity tests to lock this behavior

Validation

  • ./gradlew :app:compileDebugKotlin
  • ./gradlew :app:testDebugUnitTest --tests 'ai.openclaw.android.node.InvokeCommandRegistryTest' --tests 'ai.openclaw.android.protocol.OpenClawProtocolConstantsTest'

@openclaw-barnacle openclaw-barnacle Bot added app: android App: android size: L maintainer Maintainer-authored PR labels Feb 28, 2026
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Feb 28, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4e74cbe59e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/android/app/src/main/java/ai/openclaw/android/ui/OnboardingFlow.kt Outdated
@greptile-apps

greptile-apps Bot commented Feb 28, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Added comprehensive Android onboarding and settings UI for newly implemented node capabilities (notifications, system, appUpdate), along with existing capabilities that were missing setup controls (photos, contacts, calendar, motion, location).

Key changes:

  • Added Notifications, System, and AppUpdate capabilities to the protocol constants and capability registry, fixing capability advertisement drift
  • Extended onboarding flow with permission toggles and system settings navigation for all supported capabilities
  • Added matching Settings sections with permission launchers and lifecycle-aware state refresh
  • Implemented proper Android API level handling (different permissions for SDK 33+, motion sensors for SDK 29+)
  • Added capability parity tests to prevent future drift

All changes follow Android permission best practices with proper fallbacks and error handling.

Confidence Score: 5/5

  • Safe to merge - comprehensive capability additions with proper testing and Android permission handling
  • All changes are well-structured with appropriate test coverage. The code handles different Android API levels correctly, includes proper error fallbacks, and follows Android permission best practices. No critical issues found.
  • No files require special attention

Last reviewed commit: 4e74cbe

@obviyus
obviyus merged commit 3f056a7 into main Feb 28, 2026
23 checks passed
@obviyus
obviyus deleted the fix/android-capability-settings-onboarding-drift branch February 28, 2026 06:59
@obviyus

obviyus commented Feb 28, 2026

Copy link
Copy Markdown
Contributor Author

Landed via temp rebase onto main.

  • Gate: skipped per author instruction
  • Land commit: b0e490c
  • Merge commit: 3f056a7

@obviyus obviyus self-assigned this Mar 23, 2026
@clawsweeper clawsweeper Bot mentioned this pull request Jul 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

Assignees

@obviyus obviyus

Labels

app: android App: android maintainer Maintainer-authored PR size: L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@obviyus