fix(feishu): add reactionNotifications mode gating by Takhoffman · Pull Request #29388 · openclaw/openclaw

Takhoffman · 2026-02-28T03:32:32Z

Summary

add channels.feishu.reactionNotifications config (off | own | all) with default own
gate reaction synthetic-event dispatch in monitor.ts by that mode
add focused reaction-mode regression tests
update changelog

Why

preserves current secure default behavior (own)
allows operators to disable reaction ingress (off) or opt into all verified reactions (all)
replaces the stale/superseded overlap from feat(feishu): listen for reaction events and dispatch to agent #28529 with a minimal forward-only patch

Verification

pnpm test extensions/feishu/src/monitor.reaction.test.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3b21068775

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-28T03:36:07Z

extensions/feishu/src/monitor.ts

  }

+  const account = resolveFeishuAccount({ cfg, accountId });
+  const reactionNotifications = account.config.reactionNotifications ?? "own";


Fail closed for unknown reaction notification modes

Treating account.config.reactionNotifications as-is means any unexpected value (for example a typo like "onw") bypasses the "own" checks and is effectively handled as "all", because only "off" and "own" are gated later in this function. Since extension channel configs are accepted via passthrough in src/config/zod-schema.providers.ts, this malformed input is reachable and can unintentionally widen reaction ingress to non-bot messages; the mode should be normalized to the known enum and default to "own" on unknown values.

Useful? React with 👍 / 👎.

greptile-apps · 2026-02-28T03:37:14Z

Greptile Summary

Added configuration option channels.feishu.reactionNotifications with three modes (off, own, all) to control reaction event processing. The default own mode preserves existing secure behavior (only bot-authored message reactions), while off disables reaction ingress entirely and all allows all verified reactions.

Key changes:

Config schema properly defines the new option with appropriate defaults
monitor.ts gates reaction processing based on the selected mode
Maintains backward compatibility with secure-by-default own mode
Focused regression tests cover all three modes
Message verification still occurs in all non-off modes for security

Minor observations:

Changelog entry references feat(feishu): listen for reaction events and dispatch to agent #28529 rather than this PR fix(feishu): add reactionNotifications mode gating #29388 (may be intentional if feat(feishu): listen for reaction events and dispatch to agent #28529 is the original issue)
Test coverage could include edge case of all mode without botOpenId, though implementation handles it correctly

Confidence Score: 5/5

This PR is safe to merge with no security or correctness concerns
Clean implementation with proper security defaults, comprehensive test coverage for main scenarios, and maintains backward compatibility. The default own mode preserves existing secure behavior while new modes are opt-in. All reaction events still undergo message verification.
No files require special attention

_{Last reviewed commit: 3b21068}

Takhoffman · 2026-02-28T03:47:25Z

PR #29388 - fix(feishu): add reactionNotifications mode gating (#29388)

Merged via squash.

Merge commit: aef5355
Verified: pnpm build, pnpm check, pnpm test:macmini
Changelog: CHANGELOG.md updated=true required=true opt_out=false

Thanks @Takhoffman!

nikolasdehor

Clean implementation with secure defaults. The three-mode approach (off/own/all) gives operators good control without breaking existing behavior. One minor observation: when reactionNotifications is 'all' and botOpenId is unavailable, the guard is bypassed (correct — operator opted in). But a debug-level log for this case would help operators understand why reactions are processed without bot identity verification. Not a blocker. LGTM.

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit da8f870)

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit da8f870)

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit da8f870)

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit aef5355) # Conflicts: # CHANGELOG.md # extensions/feishu/src/config-schema.ts

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit aef5355) # Conflicts: # CHANGELOG.md # extensions/feishu/src/config-schema.ts

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit aef5355)

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit aef5355)

@Takhoffman

…hanks @Takhoffman (#1463) Verified: - pnpm build - pnpm check - pnpm test:macmini (cherry picked from commit aef5355) Co-authored-by: Tak Hoffman <[email protected]>

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit aef5355)

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit aef5355)

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit aef5355)

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit aef5355)

@Takhoffman

…hanks @Takhoffman Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Takhoffman <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit aef5355)

feishu: add reaction notification mode config gate

3b21068

openclaw-barnacle bot added channel: feishu Channel integration: feishu size: S maintainer Maintainer-authored PR labels Feb 28, 2026

chatgpt-codex-connector bot reviewed Feb 28, 2026

View reviewed changes

Takhoffman merged commit aef5355 into main Feb 28, 2026
31 checks passed

Takhoffman deleted the feat/feishu-reaction-notification-mode branch February 28, 2026 03:47

nikolasdehor approved these changes Feb 28, 2026

View reviewed changes

github-actions bot mentioned this pull request Mar 1, 2026

cherry-pick: upstream docs commits (2026-03-01-0443) hughdidit/DAISy-Agency#141

Closed

6 tasks

alexey-pelykh mentioned this pull request Mar 10, 2026

Cherry-pick: Feishu adapter — community PRs and fixes remoteclaw/remoteclaw#678

Closed

alexey-pelykh mentioned this pull request Mar 15, 2026

Cherry-pick aef535510: fix(feishu): add reactionNotifications mode gating remoteclaw/remoteclaw#1463

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(feishu): add reactionNotifications mode gating#29388

fix(feishu): add reactionNotifications mode gating#29388
Takhoffman merged 1 commit intomainfrom
feat/feishu-reaction-notification-mode

Takhoffman commented Feb 28, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Feb 28, 2026

Uh oh!

greptile-apps bot commented Feb 28, 2026

Uh oh!

Uh oh!

Takhoffman commented Feb 28, 2026

Uh oh!

nikolasdehor left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Takhoffman commented Feb 28, 2026

Summary

Why

Verification

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot commented Feb 28, 2026

Greptile Summary

Confidence Score: 5/5

Uh oh!

Uh oh!

Takhoffman commented Feb 28, 2026

Uh oh!

nikolasdehor left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants