fix(discord): prevent thread-bound ACP loop on bot system messages by stakeswky · Pull Request #29358 · openclaw/openclaw

stakeswky · 2026-02-28T02:52:29Z

Summary

filter bot-authored system messages (⚙️/🤖 prefixes) in Discord preflight for bound thread sessions
keep regular bot messages in bound threads flowing when allowBots=true
add regression tests for loop prevention and non-regression behavior

Root cause

In thread-bound ACP flows, bot-authored status/system messages posted into the thread could pass preflight when allowBots=true and be routed as inbound turns to the bound ACP session. That allowed ACP/system status text to be interpreted as user prompts and loop.

Fix

add isBoundThreadBotSystemMessage(...) in src/discord/monitor/message-handler.preflight.ts
apply it after binding resolution, before mention/command gating
drop only when all are true:
- message is in a bound thread session
- author is a bot
- content starts with known system prefixes (⚙️, 🤖)

Tests

pnpm -s vitest src/discord/monitor/message-handler.preflight.test.ts
new tests:
- drops bound-thread bot system message (regression)
- keeps regular bot message allowed in bound thread (non-regression)

Fixes #29325

…o changes When running `openclaw doctor --fix` and no config changes are needed, the else branch unconditionally showed "Run doctor --fix to apply changes" which is confusing since we just ran --fix. Now the hint only appears when NOT in fix mode (i.e. when running plain `openclaw doctor`). When in fix mode with nothing to change, the command silently proceeds to the "Doctor complete." outro. Fixes openclaw#24566

greptile-apps · 2026-02-28T02:56:22Z

Greptile Summary

Prevented Discord bot system messages from looping back as user prompts in thread-bound ACP sessions by filtering messages with ⚙️ or 🤖 prefixes when authored by bots. The fix correctly identifies system messages while preserving regular bot message flow when allowBots=true.

Key Changes:

Added isBoundThreadBotSystemMessage() helper that checks for bot-authored system messages in bound threads
Applied filtering after binding resolution but before mention/command gating to catch messages early
Comprehensive regression tests verify both the fix (system messages dropped) and non-regression (regular bot messages flow through)
Additional fixes included: exec allowlist wildcard support (*/** patterns) and suppressed duplicate doctor hint when already in fix mode

Code Quality:

Clean implementation with proper edge case handling (empty text, whitespace trimming)
Variable reuse (isBoundThreadSession) eliminates redundant computation
All changes follow TypeScript best practices with strict typing

Confidence Score: 5/5

This PR is safe to merge with no identified risks
All changes are straightforward bug fixes with comprehensive test coverage. The Discord fix addresses a clear logic issue (bot system messages looping as user input) with a targeted solution that only affects the specific edge case. Tests verify both positive (filtering system messages) and negative (preserving regular bot messages) scenarios. The additional fixes (wildcard support, doctor hint) are minimal and well-contained
No files require special attention

_{Last reviewed commit: 540d2dd}

yoshikouki

Review: Tested locally — this fix addresses the root cause ✅

Reproduction

We reproduced the loop on our setup (allowBots: true, thread-bound ACP with Codex --full-auto):

Spawn ACP session with thread: true, mode: "session"
Codex completes task (e.g. bun test → 110 pass)
⚙️ codex session active posted to thread by webhook
Codex receives it as a prompt → responds "セッション有効を確認しました"
⚙️ usage_update → Codex investigates usage via sqlite3 → more tool calls → more usage_updates → loop
Thread reached 90+ messages before gateway restart killed the loop

The loop origin is always an ⚙️-prefixed system message. Dropping these at preflight breaks the cycle before any downstream messages (🧰, plain-text responses) can be generated. This fix should resolve it.

Suggestion: add `🧰` to prefixes for defense-in-depth

The current prefix list is:

const DISCORD_BOUND_THREAD_SYSTEM_PREFIXES = ["⚙️", "🤖"];

🧰 (tool_call summaries like 🧰 call_xxx (completed)) can also appear as bot messages in bound threads. While they shouldn't trigger loops on their own (they're generated by the loop, not causing it), adding 🧰 would provide an extra safety layer:

const DISCORD_BOUND_THREAD_SYSTEM_PREFIXES = ["⚙️", "🤖", "🧰"];

Key finding from reproduction

coalesceIdleMs (350ms vs 10000ms) does not prevent the loop — it only masks it by delaying Discord posts
The loop survives gateway restarts if the ACP session is persistent (mode: "session") — restart kills the OpenClaw-side routing but the Codex process may still be alive
shouldIgnoreBoundThreadWebhookMessage (existing filter) works for webhook echo prevention, but doesn't catch the case where the same webhook's ⚙️ messages pass through allowBots: true

Great fix, fast turnaround 🙏

stakeswky · 2026-02-28T05:41:36Z

@yoshikouki 已按建议补上 defense-in-depth：在 bound thread bot system message 前缀列表中加入，现在为。\n\n已提交并推送到同一分支：。感谢详细复现与建议 🙏

stakeswky · 2026-02-28T05:41:45Z

@yoshikouki 已按建议补上 defense-in-depth：在 bound thread bot system message 前缀列表中加入 🧰，现在为 ["⚙️", "🤖", "🧰"]。

已提交并推送到同一分支：22d97904d。感谢详细复现与建议 🙏

stakeswky · 2026-03-03T07:54:04Z

Thanks for the thorough repro and review 🙏\n\nGood call on defense-in-depth with . That prefix is already included in the current branch:\n\n\n\nSo no further code change is needed for this PR on that point.

stakeswky · 2026-03-03T07:54:16Z

Correction to my previous comment (formatting issue on my side):

Thanks for the thorough repro and review 🙏

Good call on defense-in-depth with 🧰. That prefix is already included in the current branch:

const DISCORD_BOUND_THREAD_SYSTEM_PREFIXES = ["⚙️", "🤖", "🧰"];

So no further code change is needed for this PR on that point.

stakeswky · 2026-03-03T08:57:00Z

@yoshikouki 感谢详细复现与建议！已按你提的 defense-in-depth 建议补上 🧰 前缀过滤（当前前缀集合为 ⚙️/🤖/🧰），用于进一步降低 thread-bound ACP 回环风险。

也确认了你的结论：coalesceIdleMs 只能延后暴露，不是根因修复；真正关键是 preflight 层在 allowBots 场景下尽早丢弃系统消息。感谢高质量验证 🙏

thewilloftheshadow · 2026-03-03T15:01:38Z

Superseded by #33136, which consolidates the /acp inline action autocomplete fix plus the bound-thread bot system message guard. Closing in favor of that PR.

User added 3 commits February 24, 2026 01:40

fix: support '*' exec allowlist wildcard (openclaw#25082)

5b44d80

fix(discord): ignore bound-thread bot system messages in preflight

540d2dd

openclaw-barnacle bot added channel: discord Channel integration: discord commands Command implementations size: M trusted-contributor labels Feb 28, 2026

yoshikouki reviewed Feb 28, 2026

View reviewed changes

fix(discord): include tool-summary prefix in bound-thread filter

22d9790

thewilloftheshadow mentioned this pull request Mar 3, 2026

fix(discord): accept /acp inline action + ignore bound-thread system messages #33136

Merged

18 tasks

thewilloftheshadow closed this Mar 3, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(discord): prevent thread-bound ACP loop on bot system messages#29358

fix(discord): prevent thread-bound ACP loop on bot system messages#29358
stakeswky wants to merge 4 commits intoopenclaw:mainfrom
stakeswky:bugfix/discord-acp-system-msg-loop-29325

stakeswky commented Feb 28, 2026

Uh oh!

greptile-apps bot commented Feb 28, 2026

Uh oh!

yoshikouki left a comment

Uh oh!

stakeswky commented Feb 28, 2026

Uh oh!

stakeswky commented Feb 28, 2026

Uh oh!

stakeswky commented Mar 3, 2026

Uh oh!

stakeswky commented Mar 3, 2026

Uh oh!

stakeswky commented Mar 3, 2026 •

edited

Loading

Uh oh!

thewilloftheshadow commented Mar 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

stakeswky commented Feb 28, 2026

Summary

Root cause

Fix

Tests

Uh oh!

greptile-apps bot commented Feb 28, 2026

Greptile Summary

Confidence Score: 5/5

Uh oh!

yoshikouki left a comment

Choose a reason for hiding this comment

Review: Tested locally — this fix addresses the root cause ✅

Reproduction

Suggestion: add 🧰 to prefixes for defense-in-depth

Key finding from reproduction

Uh oh!

stakeswky commented Feb 28, 2026

Uh oh!

stakeswky commented Feb 28, 2026

Uh oh!

stakeswky commented Mar 3, 2026

Uh oh!

stakeswky commented Mar 3, 2026

Uh oh!

stakeswky commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thewilloftheshadow commented Mar 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Suggestion: add `🧰` to prefixes for defense-in-depth

stakeswky commented Mar 3, 2026 •

edited

Loading