Skip to content

fix(model): preserve reasoning in provider fallback resolution#29285

Merged
vincentkoc merged 2 commits intoopenclaw:mainfrom
vincentkoc:vincentkoc-code/fix-ollama-fallback-reasoning
Feb 28, 2026
Merged

fix(model): preserve reasoning in provider fallback resolution#29285
vincentkoc merged 2 commits intoopenclaw:mainfrom
vincentkoc:vincentkoc-code/fix-ollama-fallback-reasoning

Conversation

@vincentkoc
Copy link
Copy Markdown
Member

@vincentkoc vincentkoc commented Feb 28, 2026

Summary

  • Problem: provider fallback in resolveModel() still hardcoded reasoning: false even when a matching configured provider model has reasoning: true.
  • Why it matters: reasoning-capable models lose reasoning effort propagation in fallback paths.
  • What changed:
    • use configuredModel?.reasoning ?? false in provider fallback model construction.
    • add regression test proving matched fallback model propagates reasoning: true.
  • Scope boundary:

Linked Issue/PR

Verification

  • pnpm vitest run src/agents/pi-embedded-runner/model.test.ts
  • pnpm tsgo

@openclaw-barnacle openclaw-barnacle bot added agents Agent runtime and tooling size: XS maintainer Maintainer-authored PR labels Feb 28, 2026
@vincentkoc vincentkoc marked this pull request as ready for review February 28, 2026 01:34
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 28, 2026

Greptile Summary

Fixed provider fallback to preserve reasoning: true from configured models instead of hardcoding to false.

  • Changed src/agents/pi-embedded-runner/model.ts:106 to use configuredModel?.reasoning ?? false instead of hardcoded reasoning: false
  • This ensures reasoning-capable models maintain their reasoning capability when resolved through the provider fallback path
  • Follows the existing pattern used for contextWindow and maxTokens fields
  • Added regression test proving matched fallback models properly propagate reasoning: true

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Single-line fix that aligns with existing code patterns, well-tested with new regression test, addresses a specific bug without introducing new complexity or edge cases
  • No files require special attention

Last reviewed commit: 79b4ebd

@vincentkoc vincentkoc merged commit 50aa6a4 into openclaw:main Feb 28, 2026
30 checks passed
@vincentkoc vincentkoc mentioned this pull request Feb 28, 2026
Closed
18 tasks
@github-actions github-actions bot mentioned this pull request Feb 28, 2026
Open
vincentkoc added a commit that referenced this pull request Feb 28, 2026
@vincentkoc
Changelog: add model fallback reasoning fix (#29285)
7968c0f
@github-actions github-actions bot mentioned this pull request Feb 28, 2026
Open
stolyarchuk pushed a commit to llmxio/openclaw that referenced this pull request Feb 28, 2026
@vincentkoc @stolyarchuk
Changelog: add model fallback reasoning fix (openclaw#29285)
69ae0c9
r4jiv007 pushed a commit to r4jiv007/openclaw that referenced this pull request Feb 28, 2026
@vincentkoc @r4jiv007
fix(model): preserve reasoning in provider fallback resolution (openc…
f27a193 
…law#29285)

* fix(model): preserve reasoning in provider fallback resolution

* test(model): cover fallback reasoning propagation
r4jiv007 pushed a commit to r4jiv007/openclaw that referenced this pull request Feb 28, 2026
@vincentkoc @r4jiv007
Changelog: add model fallback reasoning fix (openclaw#29285)
ea97dbc
xiexikang pushed a commit to C-clawd/cclawd that referenced this pull request Feb 28, 2026
@vincentkoc
fix(model): preserve reasoning in provider fallback resolution (openc…
2aea558 
…law#29285)

* fix(model): preserve reasoning in provider fallback resolution

* test(model): cover fallback reasoning propagation
mylukin pushed a commit to mylukin/openclaw that referenced this pull request Feb 28, 2026
@vincentkoc @mylukin
fix(model): preserve reasoning in provider fallback resolution (openc…
fcf4b6f 
…law#29285)

* fix(model): preserve reasoning in provider fallback resolution

* test(model): cover fallback reasoning propagation
mylukin pushed a commit to mylukin/openclaw that referenced this pull request Feb 28, 2026
@vincentkoc @mylukin
Changelog: add model fallback reasoning fix (openclaw#29285)
c90bf73
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Feb 28, 2026
@vincentkoc @wanjizheng
fix(model): preserve reasoning in provider fallback resolution (openc…
8fc2b38 
…law#29285)

* fix(model): preserve reasoning in provider fallback resolution

* test(model): cover fallback reasoning propagation
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Feb 28, 2026
@vincentkoc @wanjizheng
Changelog: add model fallback reasoning fix (openclaw#29285)
2af92c0
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Feb 28, 2026
@vincentkoc @wanjizheng
fix(model): preserve reasoning in provider fallback resolution (openc…
00e313e 
…law#29285)

* fix(model): preserve reasoning in provider fallback resolution

* test(model): cover fallback reasoning propagation

(cherry picked from commit 8fc2b38)
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Feb 28, 2026
@vincentkoc @wanjizheng
Changelog: add model fallback reasoning fix (openclaw#29285)
dd7e0ee 
(cherry picked from commit 2af92c0)
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Feb 28, 2026
@vincentkoc @wanjizheng
fix(model): preserve reasoning in provider fallback resolution (openc…
c863315 
…law#29285)

* fix(model): preserve reasoning in provider fallback resolution

* test(model): cover fallback reasoning propagation

(cherry picked from commit 8fc2b38)
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Feb 28, 2026
@vincentkoc @wanjizheng
Changelog: add model fallback reasoning fix (openclaw#29285)
513d652 
(cherry picked from commit 2af92c0)
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Feb 28, 2026
@vincentkoc @wanjizheng
fix(model): preserve reasoning in provider fallback resolution (openc…
984fd00 
…law#29285)

* fix(model): preserve reasoning in provider fallback resolution

* test(model): cover fallback reasoning propagation

(cherry picked from commit 8fc2b38)
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Feb 28, 2026
@vincentkoc @wanjizheng
Changelog: add model fallback reasoning fix (openclaw#29285)
3c0ba56 
(cherry picked from commit 2af92c0)
ohmyskyhigh pushed a commit to ohmyskyhigh/openclaw that referenced this pull request Feb 28, 2026
@vincentkoc @ohmyskyhigh
Changelog: add model fallback reasoning fix (openclaw#29285)
5e18d2c
vincentkoc added a commit to Sid-Qin/openclaw that referenced this pull request Feb 28, 2026
@vincentkoc
fix(model): preserve reasoning in provider fallback resolution (openc…
b94377e 
…law#29285)

* fix(model): preserve reasoning in provider fallback resolution

* test(model): cover fallback reasoning propagation
vincentkoc added a commit to Sid-Qin/openclaw that referenced this pull request Feb 28, 2026
@vincentkoc
Changelog: add model fallback reasoning fix (openclaw#29285)
bfee6c9
vincentkoc added a commit to rylena/rylen-openclaw that referenced this pull request Feb 28, 2026
@vincentkoc
fix(model): preserve reasoning in provider fallback resolution (openc…
2ebbded 
…law#29285)

* fix(model): preserve reasoning in provider fallback resolution

* test(model): cover fallback reasoning propagation
vincentkoc added a commit to rylena/rylen-openclaw that referenced this pull request Feb 28, 2026
@vincentkoc
Changelog: add model fallback reasoning fix (openclaw#29285)
e6f147e
newtontech pushed a commit to newtontech/openclaw-fork that referenced this pull request Feb 28, 2026
@vincentkoc
fix(model): preserve reasoning in provider fallback resolution (openc…
55f5c97 
…law#29285)

* fix(model): preserve reasoning in provider fallback resolution

* test(model): cover fallback reasoning propagation
newtontech pushed a commit to newtontech/openclaw-fork that referenced this pull request Feb 28, 2026
@vincentkoc
Changelog: add model fallback reasoning fix (openclaw#29285)
3f35f21
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Mar 1, 2026
@vincentkoc @wanjizheng
fix(model): preserve reasoning in provider fallback resolution (openc…
26cca99 
…law#29285)

* fix(model): preserve reasoning in provider fallback resolution

* test(model): cover fallback reasoning propagation
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Mar 1, 2026
@vincentkoc @wanjizheng
Changelog: add model fallback reasoning fix (openclaw#29285)
c062980
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Mar 1, 2026
@vincentkoc @wanjizheng
fix(model): preserve reasoning in provider fallback resolution (openc…
cca4c96 
…law#29285)

* fix(model): preserve reasoning in provider fallback resolution

* test(model): cover fallback reasoning propagation
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Mar 1, 2026
@vincentkoc @wanjizheng
Changelog: add model fallback reasoning fix (openclaw#29285)
3ce0eb2
@github-actions github-actions bot mentioned this pull request Mar 1, 2026
Closed
6 tasks
hughdidit pushed a commit to hughdidit/DAISy-Agency that referenced this pull request Mar 1, 2026
@vincentkoc @github-actions
Changelog: add model fallback reasoning fix (openclaw#29285)
8ecd327 
(cherry picked from commit 7968c0f)
@gemini-code-assist gemini-code-assist bot mentioned this pull request Mar 1, 2026
Merged
ansh pushed a commit to vibecode/openclaw that referenced this pull request Mar 2, 2026
@vincentkoc @ansh
fix(model): preserve reasoning in provider fallback resolution (openc…
bbb26ec 
…law#29285)

* fix(model): preserve reasoning in provider fallback resolution

* test(model): cover fallback reasoning propagation
ansh pushed a commit to vibecode/openclaw that referenced this pull request Mar 2, 2026
@vincentkoc @ansh
Changelog: add model fallback reasoning fix (openclaw#29285)
6c07cfb
steipete pushed a commit to Sid-Qin/openclaw that referenced this pull request Mar 2, 2026
@vincentkoc @steipete
fix(model): preserve reasoning in provider fallback resolution (openc…
b33e006 
…law#29285)

* fix(model): preserve reasoning in provider fallback resolution

* test(model): cover fallback reasoning propagation
steipete pushed a commit to Sid-Qin/openclaw that referenced this pull request Mar 2, 2026
@vincentkoc @steipete
Changelog: add model fallback reasoning fix (openclaw#29285)
f29cf3c
safzanpirani pushed a commit to safzanpirani/clawdbot that referenced this pull request Mar 2, 2026
@vincentkoc @safzanpirani
fix(model): preserve reasoning in provider fallback resolution (openc…
3c13d59 
…law#29285)

* fix(model): preserve reasoning in provider fallback resolution

* test(model): cover fallback reasoning propagation
safzanpirani pushed a commit to safzanpirani/clawdbot that referenced this pull request Mar 2, 2026
@vincentkoc @safzanpirani
Changelog: add model fallback reasoning fix (openclaw#29285)
cfd23c3
steipete pushed a commit to Sid-Qin/openclaw that referenced this pull request Mar 2, 2026
@vincentkoc @steipete
fix(model): preserve reasoning in provider fallback resolution (openc…
79cc595 
…law#29285)

* fix(model): preserve reasoning in provider fallback resolution

* test(model): cover fallback reasoning propagation
steipete pushed a commit to Sid-Qin/openclaw that referenced this pull request Mar 2, 2026
@vincentkoc @steipete
Changelog: add model fallback reasoning fix (openclaw#29285)
da33197
venjiang pushed a commit to venjiang/openclaw that referenced this pull request Mar 2, 2026
@vincentkoc @venjiang
fix(model): preserve reasoning in provider fallback resolution (openc…
66af3ff 
…law#29285)

* fix(model): preserve reasoning in provider fallback resolution

* test(model): cover fallback reasoning propagation
robertchang-ga pushed a commit to robertchang-ga/openclaw that referenced this pull request Mar 2, 2026
@vincentkoc
Changelog: add model fallback reasoning fix (openclaw#29285)
312449c
execute008 pushed a commit to execute008/openclaw that referenced this pull request Mar 2, 2026
@vincentkoc @execute008
fix(model): preserve reasoning in provider fallback resolution (openc…
186ee3b 
…law#29285)

* fix(model): preserve reasoning in provider fallback resolution

* test(model): cover fallback reasoning propagation
execute008 pushed a commit to execute008/openclaw that referenced this pull request Mar 2, 2026
@vincentkoc @execute008
Changelog: add model fallback reasoning fix (openclaw#29285)
0385a0a
hughdidit pushed a commit to hughdidit/DAISy-Agency that referenced this pull request Mar 3, 2026
@vincentkoc @github-actions
Changelog: add model fallback reasoning fix (openclaw#29285)
f72f367 
(cherry picked from commit 7968c0f)
dorgonman pushed a commit to kanohorizonia/openclaw that referenced this pull request Mar 3, 2026
@vincentkoc @dorgonman
fix(model): preserve reasoning in provider fallback resolution (openc…
26278ef 
…law#29285)

* fix(model): preserve reasoning in provider fallback resolution

* test(model): cover fallback reasoning propagation
dorgonman pushed a commit to kanohorizonia/openclaw that referenced this pull request Mar 3, 2026
@vincentkoc @dorgonman
Changelog: add model fallback reasoning fix (openclaw#29285)
698d2f3
sachinkundu pushed a commit to sachinkundu/openclaw that referenced this pull request Mar 6, 2026
@vincentkoc
fix(model): preserve reasoning in provider fallback resolution (openc…
4bb1c14 
…law#29285)

* fix(model): preserve reasoning in provider fallback resolution

* test(model): cover fallback reasoning propagation
sachinkundu pushed a commit to sachinkundu/openclaw that referenced this pull request Mar 6, 2026
@vincentkoc
Changelog: add model fallback reasoning fix (openclaw#29285)
7b89a0d
zooqueen pushed a commit to hanzoai/bot that referenced this pull request Mar 6, 2026
@vincentkoc
fix(model): preserve reasoning in provider fallback resolution (openc…
ea664e4 
…law#29285)

* fix(model): preserve reasoning in provider fallback resolution

* test(model): cover fallback reasoning propagation
zooqueen pushed a commit to hanzoai/bot that referenced this pull request Mar 6, 2026
@vincentkoc
Changelog: add model fallback reasoning fix (openclaw#29285)
d96c5a5
Mateljan1 pushed a commit to Mateljan1/openclaw that referenced this pull request Mar 7, 2026
@vincentkoc @Mateljan1
Changelog: add model fallback reasoning fix (openclaw#29285)
bee32ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

agents Agent runtime and tooling maintainer Maintainer-authored PR size: XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Model fallback ignores reasoning and uses wrong contextWindow/maxTokens

1 participant

@vincentkoc