fix(feishu): auto-convert local image path text to image message in outbound by paceyw · Pull Request #29264 · openclaw/openclaw

paceyw · 2026-02-28T01:15:06Z

Problem

When upstream agent output accidentally contains a local image path string, Feishu outbound sendText sends it as plain text, so users see a local file path instead of an image.

Root Cause

No compatibility conversion exists in Feishu outbound text path. Only sendMedia path handles upload + image send.

Fix (Scheme A)

In extensions/feishu/src/outbound.ts:

Add normalizePossibleLocalImagePath(text) guard
In sendText, detect path-like local image payload and route to sendMediaFeishu
Keep fallback to original sendMessageFeishu on failure

Why this approach

Minimal and safe hotfix scope
Immediate mitigation without upstream protocol migration
Preserves backward compatibility

Validation checklist

Plain text messages unchanged
Local absolute image path routes to image send path
Non-image/local-invalid paths remain text
Upload failure falls back to text without blocking delivery

Notes

This addresses runtime behavior where local file path text could leak to Feishu chat. It does not replace long-term protocol governance (structured image output), which can be handled in a follow-up.

greptile-apps · 2026-02-28T01:18:33Z

Greptile Summary

Adds auto-detection of local image paths in text messages and routes them to image upload instead of sending as plain text.

Implemented normalizePossibleLocalImagePath() helper with validation for absolute paths, image extensions, and file existence
Modified sendText to detect local image paths and route to sendMediaFeishu, with graceful fallback to text on failure
Found one race condition bug between file existence check and stat call that could throw uncaught errors

Confidence Score: 3/5

Safe to merge after fixing the race condition error handling issue
The implementation approach is sound and includes proper fallback handling, but there's a logic bug where fs.statSync can throw an uncaught error if the file is deleted or becomes inaccessible between the existsSync and statSync calls. Once this error handling is fixed, the change should be safe to merge.
extensions/feishu/src/outbound.ts needs the race condition fix before merging

_{Last reviewed commit: b18cf02}

greptile-apps

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-28T01:18:37Z

extensions/feishu/src/outbound.ts

+  if (!fs.existsSync(raw)) return null;
+  if (!fs.statSync(raw).isFile()) return null;


Race condition: if file is deleted between existsSync and statSync, this will throw an uncaught error.

Suggested change

if (!fs.existsSync(raw)) return null;

if (!fs.statSync(raw).isFile()) return null;

try {

const stats = fs.statSync(raw);

if (!stats.isFile()) return null;

} catch {

return null;

}

Prompt To Fix With AI

This is a comment left during a code review. Path: extensions/feishu/src/outbound.ts Line: 25-26 Comment: Race condition: if file is deleted between `existsSync` and `statSync`, this will throw an uncaught error. ```suggestion try { const stats = fs.statSync(raw); if (!stats.isFile()) return null; } catch { return null; } ``` How can I resolve this? If you propose a fix, please make it concise.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b18cf02223

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-28T01:19:28Z

extensions/feishu/src/outbound.ts

+  const hasWhitespace = /\s/.test(raw);
+  if (hasWhitespace) return null;


Handle local image paths that contain spaces

The new auto-conversion path exits early on any whitespace, so valid local image paths like /Users/.../My File.png are never converted and still leak as plain text. This is a real behavior gap because the codebase already treats space-containing absolute paths as valid media inputs (e.g., src/media/parse.test.ts covers /Users/pete/My File.png), so common screenshot-style filenames won’t benefit from this hotfix.

Useful? React with 👍 / 👎.

…ound

- Add try-catch around fs.statSync to handle file deletion between existsSync and statSync - Fix oxfmt formatting issues

Takhoffman · 2026-02-28T03:29:24Z

PR #29264 - fix(feishu): auto-convert local image path text to image message in outbound (#29264)

Merged via squash.

Merge commit: 0e4c24e
Verified: pnpm build, pnpm check, pnpm test:macmini
Changes made:
A\textensions/feishu/src/outbound.test.ts
Why these changes were made:
The PR introduced local-image auto-conversion in Feishu outbound text send path without regression coverage, so tests were added to cover conversion, non-conversion, and fallback behavior.
Changelog: CHANGELOG.md updated=true required=true opt_out=false

Thanks @paceyw!

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 14cad1e14a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-28T03:32:00Z

extensions/feishu/src/outbound.ts

+          mediaUrl: localImagePath,
+          accountId: accountId ?? undefined,
+        });


Forward mediaLocalRoots in sendText auto-conversion

The new sendText auto-conversion path calls sendMediaFeishu without forwarding mediaLocalRoots, unlike the normal sendMedia branch. In contexts where outbound delivery provides scoped roots (for example agent workspace files), loadWebMedia will evaluate the path against default roots and reject common workspace-* paths, causing this conversion to fail and fall back to sending the raw file path text. That means the hotfix silently does not work for trusted local image paths produced in scoped workspaces.

Useful? React with 👍 / 👎.

@paceyw

…utbound (openclaw#29264) thanks @paceyw Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: paceyw <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@paceyw

…utbound (openclaw#29264) thanks @paceyw Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: paceyw <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@paceyw

…utbound (openclaw#29264) thanks @paceyw Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: paceyw <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@paceyw

…utbound (openclaw#29264) thanks @paceyw Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: paceyw <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit 2fcfe04)

@paceyw

…utbound (openclaw#29264) thanks @paceyw Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: paceyw <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit 2fcfe04)

@paceyw

…utbound (openclaw#29264) thanks @paceyw Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: paceyw <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit 2fcfe04)

@paceyw

…utbound (openclaw#29264) thanks @paceyw Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: paceyw <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@paceyw

…utbound (openclaw#29264) thanks @paceyw Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: paceyw <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@paceyw

…utbound (openclaw#29264) thanks @paceyw Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: paceyw <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@paceyw

…utbound (openclaw#29264) thanks @paceyw Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: paceyw <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@paceyw

…utbound (openclaw#29264) thanks @paceyw Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: paceyw <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@paceyw

…utbound (openclaw#29264) thanks @paceyw Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: paceyw <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@paceyw

…utbound (openclaw#29264) thanks @paceyw Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: paceyw <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@paceyw

…utbound (openclaw#29264) thanks @paceyw Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: paceyw <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@paceyw

…utbound (openclaw#29264) thanks @paceyw Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: paceyw <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@paceyw

…utbound (openclaw#29264) thanks @paceyw Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: paceyw <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@paceyw

…utbound (openclaw#29264) thanks @paceyw Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: paceyw <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@paceyw

…utbound (openclaw#29264) thanks @paceyw Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: paceyw <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@paceyw

…utbound (openclaw#29264) thanks @paceyw Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: paceyw <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@paceyw

…utbound (openclaw#29264) thanks @paceyw Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: paceyw <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@paceyw

…utbound (openclaw#29264) thanks @paceyw Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: paceyw <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@paceyw

…utbound (openclaw#29264) thanks @paceyw Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: paceyw <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit 0e4c24e)

openclaw-barnacle bot added channel: feishu Channel integration: feishu size: XS labels Feb 28, 2026

greptile-apps bot reviewed Feb 28, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Feb 28, 2026

View reviewed changes

openclaw-barnacle bot added size: S and removed size: XS labels Feb 28, 2026

paceyw and others added 3 commits February 27, 2026 21:16

fix(feishu): auto-convert local image path text to image send in outb…

d2cfa85

…ound

fix(feishu): handle race condition and format issues

f551e05

- Add try-catch around fs.statSync to handle file deletion between existsSync and statSync - Fix oxfmt formatting issues

test(feishu): cover sendText local image path shim

14cad1e

Takhoffman force-pushed the fix/feishu-local-image-path-autoupload branch from 6e66b9d to 14cad1e Compare February 28, 2026 03:28

Takhoffman merged commit 0e4c24e into openclaw:main Feb 28, 2026
13 checks passed

chatgpt-codex-connector bot reviewed Feb 28, 2026

View reviewed changes

github-actions bot mentioned this pull request Feb 28, 2026

🦞 OpenClaw 生态日报 2026-02-28 duanyytop/agents-radar#28

Open

alexey-pelykh mentioned this pull request Mar 10, 2026

Cherry-pick: Feishu adapter — community PRs and fixes remoteclaw/remoteclaw#678

Closed

alexey-pelykh mentioned this pull request Mar 15, 2026

Cherry-pick 0e4c24ebe: fix(feishu): auto-convert local image path to image message remoteclaw/remoteclaw#1462

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(feishu): auto-convert local image path text to image message in outbound#29264

fix(feishu): auto-convert local image path text to image message in outbound#29264
Takhoffman merged 3 commits intoopenclaw:mainfrom
paceyw:fix/feishu-local-image-path-autoupload

paceyw commented Feb 28, 2026

Uh oh!

greptile-apps bot commented Feb 28, 2026

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Feb 28, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Feb 28, 2026

Uh oh!

Uh oh!

Takhoffman commented Feb 28, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Feb 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		if (!fs.existsSync(raw)) return null;
		if (!fs.statSync(raw).isFile()) return null;

		const hasWhitespace = /\s/.test(raw);
		if (hasWhitespace) return null;

Uh oh!

Conversation

paceyw commented Feb 28, 2026

Problem

Root Cause

Fix (Scheme A)

Why this approach

Validation checklist

Notes

Uh oh!

greptile-apps bot commented Feb 28, 2026

Greptile Summary

Confidence Score: 3/5

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Takhoffman commented Feb 28, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants