fix: pass rootId to streaming card in Feishu topic groups by Sid-Qin · Pull Request #28346 · openclaw/openclaw

Sid-Qin · 2026-02-27T05:34:03Z

Summary

Problem: In Feishu topic groups, when the agent uses streaming cards to reply, the streaming card message creates a new topic instead of replying under the original topic. The first plain-text reply is correct, but subsequent streaming card replies break topic threading.
Why it matters: This creates a confusing UX where agent responses are scattered across multiple topics instead of being grouped under the user's original message thread.
What changed: Thread rootId through the entire reply chain: bot.ts (has ctx.rootId) → reply-dispatcher.ts (new rootId param) → streaming-card.ts (root_id in im.message.create payload).
What did NOT change: Plain-text reply path using client.im.message.reply() is unaffected (it already handles topic threading implicitly).

Change Type (select all)

Bug fix

Scope (select all touched areas)

Channel: Feishu

Linked Issue/PR

Closes Feishu 话题群流式回复创建新话题问题 #28273

User-visible / Behavior Changes

Streaming card replies in Feishu topic groups now appear under the original topic instead of creating new topics.

Security Impact (required)

New permissions/capabilities? No
Secrets/tokens handling changed? No
New/changed network calls? No — same im.message.create API, just adding root_id field
Command/tool execution surface changed? No
Data access scope changed? No

Evidence

npx vitest run extensions/feishu/ — 64/64 passed
npx oxfmt --check — clean

Human Verification (required)

Verified scenarios: Code review confirms root_id is correctly threaded through all three files; root_id is only included when non-null (conditional spread)
What you did not verify: Live Feishu topic group streaming card reply (requires Feishu bot setup)

Compatibility / Migration

Backward compatible? Yes — root_id is optional in Feishu API; omitting it (non-topic chats) is unchanged
Config/env changes? No
Migration needed? No

Failure Recovery (if this breaks)

Revert commit; streaming card replies return to creating new topics (existing behavior)

Risks and Mitigations

root_id is spread conditionally (...(rootId ? { root_id: rootId } : undefined)), so non-topic group chats and DM chats are completely unaffected.

greptile-apps · 2026-02-27T05:36:14Z

Greptile Summary

Correctly threads rootId from Feishu message context through the reply dispatcher to the streaming card API, fixing the bug where streaming replies in topic groups created new topics instead of replying under the original topic. The implementation properly handles the optional nature of rootId (only present in topic group messages) by using optional parameters throughout the chain and conditional spreading in the final API payload.

Confidence Score: 5/5

This PR is safe to merge with minimal risk
The changes are minimal, focused, and correctly implement the fix by threading an optional parameter through the call chain. All existing tests pass, the implementation follows existing patterns in the codebase, and the change is backwards compatible (rootId is optional).
No files require special attention

_{Last reviewed commit: 437830e}

When replying in a Feishu topic group, the streaming card message was created without root_id, causing it to spawn a new topic instead of replying under the original one. Thread rootId through bot.ts → reply-dispatcher.ts → streaming-card.ts so that im.message.create includes root_id for topic-scoped replies. Closes openclaw#28273 Made-with: Cursor

Takhoffman · 2026-02-28T02:21:06Z

PR #28346 - fix: pass rootId to streaming card in Feishu topic groups (#28346)

Merged via squash.

Merge commit: cdc48f9f256bc484f8ec35e0f5390f972a6689eb
Verified: pnpm check, pnpm test extensions/feishu/src/reply-dispatcher.test.ts
Changes made:
M extensions/feishu/src/reply-dispatcher.test.ts
M extensions/feishu/src/reply-dispatcher.ts
M extensions/feishu/src/streaming-card.ts
M scripts/check-no-raw-channel-fetch.mjs
Why these changes were made:
Resolve rebase conflicts while preserving existing replyInThread behavior and ensure topic-group streaming card replies include rootId routing with regression coverage.
Changelog: CHANGELOG.md updated=false required=true opt_out=false

Thanks @Sid-Qin!

Takhoffman · 2026-02-28T02:21:13Z

Correction: the merge commit SHA is 4221b5f.

@Sid-Qin

…8346) thanks @Sid-Qin Verified: - pnpm check - pnpm test extensions/feishu/src/reply-dispatcher.test.ts Co-authored-by: Sid-Qin <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Sid-Qin

…8346) thanks @Sid-Qin Verified: - pnpm check - pnpm test extensions/feishu/src/reply-dispatcher.test.ts Co-authored-by: Sid-Qin <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Sid-Qin

…8346) thanks @Sid-Qin Verified: - pnpm check - pnpm test extensions/feishu/src/reply-dispatcher.test.ts Co-authored-by: Sid-Qin <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Sid-Qin

…8346) thanks @Sid-Qin Verified: - pnpm check - pnpm test extensions/feishu/src/reply-dispatcher.test.ts Co-authored-by: Sid-Qin <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit 5dd2a37)

@Sid-Qin

…8346) thanks @Sid-Qin Verified: - pnpm check - pnpm test extensions/feishu/src/reply-dispatcher.test.ts Co-authored-by: Sid-Qin <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit 5dd2a37)

@Sid-Qin

…8346) thanks @Sid-Qin Verified: - pnpm check - pnpm test extensions/feishu/src/reply-dispatcher.test.ts Co-authored-by: Sid-Qin <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit 5dd2a37)

@Sid-Qin

…8346) thanks @Sid-Qin Verified: - pnpm check - pnpm test extensions/feishu/src/reply-dispatcher.test.ts Co-authored-by: Sid-Qin <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Sid-Qin

…8346) thanks @Sid-Qin Verified: - pnpm check - pnpm test extensions/feishu/src/reply-dispatcher.test.ts Co-authored-by: Sid-Qin <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Sid-Qin

…8346) thanks @Sid-Qin Verified: - pnpm check - pnpm test extensions/feishu/src/reply-dispatcher.test.ts Co-authored-by: Sid-Qin <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Sid-Qin

…8346) thanks @Sid-Qin Verified: - pnpm check - pnpm test extensions/feishu/src/reply-dispatcher.test.ts Co-authored-by: Sid-Qin <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Sid-Qin

…8346) thanks @Sid-Qin Verified: - pnpm check - pnpm test extensions/feishu/src/reply-dispatcher.test.ts Co-authored-by: Sid-Qin <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Sid-Qin

…8346) thanks @Sid-Qin Verified: - pnpm check - pnpm test extensions/feishu/src/reply-dispatcher.test.ts Co-authored-by: Sid-Qin <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit 4221b5f) # Conflicts: # extensions/feishu/src/bot.ts # extensions/feishu/src/reply-dispatcher.test.ts # extensions/feishu/src/reply-dispatcher.ts # extensions/feishu/src/streaming-card.ts # scripts/check-no-raw-channel-fetch.mjs

@Sid-Qin

…8346) thanks @Sid-Qin Verified: - pnpm check - pnpm test extensions/feishu/src/reply-dispatcher.test.ts Co-authored-by: Sid-Qin <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Sid-Qin

…8346) thanks @Sid-Qin Verified: - pnpm check - pnpm test extensions/feishu/src/reply-dispatcher.test.ts Co-authored-by: Sid-Qin <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Sid-Qin

…8346) thanks @Sid-Qin Verified: - pnpm check - pnpm test extensions/feishu/src/reply-dispatcher.test.ts Co-authored-by: Sid-Qin <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Sid-Qin

…8346) thanks @Sid-Qin Verified: - pnpm check - pnpm test extensions/feishu/src/reply-dispatcher.test.ts Co-authored-by: Sid-Qin <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Sid-Qin

…8346) thanks @Sid-Qin Verified: - pnpm check - pnpm test extensions/feishu/src/reply-dispatcher.test.ts Co-authored-by: Sid-Qin <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Sid-Qin

…8346) thanks @Sid-Qin Verified: - pnpm check - pnpm test extensions/feishu/src/reply-dispatcher.test.ts Co-authored-by: Sid-Qin <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Sid-Qin

…8346) thanks @Sid-Qin Verified: - pnpm check - pnpm test extensions/feishu/src/reply-dispatcher.test.ts Co-authored-by: Sid-Qin <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit 4221b5f) # Conflicts: # extensions/feishu/src/bot.ts # extensions/feishu/src/reply-dispatcher.test.ts # extensions/feishu/src/reply-dispatcher.ts # extensions/feishu/src/streaming-card.ts # scripts/check-no-raw-channel-fetch.mjs

@Sid-Qin

…8346) thanks @Sid-Qin Verified: - pnpm check - pnpm test extensions/feishu/src/reply-dispatcher.test.ts Co-authored-by: Sid-Qin <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Sid-Qin

…8346) thanks @Sid-Qin Verified: - pnpm check - pnpm test extensions/feishu/src/reply-dispatcher.test.ts Co-authored-by: Sid-Qin <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Sid-Qin

…8346) thanks @Sid-Qin Verified: - pnpm check - pnpm test extensions/feishu/src/reply-dispatcher.test.ts Co-authored-by: Sid-Qin <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

@Sid-Qin

…8346) thanks @Sid-Qin Verified: - pnpm check - pnpm test extensions/feishu/src/reply-dispatcher.test.ts Co-authored-by: Sid-Qin <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> (cherry picked from commit 4221b5f)

@Sid-Qin

…8346) thanks @Sid-Qin (#1459) Verified: - pnpm check - pnpm test extensions/feishu/src/reply-dispatcher.test.ts (cherry picked from commit 4221b5f) Co-authored-by: Sid <[email protected]> Co-authored-by: Sid-Qin <[email protected]> Co-authored-by: Tak Hoffman <[email protected]>

openclaw-barnacle bot added channel: feishu Channel integration: feishu size: XS experienced-contributor labels Feb 27, 2026

openclaw-barnacle bot added the scripts Repository scripts label Feb 28, 2026

SidQin-cyber and others added 3 commits February 27, 2026 20:03

fix(feishu): unblock topic rootId streaming checks

127091c

fix(feishu): resolve rebase conflicts for topic-root streaming

2290224

Takhoffman force-pushed the fix/feishu-topic-rootid-streaming-28273 branch from 4da3b8d to 2290224 Compare February 28, 2026 02:05

Takhoffman merged commit 4221b5f into openclaw:main Feb 28, 2026
26 checks passed

github-actions bot mentioned this pull request Mar 1, 2026

cherry-pick: upstream bugfix commits (2026-03-01-0443) hughdidit/DAISy-Agency#140

Closed

6 tasks

alexey-pelykh mentioned this pull request Mar 10, 2026

Cherry-pick: Feishu adapter — community PRs and fixes remoteclaw/remoteclaw#678

Closed

alexey-pelykh mentioned this pull request Mar 15, 2026

Cherry-pick 4221b5f80: fix: pass rootId to streaming card in Feishu topic groups (opencl remoteclaw/remoteclaw#1459

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: pass rootId to streaming card in Feishu topic groups#28346

fix: pass rootId to streaming card in Feishu topic groups#28346
Takhoffman merged 3 commits intoopenclaw:mainfrom
Sid-Qin:fix/feishu-topic-rootid-streaming-28273

Sid-Qin commented Feb 27, 2026 •

edited

Loading

Uh oh!

greptile-apps bot commented Feb 27, 2026

Uh oh!

Uh oh!

Takhoffman commented Feb 28, 2026

Uh oh!

Takhoffman commented Feb 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Sid-Qin commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

User-visible / Behavior Changes

Security Impact (required)

Evidence

Human Verification (required)

Compatibility / Migration

Failure Recovery (if this breaks)

Risks and Mitigations

Uh oh!

greptile-apps bot commented Feb 27, 2026

Greptile Summary

Confidence Score: 5/5

Uh oh!

Uh oh!

Takhoffman commented Feb 28, 2026

Uh oh!

Takhoffman commented Feb 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sid-Qin commented Feb 27, 2026 •

edited

Loading