fix(csp): allow Google Fonts in Control UI CSP header#28202
fix(csp): allow Google Fonts in Control UI CSP header#28202Glucksberg wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Greptile SummaryAdded
Confidence Score: 5/5
Last reviewed commit: 608e980 |
|
Thanks for the update on this. I am closing this as superseded by #29279 to keep one active PR for this Google Fonts CSP regression. If you see coverage missing in the new PR, call it out and I will reopen this thread. |
|
Thanks for the earlier contribution. I’m going to close this as a duplicate of #29279. If this is a miss, tell me and I can reopen review right away. |
Summary
https://fonts.googleapis.comto thestyle-srcCSP directive so the Control UI can load the Google Fonts stylesheet (Space Grotesk + JetBrains Mono)https://fonts.gstatic.comto thefont-srcCSP directive so the browser can fetch the actual font filesFixes #23050
Test plan
control-ui-csp.test.tspasses (2 tests, including new Google Fonts test)control-ui.http.test.tspasses (12 tests, existing security header assertions still hold)http://127.0.0.1:18789/?token=<token>, verify no CSP violations in console, verify hamburger menu works, verify Space Grotesk / JetBrains Mono fonts load