fix(mattermost): pass payload.replyToId as root_id for threaded replies by hnykda · Pull Request #27744 · openclaw/openclaw

hnykda · 2026-02-26T16:34:37Z

Summary

Problem: [[reply_to_current]] and [[reply_to:<id>]] tags are correctly parsed and stripped from outgoing text, but the monitor's deliver callback ignores payload.replyToId and hardcodes replyToId: threadRootId. For top-level messages (no existing thread), threadRootId is undefined, so replies are never threaded.
Why it matters: Mattermost users see bot responses as new top-level posts instead of threaded replies, breaking conversation flow.
What changed: Monitor deliver callback now uses payload.replyToId || threadRootId (prefer tag-resolved ID, fall back to existing thread root). Added tests at three levels: API client root_id passthrough, reply threading pipeline, and monitor deliver logic.
What did NOT change: Tag parsing, reply pipeline, outbound adapter, sendMessageMattermost — all already worked correctly.

Change Type (select all)

Bug fix

Scope (select all touched areas)

Integrations

Linked Issue/PR

Closes [[reply_to_current]] tag does not create thread replies on Mattermost #27707

User-visible / Behavior Changes

[[reply_to_current]] and [[reply_to:<id>]] now produce threaded replies on Mattermost (sets root_id on POST /api/v4/posts).

Security Impact (required)

New permissions/capabilities? No
Secrets/tokens handling changed? No
New/changed network calls? No (same API call, just includes root_id field when appropriate)
Command/tool execution surface changed? No
Data access scope changed? No

Repro + Verification

Environment

Integration/channel: Mattermost

Steps

Send a DM to the bot on Mattermost
Bot responds with [[reply_to_current]] some reply text
Check whether the reply appears as a thread reply or a top-level post

Expected

Reply appears as a threaded reply to the original message

Actual (before fix)

Reply appears as a new top-level post (root_id not set)

Evidence

Failing test/log before + passing after

Tests fail with buggy return threadRootId (3 failures), pass with fix return payload.replyToId || threadRootId.

Human Verification (required)

Verified scenarios: Tests confirm tag-resolved replyToId is passed through for top-level DMs, explicit [[reply_to:<id>]], fallback to threadRootId, and precedence when both are present.
Edge cases checked: undefined threadRootId + defined payload.replyToId, defined threadRootId + undefined payload.replyToId, both defined (payload wins).
What you did not verify: Live Mattermost instance end-to-end.

Compatibility / Migration

Backward compatible? Yes
Config/env changes? No
Migration needed? No

Failure Recovery (if this breaks)

Revert this single commit.
Known bad symptoms: replies suddenly appearing in wrong threads (would require payload.replyToId to contain an invalid post ID, which would be a pre-existing bug in tag parsing).

Risks and Mitigations

None — the change is a two-line fix using the same payload.replyToId that other channels already consume.

greptile-apps · 2026-02-26T16:38:29Z

Greptile Summary

Fixed Mattermost threaded replies by correctly passing payload.replyToId (from [[reply_to_current]] and [[reply_to:<id>]] tags) to the Mattermost API's root_id field. The monitor's deliver callback now uses payload.replyToId || threadRootId instead of hardcoding threadRootId, ensuring replies thread correctly for top-level messages.

What changed: Two-line fix in monitor.ts (lines 753, 764) to prefer tag-resolved reply ID over thread context
Why it matters: Without this fix, bot responses to top-level Mattermost DMs appear as new posts instead of threaded replies, breaking conversation flow
Test coverage: Comprehensive tests added at three levels - API client (createMattermostPost with/without root_id), reply pipeline (applyReplyThreading tag resolution), and monitor deliver logic (precedence rules)
Backward compatibility: Yes - falls back to existing threadRootId when no explicit reply tag is present

Confidence Score: 5/5

This PR is safe to merge with minimal risk
The fix is a minimal two-line change with clear logic (payload.replyToId || threadRootId), comprehensive test coverage at multiple levels, correct type safety, and backward compatibility. The change only affects Mattermost reply threading behavior and has no security implications.
No files require special attention

_{Last reviewed commit: e07e563}

hnykda · 2026-02-27T10:34:13Z

Testing Results

Tested on self-hosted Mattermost Team Edition with OpenClaw 2026.2.25 + this patch applied via git apply.

Setup: chatmode: "onmessage", groupPolicy: "open", bot joined to channel

Confirmed working ✅

Reactive replies to channel messages are correctly threaded (root_id set to inbound message ID)
message tool with explicit replyTo=<messageId> correctly sets root_id → threaded reply
Tag is stripped from outgoing text as expected

openclaw-barnacle · 2026-03-05T04:10:02Z

This pull request has been automatically marked as stale due to inactivity.
Please add updates or it will be closed.

hnykda · 2026-03-05T09:09:13Z

What should I do? The PR is good, it should be merged, it's tested.

@hnykda

…27744) thanks @hnykda

… callback

@hnykda

…27744) thanks @hnykda

mukhtharcm · 2026-03-08T08:43:17Z

Merged via squash.

Prepared head SHA: e02907987221bd6ced0a93ff6fcff58531283150
Merge commit: 9425209602143aef73288fe61edc47b23fbc5eb2

Thanks @hnykda!

ucef94 · 2026-03-08T09:29:36Z

extensions/mattermost/src/mattermost/monitor.test.ts

+    expect(
+      resolveMattermostReplyRootId({
+        replyToId: "inbound-post-123",
+      }),


@mukhtharcm

…es (openclaw#27744) Merged via squash. Prepared head SHA: e029079 Co-authored-by: hnykda <[email protected]> Co-authored-by: mukhtharcm <[email protected]> Reviewed-by: @mukhtharcm

@mukhtharcm

…es (openclaw#27744) Merged via squash. Prepared head SHA: e029079 Co-authored-by: hnykda <[email protected]> Co-authored-by: mukhtharcm <[email protected]> Reviewed-by: @mukhtharcm

@mukhtharcm

…es (openclaw#27744) Merged via squash. Prepared head SHA: e029079 Co-authored-by: hnykda <[email protected]> Co-authored-by: mukhtharcm <[email protected]> Reviewed-by: @mukhtharcm

@mukhtharcm

…es (openclaw#27744) Merged via squash. Prepared head SHA: e029079 Co-authored-by: hnykda <[email protected]> Co-authored-by: mukhtharcm <[email protected]> Reviewed-by: @mukhtharcm

@mukhtharcm

…es (openclaw#27744) Merged via squash. Prepared head SHA: e029079 Co-authored-by: hnykda <[email protected]> Co-authored-by: mukhtharcm <[email protected]> Reviewed-by: @mukhtharcm

@mukhtharcm

…es (openclaw#27744) Merged via squash. Prepared head SHA: e029079 Co-authored-by: hnykda <[email protected]> Co-authored-by: mukhtharcm <[email protected]> Reviewed-by: @mukhtharcm

@mukhtharcm

…es (openclaw#27744) Merged via squash. Prepared head SHA: e029079 Co-authored-by: hnykda <[email protected]> Co-authored-by: mukhtharcm <[email protected]> Reviewed-by: @mukhtharcm

@mukhtharcm

…es (openclaw#27744) Merged via squash. Prepared head SHA: e029079 Co-authored-by: hnykda <[email protected]> Co-authored-by: mukhtharcm <[email protected]> Reviewed-by: @mukhtharcm (cherry picked from commit 9425209)

@mukhtharcm

…es (openclaw#27744) Merged via squash. Prepared head SHA: e029079 Co-authored-by: hnykda <[email protected]> Co-authored-by: mukhtharcm <[email protected]> Reviewed-by: @mukhtharcm (cherry picked from commit 9425209)

openclaw-barnacle bot added channel: mattermost Channel integration: mattermost size: S labels Feb 26, 2026

hnykda force-pushed the fix/mattermost-reply-to-current-threading branch from 33533d5 to e07e563 Compare February 26, 2026 16:36

openclaw-barnacle bot added the stale Marked as stale due to inactivity label Mar 5, 2026

openclaw-barnacle bot removed the stale Marked as stale due to inactivity label Mar 6, 2026

mukhtharcm self-assigned this Mar 8, 2026

mukhtharcm force-pushed the fix/mattermost-reply-to-current-threading branch from e07e563 to e1d76d4 Compare March 8, 2026 07:53

openclaw-barnacle bot added the cli CLI command changes label Mar 8, 2026

mukhtharcm added a commit to hnykda/openclaw that referenced this pull request Mar 8, 2026

fix(mattermost): preserve thread root for threaded replies (openclaw#…

cfedb33

…27744) thanks @hnykda

hnykda and others added 4 commits March 8, 2026 08:24

fix(mattermost): pass payload.replyToId as root_id in monitor deliver…

d422240

… callback

test: fix formatting in Mattermost and daemon tests

fe40f90

fix(mattermost): preserve thread root for threaded replies (openclaw#…

3e585b4

…27744) thanks @hnykda

test: fix daemon lifecycle test formatting

e029079

mukhtharcm force-pushed the fix/mattermost-reply-to-current-threading branch from cfedb33 to e029079 Compare March 8, 2026 08:42

openclaw-barnacle bot removed the cli CLI command changes label Mar 8, 2026

mukhtharcm merged commit 9425209 into openclaw:main Mar 8, 2026
26 checks passed

ucef94 reviewed Mar 8, 2026

View reviewed changes

github-actions bot mentioned this pull request Mar 8, 2026

📡 Upstream Digest — 2026-03-08 10:17 UTC curtismercier/openclaw-mods#209

Open

teconomix mentioned this pull request Mar 8, 2026

feat(mattermost): add replyToMode support (off | first | all) #29587

Merged

hnykda deleted the fix/mattermost-reply-to-current-threading branch March 9, 2026 09:39

This was referenced Mar 9, 2026

Mattermost: block streaming + threading produces duplicate messages (one threaded, one top-level) #41219

Closed

fix(mattermost): prevent duplicate messages when block streaming + threading are active #41362

Merged

alexey-pelykh mentioned this pull request Mar 10, 2026

Cherry-pick: upstream misc root updates (20 commits) remoteclaw/remoteclaw#898

Closed

4 tasks

hnykda mentioned this pull request Mar 13, 2026

Intermediate assistant text leaks to Mattermost channels as unthreaded messages during multi-step tool calls #45134

Open

alexey-pelykh mentioned this pull request Mar 22, 2026

Cherry-pick issue #898: upstream misc root updates remoteclaw/remoteclaw#1806

Merged

hnykda mentioned this pull request Mar 26, 2026

fix(mattermost): restore threadRootId priority in DM thread replies #55135

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(mattermost): pass payload.replyToId as root_id for threaded replies#27744

fix(mattermost): pass payload.replyToId as root_id for threaded replies#27744
mukhtharcm merged 4 commits intoopenclaw:mainfrom
hnykda:fix/mattermost-reply-to-current-threading

hnykda commented Feb 26, 2026

Uh oh!

greptile-apps bot commented Feb 26, 2026

Uh oh!

hnykda commented Feb 27, 2026 •

edited

Loading

Uh oh!

openclaw-barnacle bot commented Mar 5, 2026

Uh oh!

hnykda commented Mar 5, 2026

Uh oh!

Uh oh!

mukhtharcm commented Mar 8, 2026

Uh oh!

ucef94 Mar 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

hnykda commented Feb 26, 2026

Summary

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

User-visible / Behavior Changes

Security Impact (required)

Repro + Verification

Environment

Steps

Expected

Actual (before fix)

Evidence

Human Verification (required)

Compatibility / Migration

Failure Recovery (if this breaks)

Risks and Mitigations

Uh oh!

greptile-apps bot commented Feb 26, 2026

Greptile Summary

Confidence Score: 5/5

Uh oh!

hnykda commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing Results

Confirmed working ✅

Uh oh!

openclaw-barnacle bot commented Mar 5, 2026

Uh oh!

hnykda commented Mar 5, 2026

Uh oh!

Uh oh!

mukhtharcm commented Mar 8, 2026

Uh oh!

ucef94 Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hnykda commented Feb 27, 2026 •

edited

Loading