fix(discord): add SSRF policy for Discord CDN to unblock Clash TUN fake-ip#27581
Open
white-rm wants to merge 2 commits intoopenclaw:mainfrom
Open
fix(discord): add SSRF policy for Discord CDN to unblock Clash TUN fake-ip#27581white-rm wants to merge 2 commits intoopenclaw:mainfrom
white-rm wants to merge 2 commits intoopenclaw:mainfrom
Conversation
Contributor
Greptile SummaryAdded
Confidence Score: 5/5
Last reviewed commit: 6442ff9 |
Contributor
|
Security review note: Good fix direction for Discord CDN under fake-IP/TUN setups. Evidence I checked:
One security follow-up I’d like:
CI failures currently look baseline-related (protocol drift + shared Windows loader test), not obviously from this diff. |
Member
|
This pull request has been automatically marked as stale due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #27534
Discord image attachments fail to download when running behind Clash TUN mode (fake-ip enabled). The Clash fake-ip range (
198.18.0.0/15, RFC 2544 benchmark) is correctly blocked by OpenClaw's SSRF protection, but this also blocks legitimate Discord CDN downloads when DNS resolves to fake-ip addresses.DISCORD_MEDIA_SSRF_POLICYthat trustscdn.discordapp.comandmedia.discordapp.net, and allows the RFC 2544 benchmark IP rangefetchRemoteMediacallsTELEGRAM_MEDIA_SSRF_POLICYinsrc/telegram/bot/delivery.ts)Test plan
message-utils.test.tstests updated and passing (20/20)