fix: strip ANSI codes from JSON output in skills list (#27530) by Jimmy-xuzimo · Pull Request #27557 · openclaw/openclaw

Jimmy-xuzimo · 2026-02-26T13:17:06Z

Summary

Fixes issue #27530 - openclaw skills list --json outputs malformed JSON containing raw ANSI terminal escape sequences.

Root Cause

The skills list --json command was including emoji fields that contained ANSI terminal escape sequences (from chalk styling). These control characters are not valid in JSON strings and caused parsing errors with tools like jq.

Example of broken output:

{
  "name": "himalaya",
  "emoji": "📧M-^_M-^S📧"
}

Fix

Added a regex pattern to strip ANSI escape codes from the emoji field when JSON output is requested.

Changes

src/cli/skills-cli.format.ts: Added ANSI pattern matching to strip escape sequences from emoji field in JSON output

Testing

Format check: ✅ Passed
Lint: ✅ Passed (0 warnings, 0 errors)
TypeScript: ✅ Passed

Before/After

Before:

{
  "emoji": "📧M-^_M-^S📧"
}

After:

{
  "emoji": "📧"
}

Impact

This fix enables proper JSON parsing for openclaw skills list --json output, making it compatible with jq and other JSON tools.

- Add 'google' to the list of reasoning tag providers in provider-utils.ts - This fixes issue openclaw#26551 where google provider (used by gemini-api-key auth) was not being recognized for reasoning tag filtering - Add corresponding test case for google provider

- Fix issue openclaw#26643 where cache hit rate shows >100% (e.g., 1142%) - Use Math.min(100, ...) to cap the percentage display - This is a display-only fix for edge cases where cacheRead exceeds tokens used

- Fix issue openclaw#27533 where xAI grok thinking output leaks to users - Add 'xai' to the list of reasoning tag providers in provider-utils.ts - Add test case for xai provider

- Fix issue openclaw#27530 where openclaw skills list --json outputs malformed JSON - The emoji field contained raw ANSI terminal escape sequences - Added regex to strip ANSI codes from emoji field when JSON output is requested - Disabled eslint rule for the regex pattern (intentional control char match)

chatgpt-codex-connector · 2026-02-26T13:17:10Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

greptile-apps · 2026-02-26T13:21:02Z

Greptile Summary

This PR fixes malformed JSON output from openclaw skills list --json by stripping ANSI escape codes from emoji fields. The fix correctly uses a regex pattern to remove ANSI color codes that were causing JSON parsing errors with tools like jq.

Key Changes:

Added ANSI pattern matching to strip escape sequences from emoji in skills list --json
Fixed cache hit rate to cap at 100% in status output
Added google and xai provider support to isReasoningTagProvider
Added Windows bash support detection for test files
Fixed escape sequence handling in test scripts

Issues Found:

The ANSI stripping fix is only applied to formatSkillsList but NOT to formatSkillInfo, meaning openclaw skills info <name> --json will still output ANSI codes in emoji fields
Trailing whitespace added to test files

Confidence Score: 3/5

This PR has a clear logic bug that should be fixed before merging
The main ANSI stripping fix is correct and well-implemented, but it's incomplete - the same fix needs to be applied to the formatSkillInfo function for consistency. The other changes (cache percentage cap, provider additions, Windows test support) are reasonable. The trailing whitespace in tests is a minor style issue.
src/cli/skills-cli.format.ts needs the ANSI stripping fix applied to formatSkillInfo function

_{Last reviewed commit: a3365a4}

greptile-apps

_{6 files reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-26T13:21:09Z

test/scripts/ios-team-id.test.ts

      `#!/usr/bin/env bash
 if [[ "$3" == "DVTDeveloperAccountManagerAppleIDLists" ]]; then
-  echo '(identifier = "[email protected]";)'
+  echo '(identifier = "[email protected]";)'  


Remove trailing whitespace

Suggested change

echo '(identifier = "[email protected]";)'

echo '(identifier = "[email protected]";)'

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

Prompt To Fix With AI

This is a comment left during a code review. Path: test/scripts/ios-team-id.test.ts Line: 87 Comment: Remove trailing whitespace ```suggestion echo '(identifier = "[email protected]";)' ``` <sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub> How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-02-26T13:21:11Z

test/scripts/ios-team-id.test.ts

      `#!/usr/bin/env bash
 if [[ "$3" == "DVTDeveloperAccountManagerAppleIDLists" ]]; then
-  echo '(identifier = "[email protected]";)'
+  echo '(identifier = "[email protected]";)'  


Remove trailing whitespace

Suggested change

echo '(identifier = "[email protected]";)'

echo '(identifier = "[email protected]";)'

Prompt To Fix With AI

This is a comment left during a code review. Path: test/scripts/ios-team-id.test.ts Line: 187 Comment: Remove trailing whitespace ```suggestion echo '(identifier = "[email protected]";)' ``` How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-02-26T13:21:12Z

test/scripts/ios-team-id.test.ts

      `#!/usr/bin/env bash
 if [[ "$3" == "DVTDeveloperAccountManagerAppleIDLists" ]]; then
-  echo '(identifier = "[email protected]";)'
+  echo '(identifier = "[email protected]";)'  


Remove trailing whitespace

Suggested change

echo '(identifier = "[email protected]";)'

echo '(identifier = "[email protected]";)'

Prompt To Fix With AI

This is a comment left during a code review. Path: test/scripts/ios-team-id.test.ts Line: 239 Comment: Remove trailing whitespace ```suggestion echo '(identifier = "[email protected]";)' ``` How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-02-26T13:21:14Z

Additional Comments (1)

src/cli/skills-cli.format.ts
ANSI codes should also be stripped from emoji field here for consistency with formatSkillsList. The same issue that affects skills list --json also affects skills info --json.

  if (opts.json) {
    // eslint-disable-next-line no-control-regex
    const ANSI_PATTERN = /\x1b\[[0-9;]*m/g;
    const jsonSkill = {
      ...skill,
      emoji: skill.emoji ? skill.emoji.replace(ANSI_PATTERN, "") : skill.emoji,
    };
    return JSON.stringify(jsonSkill, null, 2);
  }

Prompt To Fix With AI

This is a comment left during a code review.
Path: src/cli/skills-cli.format.ts
Line: 155-157

Comment:
ANSI codes should also be stripped from emoji field here for consistency with `formatSkillsList`. The same issue that affects `skills list --json` also affects `skills info --json`.

```suggestion
  if (opts.json) {
    // eslint-disable-next-line no-control-regex
    const ANSI_PATTERN = /\x1b\[[0-9;]*m/g;
    const jsonSkill = {
      ...skill,
      emoji: skill.emoji ? skill.emoji.replace(ANSI_PATTERN, "") : skill.emoji,
    };
    return JSON.stringify(jsonSkill, null, 2);
  }
```

How can I resolve this? If you propose a fix, please make it concise.

- Add ANSI escape code stripping to formatSkillInfo for JSON output - Remove trailing whitespace in ios-team-id.test.ts - Fix RuntimeEnv.warn usage to use .log instead

openclaw-barnacle · 2026-03-04T04:04:42Z

This pull request has been automatically marked as stale due to inactivity.
Please add updates or it will be closed.

Jimmy-xuzimo · 2026-03-08T13:28:02Z

Following up on this PR

This PR fixes an issue where openclaw skills list --json outputs malformed JSON containing ANSI terminal escape sequences, making it incompatible with tools like jq.

Summary

Issue: outputs malformed JSON with embedded ANSI terminal escape sequences #27530
Fix: Strip ANSI escape codes from emoji field in JSON output
Testing: Format check ✅, Lint ✅, TypeScript ✅

The fix is straightforward and low-risk - it only affects JSON output formatting when the --json flag is used.

Could a maintainer please review this PR? It's been marked as stale but the fix is still relevant and needed.

Thank you!

vincentkoc · 2026-03-11T23:36:04Z

Canonical follow-up is now #43520.

I kept that PR focused to the skills JSON control-byte fix with targeted regression coverage, since this branch currently includes unrelated changes beyond #27530.

vincentkoc · 2026-03-11T23:57:08Z

Fixed in #43520

Jimmy-xuzimo added 5 commits February 25, 2026 22:37

fix: eslint curly brace errors

21d7f52

fix: cap cache percentage at 100% in status output

4ccf9a9

- Fix issue openclaw#26643 where cache hit rate shows >100% (e.g., 1142%) - Use Math.min(100, ...) to cap the percentage display - This is a display-only fix for edge cases where cacheRead exceeds tokens used

fix: add xai provider to isReasoningTagProvider

2781a54

- Fix issue openclaw#27533 where xAI grok thinking output leaks to users - Add 'xai' to the list of reasoning tag providers in provider-utils.ts - Add test case for xai provider

openclaw-barnacle bot added cli CLI command changes commands Command implementations docker Docker and sandbox tooling size: S labels Feb 26, 2026

greptile-apps bot reviewed Feb 26, 2026

View reviewed changes

openclaw-barnacle bot added the stale Marked as stale due to inactivity label Mar 4, 2026

vincentkoc mentioned this pull request Mar 11, 2026

fix(terminal): sanitize skills JSON and fallback on legacy Windows #43520

Merged

20 tasks

vincentkoc mentioned this pull request Mar 11, 2026

outputs malformed JSON with embedded ANSI terminal escape sequences #27530

Closed

vincentkoc closed this Mar 11, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: strip ANSI codes from JSON output in skills list (#27530)#27557

fix: strip ANSI codes from JSON output in skills list (#27530)#27557
Jimmy-xuzimo wants to merge 5 commits intoopenclaw:mainfrom
Jimmy-xuzimo:fix/skills-json-ansi

Jimmy-xuzimo commented Feb 26, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 26, 2026

Uh oh!

greptile-apps bot commented Feb 26, 2026

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Feb 26, 2026

Uh oh!

greptile-apps bot Feb 26, 2026

Uh oh!

greptile-apps bot Feb 26, 2026

Uh oh!

greptile-apps bot commented Feb 26, 2026

Uh oh!

openclaw-barnacle bot commented Mar 4, 2026

Uh oh!

Jimmy-xuzimo commented Mar 8, 2026

Uh oh!

vincentkoc commented Mar 11, 2026

Uh oh!

vincentkoc commented Mar 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	echo '(identifier = "[email protected]";)'
	echo '(identifier = "[email protected]";)'

Uh oh!

Conversation

Jimmy-xuzimo commented Feb 26, 2026

Summary

Root Cause

Fix

Changes

Testing

Before/After

Impact

Uh oh!

chatgpt-codex-connector bot commented Feb 26, 2026

Uh oh!

greptile-apps bot commented Feb 26, 2026

Greptile Summary

Confidence Score: 3/5

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot commented Feb 26, 2026

Uh oh!

openclaw-barnacle bot commented Mar 4, 2026

Uh oh!

Jimmy-xuzimo commented Mar 8, 2026

Following up on this PR

Summary

Uh oh!

vincentkoc commented Mar 11, 2026

Uh oh!

vincentkoc commented Mar 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants