fix: suppress NO_REPLY in sub-agent announce flow by kevinWangSheng · Pull Request #27535 · openclaw/openclaw

kevinWangSheng · 2026-02-26T13:02:35Z

Summary

When a sub-agent returns NO_REPLY, the announce flow was not suppressing it, causing garbage messages like 'NO' and '✅ Done.' to leak into Slack channels.

Fix

This fix adds check alongside to properly suppress NO_REPLY in sub-agent announce flow.

Related Issue

Fixes #27531

Chokidar v5+ no longer supports glob patterns directly. This fix: - Uses glob library to expand patterns to actual file paths - Watches parent directories for add/unlink events - Filters to only SKILL.md files using ignored option Fixes openclaw#27404

Some OpenAI-compatible providers (e.g., yunwu-openai) return both input_tokens/output_tokens (both 0) and prompt_tokens/completion_tokens (with actual values). The previous code prioritized input_tokens, resulting in 0 token counts being recorded. This fix adds a helper that prefers non-zero values, falling back to the alternate field if the primary is 0. Fixes openclaw#27509

When a sub-agent returns NO_REPLY, the announce flow was not suppressing it, causing garbage messages like 'NO' and '✅ Done.' to leak into Slack channels. This fix adds isSilentReplyText check alongside isAnnounceSkip to properly suppress NO_REPLY in sub-agent announce flow. Fixes openclaw#27531

greptile-apps · 2026-02-26T13:06:47Z

Greptile Summary

This PR bundles three separate bug fixes across different subsystems:

NO_REPLY suppression (Sub-agent announce flow does not suppress NO_REPLY — leaks 'NO' + '✅ Done.' to channel #27531): added isSilentReplyText check in subagent-announce.ts:1165-1167 to prevent garbage messages like "NO" and "✅ Done." from leaking into Slack when sub-agents return NO_REPLY
Thinking block stripping (Compaction deletes thinkingSignature, causing Anthropic API rejection #27504): modified sessions-history-tool.ts to strip entire thinking blocks instead of just sanitizing them, avoiding Anthropic API rejection when thinking signatures are modified
Usage token normalization ([Bug] Independent agents receive empty responses from OpenAI-compatible providers (yunwu-openai) — input_tokens: 0, content: [] #27509): updated usage.ts to prefer non-zero values when OpenAI-compatible providers return both input_tokens (0) and prompt_tokens (actual count)
Glob dependency ([Bug]: skills glob file change watch via chokidar is not worked #27404): added glob package to dependencies but no corresponding code changes use it in this PR

All code changes are functionally correct and follow existing patterns. The NO_REPLY fix correctly uses the well-tested isSilentReplyText utility. The thinking block changes are well-documented with clear rationale. The usage normalization has comprehensive test coverage.

Confidence Score: 4/5

This PR is safe to merge with one minor verification needed
All code changes are correct and well-tested. The NO_REPLY suppression follows existing patterns, thinking block stripping is properly documented, and usage normalization has good test coverage. Score of 4 (not 5) because the glob dependency was added without corresponding code changes in this PR.
Verify package.json - glob dependency added but not used in any code changes

_{Last reviewed commit: f0a66ac}

greptile-apps

_{8 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-26T13:06:51Z

package.json

    "dotenv": "^17.3.1",
    "express": "^5.2.1",
    "file-type": "^21.3.0",
+    "glob": "^13.0.6",


check that glob dependency is actually used - no imports found in this PR despite commit message 48c38c2 describing implementation details

Prompt To Fix With AI

This is a comment left during a code review. Path: package.json Line: 175 Comment: check that `glob` dependency is actually used - no imports found in this PR despite commit message 48c38c2 describing implementation details How can I resolve this? If you propose a fix, please make it concise.

Landed follow-up for #27535 and aligned shared-auth gateway expectations after #27498. Co-authored-by: kevinWangSheng <[email protected]>

steipete · 2026-02-26T13:41:58Z

Landed on main.

Landed as a minimal rewritten follow-up via commit 96aad96 on main (to avoid stacked unrelated changes). Thanks @kevinWangSheng.