fix(bonjour): suppress ciao IPv4 address-change assertion crash#27359
Open
stone-jin wants to merge 1 commit intoopenclaw:mainfrom
Open
fix(bonjour): suppress ciao IPv4 address-change assertion crash#27359stone-jin wants to merge 1 commit intoopenclaw:mainfrom
stone-jin wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Contributor
Greptile SummaryExtended Confidence Score: 5/5
Last reviewed commit: 1c3706a |
|
This pull request has been automatically marked as stale due to inactivity. |
20 tasks
|
This pull request has been automatically marked as stale due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@homebridge/ciaofiresassert.fail()insideMDNSServer.handleUpdatedNetworkInterfaceswhen a network interface's IPv4 address transitions between defined↔undefined (WiFi drop, VPN toggle, sleep/wake).process.exit(1), crashing the gateway.ignoreCiaoCancellationRejectioninsrc/infra/bonjour-ciao.tsto also match ciao's IPv4 address-change assertions, logging them as non-fatal warnings instead of letting them crash the process.@homebridge/ciaodependency itself or other unhandled rejection logic.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
@homebridge/ciaoupstream bug inMDNSServer.handleUpdatedNetworkInterfacesUser-visible / Behavior Changes
Gateway no longer crashes when network interfaces change (WiFi disconnect/reconnect, VPN toggle, sleep/wake). A warning is logged instead.
Security Impact (required)
Repro + Verification
Environment
Steps
Expected
Actual (before fix)
AssertionError [ERR_ASSERTION]: Reached illegal state! IPV4 address change from defined to undefined!Evidence
Error trace before fix:
New tests added in
src/infra/bonjour-ciao.test.tscovering both assertion variants and unrelated error passthrough.Human Verification (required)
Compatibility / Migration
Failure Recovery (if this breaks)
src/infra/bonjour-ciao.tssrc/infra/bonjour-ciao.tsRisks and Mitigations
logWarn), and the bonjour watchdog (60s interval) will attempt re-advertisement if the service falls out ofannouncedstate