Exec approvals: honor explicit full/off policy#26532
Closed
chilu18 wants to merge 1 commit intoopenclaw:mainfrom
Closed
Exec approvals: honor explicit full/off policy#26532chilu18 wants to merge 1 commit intoopenclaw:mainfrom
chilu18 wants to merge 1 commit intoopenclaw:mainfrom
Conversation
|
This pull request has been automatically marked as stale due to inactivity. |
|
Closing this PR because the author has more than 10 active PRs in this repo. Please reduce the active PR queue and reopen or resubmit once it is back under the limit. You can close your own PRs to get back under the limit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Describe the problem and fix in 2–5 bullets:
Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
Gateways with exec approvals explicitly set to
security=fullandask=offno longer prompt for approval on gateway exec.Security Impact (required)
Yes/No) NoYes/No) NoYes/No) NoYes/No) NoYes/No) NoYes, explain risk + mitigation:Repro + Verification
Environment
Steps
pnpm test -- src/infra/exec-approvals-config.test.ts.Expected
Actual
Evidence
Attach at least one:
Human Verification (required)
What you personally verified (not just CI), and how:
pnpm test -- src/infra/exec-approvals-config.test.ts.Compatibility / Migration
Yes/No) YesYes/No) NoYes/No) NoFailure Recovery (if this breaks)
src/agents/bash-tools.exec-host-gateway.ts,src/infra/exec-approvals.ts.Risks and Mitigations
List only real risks for this PR. Add/remove entries as needed. If none, write
None.Greptile Summary
Fixed gateway exec approvals to honor explicit
security=fullandask=offpolicy configuration.resolveExplicitExecApprovalsPolicyfunction that returns raw config values without fallback defaultsbash-tools.exec-host-gateway.ts:69-78to bypassminSecurity/maxAskwhen both policies are explicitly set to full/offConfidence Score: 5/5
Last reviewed commit: 2c38f45