Compaction/Safeguard: preserve recent turns verbatim by rodrigouroz · Pull Request #25554 · openclaw/openclaw

rodrigouroz · 2026-02-24T15:27:02Z

Summary

Describe the problem and fix in 2–5 bullets:

Problem: safeguard compaction could lose exact phrasing from the freshest user/assistant turns.
Why it matters: immediate follow-up turns after compaction can miss critical recent context.
What changed: safeguard compaction now splits and preserves a configurable-count tail of recent user/assistant turns verbatim; added helper tests and runtime field.
What did NOT change (scope boundary): no structured heading enforcement, no quality-audit retry loop, no config-schema exposure yet.

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

Closes n/a (final close tracked in Compaction Runner: wire post-compaction memory sync #25561)
Related [Bug]: Compaction summarization does not preserve exact identifiers #19207, (fix): Compaction: preserve recent context and sync session memory post-compact #20038, Compaction: preserve opaque identifiers in summaries #25553

User-visible / Behavior Changes

Safeguard summaries include a "Recent turns preserved verbatim" section with the newest user/assistant turns.

Security Impact (required)

New permissions/capabilities? (No)
Secrets/tokens handling changed? (No)
New/changed network calls? (No)
Command/tool execution surface changed? (No)
Data access scope changed? (No)
If any Yes, explain risk + mitigation:

Repro + Verification

Environment

OS: macOS
Runtime/container: Node 22 + pnpm
Model/provider: n/a (unit tests)
Integration/channel (if any): n/a
Relevant config (redacted): safeguard runtime defaults

Steps

pnpm vitest run src/agents/pi-extensions/compaction-safeguard.test.ts
pnpm tsgo
Inspect helper behavior for preserve-count clamping and tail extraction.

Expected

Safeguard helper tests pass and preserved-turn section is generated correctly.

Actual

Local tests passed; typecheck passed.

Evidence

Attach at least one:

Failing test/log before + passing after
Trace/log snippets
Screenshot/recording
Perf numbers (if relevant)

Human Verification (required)

What you personally verified (not just CI), and how:

Verified scenarios: newest user/assistant turns are excluded from summarization input and appended verbatim to output.
Edge cases checked: preserve count clamp behavior (<0, unset, and very high values).
What you did not verify: provider-specific long-conversation live runs.

Compatibility / Migration

Backward compatible? (Yes)
Config/env changes? (No)
Migration needed? (No)
If yes, exact upgrade steps:

Failure Recovery (if this breaks)

How to disable/revert this change quickly: revert this PR.
Files/config to restore: src/agents/pi-extensions/compaction-safeguard.ts, src/agents/pi-extensions/compaction-safeguard-runtime.ts
Known bad symptoms reviewers should watch for: larger-than-expected safeguard summaries due to preserved tail.

Risks and Mitigations

List only real risks for this PR. Add/remove entries as needed. If none, write None.

Risk: preserving verbatim turns may slightly increase summary size.
- Mitigation: clamp and truncation bounds are enforced in helpers and covered by tests.

Stack: 2/9, depends on #25553.

rodrigouroz · 2026-02-27T14:47:59Z

@greptileai please review and update PR description

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cc02d4e70d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/agents/pi-extensions/compaction-safeguard.ts

greptile-apps · 2026-02-27T14:50:43Z

Greptile Summary

This PR adds functionality to preserve recent user/assistant turns verbatim during safeguard compaction, addressing the problem where exact phrasing from the freshest turns could be lost. The implementation correctly splits out a configurable number of recent turns (default 3, max 12) before summarization and appends them to the final summary.

Key changes:

Added recentTurnsPreserve runtime configuration field with proper clamping (0-12 turns)
Implemented helper functions (splitPreservedRecentTurns, formatPreservedTurnsSection) with defensive type guards and bounds checking
Preserved turns are excluded from summarization input and appended verbatim under "Recent turns preserved verbatim" section
Added comprehensive tests covering main scenarios and edge cases (clamping, empty messages, split behavior)

Code quality:

Proper TypeScript typing with no any usage
Defensive programming with fallback values and type guards
Clean separation of concerns with focused helper functions
Tests verify both happy path and edge cases

Confidence Score: 5/5

This PR is safe to merge with minimal risk
The implementation is well-tested, handles edge cases properly, follows repository conventions, and has no logical errors or security issues. The changes are backward compatible and isolated to the compaction safeguard extension.
No files require special attention

_{Last reviewed commit: cc02d4e}

rodrigouroz · 2026-03-03T12:56:00Z

@jalehman Hey Josh, I have several follow up PRs chained on top of this one. Would you like to review / test them all at once? Or do you prefer this approach?
Thank you

jalehman · 2026-03-03T15:00:53Z

Merged via squash.

Prepared head SHA: 7fb33c4
Merge commit: c8b45a4

Thanks @rodrigouroz!

jalehman · 2026-03-03T15:10:26Z

@jalehman Hey Josh, I have several follow up PRs chained on top of this one. Would you like to review / test them all at once? Or do you prefer this approach?

Individual PRs as you have them are fine. I'll add your others to my queue. Thank you!

@jalehman

Merged via squash. Prepared head SHA: 7fb33c4 Co-authored-by: rodrigouroz <[email protected]> Co-authored-by: jalehman <[email protected]> Reviewed-by: @jalehman

rodrigouroz mentioned this pull request Feb 24, 2026

Compaction/Safeguard: require structured summary headings #25555

Merged

18 tasks

openclaw-barnacle bot added agents Agent runtime and tooling size: M experienced-contributor labels Feb 24, 2026

rodrigouroz force-pushed the codex/pr20038-02 branch 2 times, most recently from e6f5191 to c4188db Compare February 24, 2026 15:38

rodrigouroz mentioned this pull request Feb 24, 2026

(fix): Compaction: preserve recent context and sync session memory post-compact #20038

Closed

18 tasks

rodrigouroz force-pushed the codex/pr20038-02 branch from c4188db to 3652276 Compare February 24, 2026 15:52

openclaw-barnacle bot added the app: web-ui App: web-ui label Feb 24, 2026

rodrigouroz force-pushed the codex/pr20038-02 branch 5 times, most recently from 006446c to 5ec8a8a Compare February 24, 2026 16:39

rodrigouroz marked this pull request as draft February 24, 2026 16:59

rodrigouroz force-pushed the codex/pr20038-02 branch from 5ec8a8a to ddc5d3b Compare February 26, 2026 17:30

openclaw-barnacle bot removed the app: web-ui App: web-ui label Feb 26, 2026

rodrigouroz force-pushed the codex/pr20038-02 branch from ddc5d3b to cc02d4e Compare February 27, 2026 14:46

rodrigouroz marked this pull request as ready for review February 27, 2026 14:46

openclaw-barnacle bot added size: S and removed size: M labels Feb 27, 2026

chatgpt-codex-connector bot reviewed Feb 27, 2026

View reviewed changes

src/agents/pi-extensions/compaction-safeguard.ts Show resolved Hide resolved

openclaw-barnacle bot removed docs Improvements or additions to documentation scripts Repository scripts commands Command implementations labels Feb 27, 2026

zymclaw mentioned this pull request Mar 3, 2026

fix: compaction-safeguard causes HTTP 400 error instead of graceful skip when no conversation messages #32759

Closed

jalehman force-pushed the codex/pr20038-02 branch from fafd7b7 to 890d422 Compare March 3, 2026 14:05

rodrigouroz and others added 9 commits March 3, 2026 06:59

Compaction/Safeguard: preserve recent turns verbatim

5d702a7

Compaction/Safeguard: repair pairing after recent-turn split

3af90e6

Compaction/Safeguard: preserve user-turn boundaries in recent tail

4fa4729

Compaction/Safeguard: preserve tool results in recent tail

04f2e40

Compaction/Safeguard: keep multimodal hints in preserved tail

b656de6

Compaction/Safeguard: skip faux non-text markers

3a8cf6a

Compaction/Safeguard: bound preserved tail fallback

1566d42

Compaction/Safeguard: avoid empty-history fallback text

9216b88

docs: add compaction safeguard changelog entry

7fb33c4

jalehman force-pushed the codex/pr20038-02 branch from 1a5e3db to 7fb33c4 Compare March 3, 2026 14:59

jalehman merged commit c8b45a4 into openclaw:main Mar 3, 2026
6 checks passed

github-actions bot mentioned this pull request Mar 3, 2026

📡 Upstream Digest — 2026-03-03 16:37 UTC curtismercier/openclaw-mods#173

Open

MillionthOdin16 added a commit to MillionthOdin16/openclaw that referenced this pull request Mar 3, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Compaction/Safeguard: preserve recent turns verbatim#25554

Compaction/Safeguard: preserve recent turns verbatim#25554
jalehman merged 9 commits intoopenclaw:mainfrom
rodrigouroz:codex/pr20038-02

rodrigouroz commented Feb 24, 2026 •

edited

Loading

Uh oh!

rodrigouroz commented Feb 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

greptile-apps bot commented Feb 27, 2026

Uh oh!

rodrigouroz commented Mar 3, 2026

Uh oh!

Uh oh!

jalehman commented Mar 3, 2026

Uh oh!

jalehman commented Mar 3, 2026 •

edited

Loading

Uh oh!

Uh oh!

Conversation

rodrigouroz commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

User-visible / Behavior Changes

Security Impact (required)

Repro + Verification

Environment

Steps

Expected

Actual

Evidence

Human Verification (required)

Compatibility / Migration

Failure Recovery (if this breaks)

Risks and Mitigations

Uh oh!

rodrigouroz commented Feb 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

greptile-apps bot commented Feb 27, 2026

Greptile Summary

Confidence Score: 5/5

Uh oh!

rodrigouroz commented Mar 3, 2026

Uh oh!

Uh oh!

jalehman commented Mar 3, 2026

Uh oh!

jalehman commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rodrigouroz commented Feb 24, 2026 •

edited

Loading

jalehman commented Mar 3, 2026 •

edited

Loading