fix(signal): add group-level allowlist support via groups config#25543
Closed
derekross wants to merge 1 commit intoopenclaw:mainfrom
Closed
fix(signal): add group-level allowlist support via groups config#25543derekross wants to merge 1 commit intoopenclaw:mainfrom
derekross wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Signal was the only channel missing group-level allowlist support. While Telegram, iMessage, WhatsApp, IRC, and BlueBubbles all use resolveChannelGroupPolicy to allow specific groups by ID, Signal only supported sender-level gating via groupAllowFrom. Changes: - Add SignalGroupConfig type with requireMention/tools/toolsBySender - Add SignalGroupSchema to Zod validation - Add groups field to SignalAccountSchemaBase - Wire resolveChannelGroupPolicy into Signal event handler - Groups explicitly allowed via config bypass sender-level checks - Incorporate groupExplicitlyAllowed into command authorization - Update docs with groups config usage and examples Fixes openclaw#25540 Supersedes openclaw#4337
|
This pull request has been automatically marked as stale due to inactivity. |
|
This pull request has been automatically marked as stale due to inactivity. |
|
Closing due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
channels.signal.groups.<groupId>config to allow specific Signal groups by IDgroupAllowFromcheckFixes #25540
Supersedes #4337
Changes
src/config/types.signal.ts: AddSignalGroupConfigtype andgroupsproperty toSignalAccountConfigsrc/config/zod-schema.providers-core.ts: AddSignalGroupSchemaandgroupsfield toSignalAccountSchemaBasesrc/signal/monitor/event-handler.ts: WireresolveChannelGroupPolicyinto Signal event handler, with group-level bypass for both message delivery and command authorizationdocs/channels/signal.md: Documentgroupsconfig with usage examplesImprovements over #4337
This version addresses the Greptile review feedback from the original PR:
groupExplicitlyAllowedis now incorporated into thecommandGateauthorizers, so explicitly allowed groups can also run control commands (not just receive messages)hasGroupAllowFromparam soresolveChannelGroupPolicycorrectly handles the case wheregroupAllowFromis configured but no explicitgroupsmap existsUsage
Testing
tsc --noEmitpasses)Greptile Summary
Added group-level allowlist support for Signal via
channels.signal.groups.<groupId>config, matching the pattern used by other messaging channels (Telegram, iMessage, WhatsApp, IRC). Groups explicitly listed in this config bypass sender-levelgroupAllowFromchecks and can run control commands.Key changes:
SignalGroupConfigtype withrequireMention,tools, andtoolsBySenderfieldsresolveChannelGroupPolicyinto Signal event handler to check group-level allowlist before sender-level checksgroupAllowFromcheck and are authorized for control commandsConfidence Score: 5/5
hasGroupAllowFromparameter, and properly integrates group-level authorization into both message delivery and command gating. The TypeScript compilation passes, types are properly defined, and the Zod schema validation is correctly configured. The documentation is comprehensive with clear examples.Last reviewed commit: 798c290
(3/5) Reply to the agent's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!
Context used:
dashboard- CLAUDE.md (source)dashboard- AGENTS.md (source)