fix(telegram): minimal threaded fallback when formatted text is empty#25096
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Additional Comments (1)
Prompt To Fix With AIThis is a comment left during a code review.
Path: src/telegram/bot/delivery.ts
Line: 585
Comment:
`shouldLog` should also suppress `EMPTY_TEXT_ERR_RE` errors since they're now handled and retried (similar to parse errors)
```suggestion
shouldLog: (err) => !PARSE_ERR_RE.test(formatErrorMessage(err)) && !EMPTY_TEXT_ERR_RE.test(formatErrorMessage(err)),
```
How can I resolve this? If you propose a fix, please make it concise. |
SamuelHinestrosa
suggested changes
Feb 24, 2026
SamuelHinestrosa
left a comment
SamuelHinestrosa
left a comment
There was a problem hiding this comment.
Revisión automática: Revisión completada. Verificar tests y compatibilidad.
Glucksberg
force-pushed
the
fix/25091-telegram-minimal
branch
from
February 24, 2026 10:34
f5d75c5 to
1b65161
Compare
Contributor
Author
…empty Minimal fix path for Telegram empty-text failures in threaded replies. - fallback to plain text when formatted htmlText is empty - retry plain text on parse/empty-text API errors - add focused regression test for threaded mode case Related: openclaw#25091 Supersedes alternative fix path in openclaw#17629 if maintainers prefer minimal scope.
openclaw-barnacle
Bot
added
docs
openclaw-barnacle
Bot
added
size: S
and removed
app: android
margulans
pushed a commit
to margulans/Neiron-AI-assistant
that referenced
this pull request
Feb 25, 2026
Jackson3195
pushed a commit
to Jackson3195/openclaw-with-a-personal-touch
that referenced
this pull request
Feb 25, 2026
kevinWangSheng
pushed a commit
to kevinWangSheng/openclaw
that referenced
this pull request
Feb 26, 2026
kevinWangSheng
pushed a commit
to kevinWangSheng/openclaw
that referenced
this pull request
Feb 26, 2026
2 tasks
oskarfreye
pushed a commit
to oskarfreye/openclaw
that referenced
this pull request
Feb 27, 2026
r4jiv007
pushed a commit
to r4jiv007/openclaw
that referenced
this pull request
Feb 28, 2026
6 tasks
hughdidit
pushed a commit
to hughdidit/DAISy-Agency
that referenced
this pull request
Mar 1, 2026
…anks @Glucksberg) (cherry picked from commit f154926) # Conflicts: # CHANGELOG.md # src/telegram/bot/delivery.test.ts
hughdidit
pushed a commit
to hughdidit/DAISy-Agency
that referenced
this pull request
Mar 3, 2026
…anks @Glucksberg) (cherry picked from commit f154926) # Conflicts: # CHANGELOG.md # src/telegram/bot/delivery.test.ts
lovewanwan
pushed a commit
to lovewanwan/openclaw
that referenced
this pull request
Apr 28, 2026
ogt-redknie
pushed a commit
to ogt-redknie/OPENX
that referenced
this pull request
May 2, 2026
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25091
Fixes #6652
Context
There are currently two valid fix strategies for the same Telegram empty-text bug class:
This PR intentionally keeps scope small to speed review/merge if maintainers prefer the narrowest safe patch first.
What this PR changes (minimal)
Why this minimal option exists
Related history
Merge decision / cleanup
Either path is acceptable. When one fix path is selected for merge, the other PR can be closed.