feat(feishu): persistent message deduplication to prevent duplicate replies#22604
Closed
Amateur0x1 wants to merge 1 commit intoopenclaw:mainfrom
Closed
feat(feishu): persistent message deduplication to prevent duplicate replies#22604Amateur0x1 wants to merge 1 commit intoopenclaw:mainfrom
Amateur0x1 wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Amateur0x1
force-pushed
the
fix/feishu-message-dedup-persistence
branch
from
a68cb59 to
1642228
Compare
Amateur0x1
force-pushed
the
fix/feishu-message-dedup-persistence
branch
from
1642228 to
ebbb525
Compare
Amateur0x1
force-pushed
the
fix/feishu-message-dedup-persistence
branch
from
ebbb525 to
bd3ba37
Compare
Amateur0x1
force-pushed
the
fix/feishu-message-dedup-persistence
branch
from
bd3ba37 to
394e1b3
Compare
Amateur0x1
force-pushed
the
fix/feishu-message-dedup-persistence
branch
2 times, most recently
from
6c46b07 to
1539976
Compare
3 tasks
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
extensions/feishu/src/dedup.ts
Outdated
Comment on lines
22
to
25
| // First check memory cache (fast path) | ||
| if (processedMessageIds.has(cacheKey)) { | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
redundant memory cache layer: dedup.ts maintains its own processedMessageIds cache, but tryRecordMessagePersistent also maintains memoryCache inside dedup-store.ts
the first check here will miss if the message was added during a previous run (only in disk), then tryRecordMessagePersistent will correctly find it in the persistent store and return false, but then line 35 adds it to processedMessageIds anyway. this works correctly but stores the same data twice in memory
consider removing processedMessageIds from dedup.ts and relying solely on the memoryCache inside dedup-store.ts, or document why both layers are needed
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI
This is a comment left during a code review.
Path: extensions/feishu/src/dedup.ts
Line: 22-25
Comment:
redundant memory cache layer: `dedup.ts` maintains its own `processedMessageIds` cache, but `tryRecordMessagePersistent` also maintains `memoryCache` inside `dedup-store.ts`
the first check here will miss if the message was added during a previous run (only in disk), then `tryRecordMessagePersistent` will correctly find it in the persistent store and return `false`, but then line 35 adds it to `processedMessageIds` anyway. this works correctly but stores the same data twice in memory
consider removing `processedMessageIds` from `dedup.ts` and relying solely on the `memoryCache` inside `dedup-store.ts`, or document why both layers are needed
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise.…eplies
- Add dedup-store.ts for filesystem-based message deduplication
- Extend dedup TTL from 30min to 24h for better reliability
- Survive OpenClaw restarts and WebSocket reconnects
- Use memory cache + disk storage for performance
Fixes duplicate message processing when Feishu redelivers messages
or WebSocket reconnects during one-on-one conversations.
Amateur0x1
force-pushed
the
fix/feishu-message-dedup-persistence
branch
from
1539976 to
1b18ba4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23369
Problem
Feishu may redeliver the same message multiple times, especially during:
In one-on-one chat mode, this causes duplicate replies to the same message. The existing in-memory dedup map is lost on restart, so duplicates slip through.
Solution
Implement persistent message deduplication with a dual-layer strategy:
Key Design Decisions
Changes
Testing
Fixes duplicate message processing in Feishu DM conversations.