fix(errors): distinguish process termination from billing errors#22502
Closed
Shuai-DaiDai wants to merge 1 commit into
Closed
fix(errors): distinguish process termination from billing errors#22502Shuai-DaiDai wants to merge 1 commit into
Shuai-DaiDai wants to merge 1 commit into
Conversation
) When local exec commands are terminated by SIGPIPE (exit 141) or SIGKILL (exit 137), they were incorrectly reported as billing errors. This fix adds isProcessTerminationError() to detect these signals and excludes them from billing error classification. Fixes #11722
|
This pull request has been automatically marked as stale due to inactivity. |
|
Closing due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11722
When local
execcommands are terminated by SIGPIPE (exit code 141) or SIGKILL (exit code 137), they were incorrectly reported as "API billing errors".Changes
isProcessTerminationError()function to detect SIGPIPE/SIGKILL signalsisBillingErrorMessage()to exclude process termination errorsTesting
curl -I https://example.com 2>&1 | head -n 5Feedback welcome!
Greptile Summary
Added
isProcessTerminationError()function to detect SIGPIPE (exit code 141/signal 13) and SIGKILL (exit code 137/signal 9) errors, and modifiedisBillingErrorMessage()to exclude these process termination errors, preventing them from being incorrectly reported as API billing errors.Confidence Score: 4/5
isProcessTerminationError()to verify all signal detection patterns work correctlyLast reviewed commit: 7e90325