fix: force store for openai-responses providers#22441
Closed
EdwardWu7 wants to merge 1 commit intoopenclaw:mainfrom
Closed
fix: force store for openai-responses providers#22441EdwardWu7 wants to merge 1 commit intoopenclaw:mainfrom
EdwardWu7 wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Contributor
Additional Comments (2)
Prompt To Fix With AIThis is a comment left during a code review.
Path: src/agents/pi-embedded-runner/extra-params.ts
Line: 13-14
Comment:
comment is outdated - it says "only force for *direct* OpenAI Responses" but the code now forces store for all `openai-responses` providers regardless of baseURL
```suggestion
// NOTE: Force `store=true` for all OpenAI Responses API providers (OpenAI, Azure, compatible endpoints).
// Codex responses (chatgpt.com/backend-api/codex/responses) require `store=false`.
```
How can I resolve this? If you propose a fix, please make it concise.
the test should be updated or removed to match the new behavior Prompt To Fix With AIThis is a comment left during a code review.
Path: src/agents/pi-embedded-runner/extra-params.ts
Line: 128-140
Comment:
removing the provider and baseURL checks will break the existing test on line 267-279 of `src/agents/pi-embedded-runner-extraparams.e2e.test.ts` that expects `store=false` for non-OpenAI base URLs (proxies)
the test should be updated or removed to match the new behavior
How can I resolve this? If you propose a fix, please make it concise. |
steipete
added a commit
that referenced
this pull request
Feb 27, 2026
, #22441, #25088) Landed from contributor PRs #16930, #22441, and #25088. Co-authored-by: liweiguang <[email protected]> Co-authored-by: EdwardWu7 <[email protected]> Co-authored-by: MoerAI <[email protected]>
Contributor
|
Landed on Rewrite summary:
SHA notes:
Thanks @EdwardWu7. |
This was referenced Feb 27, 2026
execute008
pushed a commit
to execute008/openclaw
that referenced
this pull request
Feb 27, 2026
…nclaw#16930, openclaw#22441, openclaw#25088) Landed from contributor PRs openclaw#16930, openclaw#22441, and openclaw#25088. Co-authored-by: liweiguang <[email protected]> Co-authored-by: EdwardWu7 <[email protected]> Co-authored-by: MoerAI <[email protected]>
r4jiv007
pushed a commit
to r4jiv007/openclaw
that referenced
this pull request
Feb 28, 2026
…nclaw#16930, openclaw#22441, openclaw#25088) Landed from contributor PRs openclaw#16930, openclaw#22441, and openclaw#25088. Co-authored-by: liweiguang <[email protected]> Co-authored-by: EdwardWu7 <[email protected]> Co-authored-by: MoerAI <[email protected]>
xiexikang
pushed a commit
to C-clawd/cclawd
that referenced
this pull request
Feb 28, 2026
…nclaw#16930, openclaw#22441, openclaw#25088) Landed from contributor PRs openclaw#16930, openclaw#22441, and openclaw#25088. Co-authored-by: liweiguang <[email protected]> Co-authored-by: EdwardWu7 <[email protected]> Co-authored-by: MoerAI <[email protected]>
mylukin
pushed a commit
to mylukin/openclaw
that referenced
this pull request
Feb 28, 2026
…nclaw#16930, openclaw#22441, openclaw#25088) Landed from contributor PRs openclaw#16930, openclaw#22441, and openclaw#25088. Co-authored-by: liweiguang <[email protected]> Co-authored-by: EdwardWu7 <[email protected]> Co-authored-by: MoerAI <[email protected]>
wanjizheng
pushed a commit
to wanjizheng/openclaw
that referenced
this pull request
Feb 28, 2026
…nclaw#16930, openclaw#22441, openclaw#25088) Landed from contributor PRs openclaw#16930, openclaw#22441, and openclaw#25088. Co-authored-by: liweiguang <[email protected]> Co-authored-by: EdwardWu7 <[email protected]> Co-authored-by: MoerAI <[email protected]>
wanjizheng
pushed a commit
to wanjizheng/openclaw
that referenced
this pull request
Feb 28, 2026
…nclaw#16930, openclaw#22441, openclaw#25088) Landed from contributor PRs openclaw#16930, openclaw#22441, and openclaw#25088. Co-authored-by: liweiguang <[email protected]> Co-authored-by: EdwardWu7 <[email protected]> Co-authored-by: MoerAI <[email protected]> (cherry picked from commit c38be8f)
wanjizheng
pushed a commit
to wanjizheng/openclaw
that referenced
this pull request
Feb 28, 2026
…nclaw#16930, openclaw#22441, openclaw#25088) Landed from contributor PRs openclaw#16930, openclaw#22441, and openclaw#25088. Co-authored-by: liweiguang <[email protected]> Co-authored-by: EdwardWu7 <[email protected]> Co-authored-by: MoerAI <[email protected]> (cherry picked from commit c38be8f)
wanjizheng
pushed a commit
to wanjizheng/openclaw
that referenced
this pull request
Feb 28, 2026
…nclaw#16930, openclaw#22441, openclaw#25088) Landed from contributor PRs openclaw#16930, openclaw#22441, and openclaw#25088. Co-authored-by: liweiguang <[email protected]> Co-authored-by: EdwardWu7 <[email protected]> Co-authored-by: MoerAI <[email protected]> (cherry picked from commit c38be8f)
vincentkoc
pushed a commit
to Sid-Qin/openclaw
that referenced
this pull request
Feb 28, 2026
…nclaw#16930, openclaw#22441, openclaw#25088) Landed from contributor PRs openclaw#16930, openclaw#22441, and openclaw#25088. Co-authored-by: liweiguang <[email protected]> Co-authored-by: EdwardWu7 <[email protected]> Co-authored-by: MoerAI <[email protected]>
vincentkoc
pushed a commit
to rylena/rylen-openclaw
that referenced
this pull request
Feb 28, 2026
…nclaw#16930, openclaw#22441, openclaw#25088) Landed from contributor PRs openclaw#16930, openclaw#22441, and openclaw#25088. Co-authored-by: liweiguang <[email protected]> Co-authored-by: EdwardWu7 <[email protected]> Co-authored-by: MoerAI <[email protected]>
newtontech
pushed a commit
to newtontech/openclaw-fork
that referenced
this pull request
Feb 28, 2026
…nclaw#16930, openclaw#22441, openclaw#25088) Landed from contributor PRs openclaw#16930, openclaw#22441, and openclaw#25088. Co-authored-by: liweiguang <[email protected]> Co-authored-by: EdwardWu7 <[email protected]> Co-authored-by: MoerAI <[email protected]>
wanjizheng
pushed a commit
to wanjizheng/openclaw
that referenced
this pull request
Mar 1, 2026
…nclaw#16930, openclaw#22441, openclaw#25088) Landed from contributor PRs openclaw#16930, openclaw#22441, and openclaw#25088. Co-authored-by: liweiguang <[email protected]> Co-authored-by: EdwardWu7 <[email protected]> Co-authored-by: MoerAI <[email protected]>
wanjizheng
pushed a commit
to wanjizheng/openclaw
that referenced
this pull request
Mar 1, 2026
…nclaw#16930, openclaw#22441, openclaw#25088) Landed from contributor PRs openclaw#16930, openclaw#22441, and openclaw#25088. Co-authored-by: liweiguang <[email protected]> Co-authored-by: EdwardWu7 <[email protected]> Co-authored-by: MoerAI <[email protected]>
steipete
added a commit
to Sid-Qin/openclaw
that referenced
this pull request
Mar 2, 2026
…nclaw#16930, openclaw#22441, openclaw#25088) Landed from contributor PRs openclaw#16930, openclaw#22441, and openclaw#25088. Co-authored-by: liweiguang <[email protected]> Co-authored-by: EdwardWu7 <[email protected]> Co-authored-by: MoerAI <[email protected]>
safzanpirani
pushed a commit
to safzanpirani/clawdbot
that referenced
this pull request
Mar 2, 2026
…nclaw#16930, openclaw#22441, openclaw#25088) Landed from contributor PRs openclaw#16930, openclaw#22441, and openclaw#25088. Co-authored-by: liweiguang <[email protected]> Co-authored-by: EdwardWu7 <[email protected]> Co-authored-by: MoerAI <[email protected]>
steipete
added a commit
to Sid-Qin/openclaw
that referenced
this pull request
Mar 2, 2026
…nclaw#16930, openclaw#22441, openclaw#25088) Landed from contributor PRs openclaw#16930, openclaw#22441, and openclaw#25088. Co-authored-by: liweiguang <[email protected]> Co-authored-by: EdwardWu7 <[email protected]> Co-authored-by: MoerAI <[email protected]>
venjiang
pushed a commit
to venjiang/openclaw
that referenced
this pull request
Mar 2, 2026
…nclaw#16930, openclaw#22441, openclaw#25088) Landed from contributor PRs openclaw#16930, openclaw#22441, and openclaw#25088. Co-authored-by: liweiguang <[email protected]> Co-authored-by: EdwardWu7 <[email protected]> Co-authored-by: MoerAI <[email protected]>
robertchang-ga
pushed a commit
to robertchang-ga/openclaw
that referenced
this pull request
Mar 2, 2026
…nclaw#16930, openclaw#22441, openclaw#25088) Landed from contributor PRs openclaw#16930, openclaw#22441, and openclaw#25088. Co-authored-by: liweiguang <[email protected]> Co-authored-by: EdwardWu7 <[email protected]> Co-authored-by: MoerAI <[email protected]>
dorgonman
pushed a commit
to kanohorizonia/openclaw
that referenced
this pull request
Mar 3, 2026
…nclaw#16930, openclaw#22441, openclaw#25088) Landed from contributor PRs openclaw#16930, openclaw#22441, and openclaw#25088. Co-authored-by: liweiguang <[email protected]> Co-authored-by: EdwardWu7 <[email protected]> Co-authored-by: MoerAI <[email protected]>
sachinkundu
pushed a commit
to sachinkundu/openclaw
that referenced
this pull request
Mar 6, 2026
…nclaw#16930, openclaw#22441, openclaw#25088) Landed from contributor PRs openclaw#16930, openclaw#22441, and openclaw#25088. Co-authored-by: liweiguang <[email protected]> Co-authored-by: EdwardWu7 <[email protected]> Co-authored-by: MoerAI <[email protected]>
zooqueen
pushed a commit
to hanzoai/bot
that referenced
this pull request
Mar 6, 2026
…nclaw#16930, openclaw#22441, openclaw#25088) Landed from contributor PRs openclaw#16930, openclaw#22441, and openclaw#25088. Co-authored-by: liweiguang <[email protected]> Co-authored-by: EdwardWu7 <[email protected]> Co-authored-by: MoerAI <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21782
Summary
store: truefor allopenai-responsesproviders, not just direct OpenAI hosts.previous_response_idfailures on Azure/OpenAI-compatible endpoints whenstoredefaults to false.Notes
storeis false.Greptile Summary
Simplifies
shouldForceResponsesStoreto forcestore=truefor allopenai-responsesAPI providers, removing the previous restriction to direct OpenAI hosts. This prevents 400 errors on Azure and OpenAI-compatible endpoints that require persisted items for multi-turn conversations.src/agents/pi-embedded-runner-extraparams.e2e.test.ts:267-279expectsstore=falsefor proxy URLs and will need to be updatedConfidence Score: 4/5
src/agents/pi-embedded-runner-extraparams.e2e.test.ts:267-279is updated to match the new behaviorLast reviewed commit: f3e1ad3
(2/5) Greptile learns from your feedback when you react with thumbs up/down!