fix(tui): strip inbound metadata blocks from user messages (clean rewrite) by vincentkoc · Pull Request #22345 · openclaw/openclaw

vincentkoc · 2026-02-21T02:11:49Z

This is a clean reroute of the closed PR for this change.

Reuses the final intended payload from the previously closed work.
Rebased onto origin/main and squashed to a single clean commit.
This branch is clean and ready for normal review.

This supersedes #22319. The original PR became stale due a detached/dirty head after history churn while attempting rebase/cleanup.

Closes #22276.

Greptile Summary

This PR consolidates duplicate metadata stripping implementations by removing stripInboundMetadataBlocks and switching all callers to use the canonical stripInboundMetadata function from src/auto-reply/reply/strip-inbound-meta.ts.

Key changes:

Replaced regex-based stripInboundMetadataBlocks with line-by-line state machine parser stripInboundMetadata
Updated src/gateway/chat-sanitize.ts and src/tui/tui-formatters.ts to use the canonical implementation
Updated tests to use DEFAULT_EMOJIS constants instead of hardcoded emoji literals (aligns with emoji set change from commit f555835)
Included unrelated fix from #086af568 for Discord DM component session key handling
Cleaned up CHANGELOG entries to remove duplicates and align with actual PR scope

The consolidation addresses the code duplication issue raised in previous review threads and ensures consistent metadata stripping behavior across TUI, webchat, and gateway surfaces.

Confidence Score: 5/5

This PR is safe to merge - it consolidates duplicate code implementations and includes test updates that properly align with recent emoji constant changes.
The consolidation successfully removes code duplication by making all callers use the canonical stripInboundMetadata implementation. Test changes correctly reflect upstream emoji constant changes (commit f555835) and Discord component behavior fixes (commit 086af56). The CHANGELOG cleanup removes duplicate entries and properly scopes the description to TUI-specific changes.
No files require special attention

_{Last reviewed commit: e148071}

greptile-apps

_{6 files reviewed, 3 comments}

_{Edit Code Review Agent Settings | Greptile}

src/shared/chat-envelope.ts

src/gateway/chat-sanitize.ts

src/tui/tui-formatters.ts

vincentkoc · 2026-02-21T02:38:35Z

PR #22345 status update (post-rebase)

I rebased this branch onto origin/main and pushed.

Branch is now non-draft with a clean 3-commit history.
Targeted PR-surface tests pass: src/gateway/chat-sanitize.test.ts + src/tui/tui-formatters.test.ts.

Current merge blocker: CI remains failing in unrelated suites (new/known baseline failures):

Observed failures are not in PR diff (src/gateway/chat-sanitize.ts, src/shared/chat-envelope.ts, src/tui/tui-formatters.ts, CHANGELOG.md) and include:

src/web/media.test.ts (local media path policy and cap assertions)
src/discord/send.components.test.ts
src/discord/monitor/message-handler.process.test.ts
src/media-understanding/runner.auto-audio.test.ts
src/media-understanding/runner.deepgram.test.ts
related extensions/msteams/src/messenger.test.ts

vincentkoc · 2026-02-21T03:39:10Z

Updated PR with Greptile issues addressed:

src/shared/chat-envelope.ts now aliases stripInboundMetadataBlocks to the canonical parser from src/auto-reply/reply/strip-inbound-meta.ts, removing duplicate implementation + .trim() behavior drift.
src/gateway/chat-sanitize.ts now uses stripInboundMetadata from canonical parser.
src/tui/tui-formatters.ts now uses stripInboundMetadata from canonical parser for user text extraction.

This commit has been pushed: 18adc45.

Current CI status still fails in CI -> check because format:check reports:

src/agents/tools/common.ts
src/channels/plugins/actions/discord/handle-action.guild-admin.ts
src/discord/send.channels.ts

Those are unrelated formatting-only drifts and block merge. I created a separate quick PR to fix them:

chore: format files blocking CI checks #22391

Once 22391 merges, rerun checks on #22345 and it should move to clean.

vincentkoc · 2026-02-21T03:40:59Z

@greptileai review

…rite) (openclaw#22345) * fix(tui): strip inbound metadata blocks from user text * chore: clean up metadata-strip format and changelog credit * chore: format tui metadata-strip tests * test: align metadata-strip regression expectations * refactor: reuse canonical inbound metadata stripper * test: allow tmp media fixture paths in media-understanding tests * refactor: reuse canonical inbound metadata stripper * format: fix changelog blank line after headings * test: fix unrelated check typing regressions * test: align memory async mock embedding signatures * test: avoid tsgo mock typing pitfall * test: restore async search mock typings in merge tree * test: trigger ci rerun without behavior change * chore: dedupe todays changelog entries * fix: dedupe sqlite mock keys in qmd manager test * Update qmd-manager.test.ts * test: align chat metadata sanitization expectation

…claw#22345) Co-authored-by: jiulingyun <[email protected]>

…rite) (openclaw#22345) * fix(tui): strip inbound metadata blocks from user text * chore: clean up metadata-strip format and changelog credit * chore: format tui metadata-strip tests * test: align metadata-strip regression expectations * refactor: reuse canonical inbound metadata stripper * test: allow tmp media fixture paths in media-understanding tests * refactor: reuse canonical inbound metadata stripper * format: fix changelog blank line after headings * test: fix unrelated check typing regressions * test: align memory async mock embedding signatures * test: avoid tsgo mock typing pitfall * test: restore async search mock typings in merge tree * test: trigger ci rerun without behavior change * chore: dedupe todays changelog entries * fix: dedupe sqlite mock keys in qmd manager test * Update qmd-manager.test.ts * test: align chat metadata sanitization expectation

…s from user messages (#322) * Initial plan * fix(tui): strip inbound metadata blocks from user messages (port openclaw#22345) Co-authored-by: jiulingyun <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: jiulingyun <[email protected]>

…rite) (openclaw#22345) * fix(tui): strip inbound metadata blocks from user text * chore: clean up metadata-strip format and changelog credit * chore: format tui metadata-strip tests * test: align metadata-strip regression expectations * refactor: reuse canonical inbound metadata stripper * test: allow tmp media fixture paths in media-understanding tests * refactor: reuse canonical inbound metadata stripper * format: fix changelog blank line after headings * test: fix unrelated check typing regressions * test: align memory async mock embedding signatures * test: avoid tsgo mock typing pitfall * test: restore async search mock typings in merge tree * test: trigger ci rerun without behavior change * chore: dedupe todays changelog entries * fix: dedupe sqlite mock keys in qmd manager test * Update qmd-manager.test.ts * test: align chat metadata sanitization expectation

vincentkoc mentioned this pull request Feb 21, 2026

fix(tui): strip inbound metadata blocks from user text #22319

Closed

18 tasks

openclaw-barnacle bot added gateway Gateway runtime size: S maintainer Maintainer-authored PR labels Feb 21, 2026

vincentkoc force-pushed the vincentkoc-code/clean-22319-rebase-origin-main branch from cafe70b to 1642afc Compare February 21, 2026 02:29

vincentkoc self-assigned this Feb 21, 2026

vincentkoc marked this pull request as ready for review February 21, 2026 02:29

greptile-apps bot reviewed Feb 21, 2026

View reviewed changes

src/shared/chat-envelope.ts Outdated Show resolved Hide resolved

src/gateway/chat-sanitize.ts Outdated Show resolved Hide resolved

src/tui/tui-formatters.ts Outdated Show resolved Hide resolved

vincentkoc mentioned this pull request Feb 21, 2026

test: isolate local media regression fixtures to allowed roots #22369

Merged

vincentkoc force-pushed the vincentkoc-code/clean-22319-rebase-origin-main branch from 1642afc to b5bd844 Compare February 21, 2026 03:14

openclaw-barnacle bot added size: XS channel: discord Channel integration: discord size: S gateway Gateway runtime size: M and removed gateway Gateway runtime size: S size: XS labels Feb 21, 2026

vincentkoc mentioned this pull request Feb 21, 2026

chore: format files blocking CI checks #22391

Merged

vincentkoc added 7 commits February 20, 2026 22:57

fix(tui): strip inbound metadata blocks from user text

d53647c

chore: clean up metadata-strip format and changelog credit

57c5d8b

chore: format tui metadata-strip tests

44b3539

test: align metadata-strip regression expectations

8858127

refactor: reuse canonical inbound metadata stripper

c99db25

test: allow tmp media fixture paths in media-understanding tests

46ac4a0

refactor: reuse canonical inbound metadata stripper

1a055e7

vincentkoc added 6 commits February 20, 2026 23:26

test: trigger ci rerun without behavior change

168bb73

Merge branch 'main' into vincentkoc-code/clean-22319-rebase-origin-main

29bacbd

chore: dedupe todays changelog entries

98d2621

fix: dedupe sqlite mock keys in qmd manager test

296cf8a

Update qmd-manager.test.ts

67df4c3

test: align chat metadata sanitization expectation

2ee2356

vincentkoc merged commit 35be87b into main Feb 21, 2026
7 of 8 checks passed

vincentkoc deleted the vincentkoc-code/clean-22319-rebase-origin-main branch February 21, 2026 04:52

github-actions bot mentioned this pull request Feb 21, 2026

📡 Upstream Digest — 2026-02-21 05:07 UTC curtismercier/openclaw-mods#83

Open

github-actions bot mentioned this pull request Feb 22, 2026

上游更新: v2026.2.21 — 32 P0 + 30 P1 待合并 jiulingyun/openclaw-cn#274

Closed

jiulingyun mentioned this pull request Feb 22, 2026

upstream(tui): 移植 1 个冲突 commit (P1) — v2026.2.19→v2026.2.21 jiulingyun/openclaw-cn#320

Closed

6 tasks

Copilot AI mentioned this pull request Feb 22, 2026

fix(tui): port upstream #22345 — strip inbound metadata blocks from user messages jiulingyun/openclaw-cn#322

Merged

Copilot AI added a commit to jiulingyun/openclaw-cn that referenced this pull request Feb 22, 2026

fix(tui): strip inbound metadata blocks from user messages (port open…

c8eaaeb

…claw#22345) Co-authored-by: jiulingyun <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(tui): strip inbound metadata blocks from user messages (clean rewrite)#22345

fix(tui): strip inbound metadata blocks from user messages (clean rewrite)#22345
vincentkoc merged 18 commits intomainfrom
vincentkoc-code/clean-22319-rebase-origin-main

vincentkoc commented Feb 21, 2026 •

edited by greptile-apps bot

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vincentkoc commented Feb 21, 2026

Uh oh!

vincentkoc commented Feb 21, 2026

Uh oh!

vincentkoc commented Feb 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

vincentkoc commented Feb 21, 2026 • edited by greptile-apps bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vincentkoc commented Feb 21, 2026

Uh oh!

vincentkoc commented Feb 21, 2026

Uh oh!

vincentkoc commented Feb 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vincentkoc commented Feb 21, 2026 •

edited by greptile-apps bot

Loading