iOS: gate capabilities by permissions and add settings controls by mbelinky · Pull Request #22135 · openclaw/openclaw

mbelinky · 2026-02-20T19:14:38Z

Summary

Describe the problem and fix in 2–5 bullets:

Problem: iOS node permissions were not centrally modeled/exposed, and gateway capability reporting could imply tools were available when the OS permission state did not allow them.
Why it matters: this creates misleading capability negotiation and no single UI flow to request/review important iOS permissions.
What changed: added a centralized iOS permission center (photos/contacts/calendar/reminders/motion), added NodeAppModel permission APIs, added a Settings permissions disclosure/request section, and gated gateway capabilities/commands/permission flags from live permission state.
What did NOT change (scope boundary): no Android changes, no watchOS permission implementation, no new backend API endpoints, no behavioral change to unrelated tool families.

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

Closes #
Related #

User-visible / Behavior Changes

New Settings > Device permissions section for Photos, Contacts, Calendar, Reminders, and Motion with state, request action, and deep-link to iOS Settings.
Gateway-reported capabilities/commands now reflect current permission state (read/write/denied where applicable) instead of over-reporting access.
Added required iOS Info.plist usage-description keys for these permission families.

Security Impact (required)

New permissions/capabilities? (Yes)
Secrets/tokens handling changed? (No)
New/changed network calls? (No)
Command/tool execution surface changed? (Yes)
Data access scope changed? (Yes)
If any Yes, explain risk + mitigation:
- Risk: inaccurate capability exposure could allow attempted tool calls that iOS would deny at runtime.
- Mitigation: capabilities/commands are now computed from live OS authorization status and exposed explicitly as denied/read/write flags.

Repro + Verification

Environment

OS: macOS 15.x
Runtime/container: Xcode iOS Simulator build
Model/provider: N/A
Integration/channel (if any): iOS app + gateway connection controller
Relevant config (redacted): default local iOS build settings

Steps

pnpm ios:gen
xcodebuild -project OpenClaw.xcodeproj -scheme OpenClaw -destination 'generic/platform=iOS Simulator' -configuration Debug build -quiet
Open SettingsTab code path and verify permission section/actions + gateway permission/capability gating logic.

Expected

Build succeeds and permission-centric capability gating is wired.

Actual

Build succeeds (exit code 0) and permission gating/settings UI compile and link correctly.

Evidence

Attach at least one:

Failing test/log before + passing after
Trace/log snippets
Screenshot/recording
Perf numbers (if relevant)

Human Verification (required)

What you personally verified (not just CI), and how:

Verified scenarios: generated iOS project, ran full simulator build, validated that prior Swift type-check timeout in SettingsTab is resolved, validated permission-gating code paths compile.
Edge cases checked: denied/restricted/limited/full mapping branches in permission center and calendar/reminder write gating.
What you did not verify: physical iPhone/watch grant/deny flows and runtime interaction UX on real devices.

Compatibility / Migration

Backward compatible? (Yes)
Config/env changes? (No)
Migration needed? (No)
If yes, exact upgrade steps:

Failure Recovery (if this breaks)

How to disable/revert this change quickly: revert commit 23693c7aa.
Files/config to restore: apps/ios/Sources/Gateway/GatewayConnectionController.swift, apps/ios/Sources/Info.plist, apps/ios/Sources/Settings/SettingsTab.swift, apps/ios/project.yml, and remove added permission files.
Known bad symptoms reviewers should watch for: Settings screen compile slowdown/type-check errors, missing permission prompts, capability reports not matching iOS permission state.

Risks and Mitigations

Risk: permission mapping may diverge from Apple APIs over time.
- Mitigation: centralized mapping in IOSPermissionCenter keeps updates in one place.
Risk: UI complexity in SettingsTab can regress compiler performance.
- Mitigation: split large modifier chains into helper methods to keep type-checking tractable.

Greptile Summary

Centralized iOS permission management and gated gateway capabilities by permission state.

Major changes:

Added IOSPermissionCenter to centralize permission checking for photos, contacts, calendar, reminders, and motion
Gated gateway capability reporting based on actual iOS permission state (read/write/denied)
Added Settings UI section for permission disclosure, request, and deep-link to iOS Settings
Added required Info.plist usage description keys for new permission families
Refactored SettingsTab.swift to improve type-checking performance by splitting view builders

Critical issue:

GatewayConnectionController.swift:687 has incorrect byte-order conversion that will break loopback IP detection on iOS devices (little-endian systems)

Confidence Score: 2/5

This PR has a critical logical error affecting loopback IP detection on iOS
The byte-order conversion bug in loopback IP detection is a critical issue that will cause incorrect behavior when checking for loopback addresses. The permission implementation appears sound, but this networking bug must be fixed before merge.
Pay close attention to apps/ios/Sources/Gateway/GatewayConnectionController.swift - the ntohl replacement breaks loopback detection

_{Last reviewed commit: 23693c7}

greptile-apps

_{7 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-20T19:17:24Z

apps/ios/Sources/Gateway/GatewayConnectionController.swift

        let parsed = host.withCString { inet_pton(AF_INET, $0, &addr) == 1 }
        guard parsed else { return false }
-        let value = ntohl(addr.s_addr)
+        let value = UInt32(bigEndian: addr.s_addr)


UInt32(bigEndian:) expects a value that's already in big-endian format but needs to be interpreted as host-endian. However, addr.s_addr is already in network byte order (big-endian). The original ntohl() call converted from network to host byte order before the bit shift. This change breaks the loopback detection on little-endian systems (like iOS devices).

Suggested change

let value = UInt32(bigEndian: addr.s_addr)

let value = ntohl(addr.s_addr)

Prompt To Fix With AI

This is a comment left during a code review. Path: apps/ios/Sources/Gateway/GatewayConnectionController.swift Line: 687 Comment: `UInt32(bigEndian:)` expects a value that's already in big-endian format but needs to be interpreted as host-endian. However, `addr.s_addr` is already in network byte order (big-endian). The original `ntohl()` call converted from network to host byte order before the bit shift. This change breaks the loopback detection on little-endian systems (like iOS devices). ```suggestion let value = ntohl(addr.s_addr) ``` How can I resolve this? If you propose a fix, please make it concise.

mbelinky · 2026-02-20T19:26:34Z

Merged via squash.

Prepared head SHA: 92c2660
Merge commit: 67edc77

Thanks @mbelinky!

@mbelinky

…claw#22135) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 92c2660 Co-authored-by: mbelinky <[email protected]> Co-authored-by: mbelinky <[email protected]> Reviewed-by: @mbelinky

@mbelinky

…claw#22135) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 92c2660 Co-authored-by: mbelinky <[email protected]> Co-authored-by: mbelinky <[email protected]> Reviewed-by: @mbelinky

@mbelinky

…claw#22135) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 92c2660 Co-authored-by: mbelinky <[email protected]> Co-authored-by: mbelinky <[email protected]> Reviewed-by: @mbelinky

@mbelinky

…claw#22135) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 92c2660 Co-authored-by: mbelinky <[email protected]> Co-authored-by: mbelinky <[email protected]> Reviewed-by: @mbelinky

@mbelinky

Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 92c2660 Co-authored-by: mbelinky <[email protected]> Co-authored-by: mbelinky <[email protected]> Reviewed-by: @mbelinky

@mbelinky

…claw#22135) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 92c2660 Co-authored-by: mbelinky <[email protected]> Co-authored-by: mbelinky <[email protected]> Reviewed-by: @mbelinky

@mbelinky

…claw#22135) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 92c2660 Co-authored-by: mbelinky <[email protected]> Co-authored-by: mbelinky <[email protected]> Reviewed-by: @mbelinky

@mbelinky

…claw#22135) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 92c2660 Co-authored-by: mbelinky <[email protected]> Co-authored-by: mbelinky <[email protected]> Reviewed-by: @mbelinky

@mbelinky

…claw#22135) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 92c2660 Co-authored-by: mbelinky <[email protected]> Co-authored-by: mbelinky <[email protected]> Reviewed-by: @mbelinky

@mbelinky

…claw#22135) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 92c2660 Co-authored-by: mbelinky <[email protected]> Co-authored-by: mbelinky <[email protected]> Reviewed-by: @mbelinky (cherry picked from commit 67edc77) # Conflicts: # apps/ios/Sources/Gateway/GatewayConnectionController.swift # apps/ios/Sources/Settings/SettingsTab.swift

@mbelinky

…claw#22135) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 92c2660 Co-authored-by: mbelinky <[email protected]> Co-authored-by: mbelinky <[email protected]> Reviewed-by: @mbelinky (cherry picked from commit 67edc77) # Conflicts: # apps/ios/Sources/Gateway/GatewayConnectionController.swift # apps/ios/Sources/Info.plist # apps/ios/Sources/Settings/SettingsTab.swift # apps/ios/project.yml

@mbelinky

…claw#22135) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 92c2660 Co-authored-by: mbelinky <[email protected]> Co-authored-by: mbelinky <[email protected]> Reviewed-by: @mbelinky

openclaw-barnacle bot added app: ios App: ios size: XL maintainer Maintainer-authored PR labels Feb 20, 2026

mbelinky self-assigned this Feb 20, 2026

greptile-apps bot reviewed Feb 20, 2026

View reviewed changes

mbelinky and others added 2 commits February 20, 2026 20:23

iOS: gate capabilities by permissions and add settings controls

660b602

changelog: add entry for iOS permission gating

92c2660

mbelinky force-pushed the mb/ios-permissions-priority-1 branch from 23693c7 to 92c2660 Compare February 20, 2026 19:25

mbelinky merged commit 67edc77 into main Feb 20, 2026
11 checks passed

mbelinky deleted the mb/ios-permissions-priority-1 branch February 20, 2026 19:26

github-actions bot mentioned this pull request Feb 20, 2026

📡 Upstream Digest — 2026-02-20 20:21 UTC curtismercier/openclaw-mods#79

Open

SimonSchubert mentioned this pull request Feb 20, 2026

Android: security hardening to prevent screenshots of manual gateway settings #22238

Closed

3 tasks

github-actions bot mentioned this pull request Mar 1, 2026

cherry-pick: upstream docs commits (2026-03-01-0443) hughdidit/DAISy-Agency#141

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

iOS: gate capabilities by permissions and add settings controls#22135

iOS: gate capabilities by permissions and add settings controls#22135
mbelinky merged 2 commits intomainfrom
mb/ios-permissions-priority-1

mbelinky commented Feb 20, 2026 •

edited by greptile-apps bot

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Feb 20, 2026

Uh oh!

Uh oh!

mbelinky commented Feb 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	let value = UInt32(bigEndian: addr.s_addr)
	let value = ntohl(addr.s_addr)

Uh oh!

Conversation

mbelinky commented Feb 20, 2026 • edited by greptile-apps bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

User-visible / Behavior Changes

Security Impact (required)

Repro + Verification

Environment

Steps

Expected

Actual

Evidence

Human Verification (required)

Compatibility / Migration

Failure Recovery (if this breaks)

Risks and Mitigations

Greptile Summary

Confidence Score: 2/5

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mbelinky commented Feb 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

mbelinky commented Feb 20, 2026 •

edited by greptile-apps bot

Loading