iOS Watch: bridge mirrored notification actions into quick replies#22123
Merged
iOS Watch: bridge mirrored notification actions into quick replies#22123
Conversation
openclaw-barnacle
bot
added
app: ios
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
|
||
| let event = WatchQuickReplyEvent( | ||
| replyId: UUID().uuidString, | ||
| promptId: (normalizedPromptID?.isEmpty == false) ? normalizedPromptID! : "unknown", |
Contributor
There was a problem hiding this comment.
force unwrap on normalizedPromptID! will crash if normalizedPromptID is empty string (since empty check happens after optional check)
Suggested change
| promptId: (normalizedPromptID?.isEmpty == false) ? normalizedPromptID! : "unknown", | |
| promptId: normalizedPromptID.flatMap { $0.isEmpty ? nil : $0 } ?? "unknown", |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/ios/Sources/OpenClawApp.swift
Line: 439
Comment:
force unwrap on `normalizedPromptID!` will crash if `normalizedPromptID` is empty string (since empty check happens after optional check)
```suggestion
promptId: normalizedPromptID.flatMap { $0.isEmpty ? nil : $0 } ?? "unknown",
```
How can I resolve this? If you propose a fix, please make it concise.
mbelinky
force-pushed
the
pr/ios-watch-mirrored-actions
branch
from
06c1ca1 to
401fbe8
Compare
Contributor
Author
MisterGuy420
pushed a commit
to MisterGuy420/openclaw-dev
that referenced
this pull request
Feb 20, 2026
…penclaw#22123) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 401fbe8 Co-authored-by: mbelinky <[email protected]> Co-authored-by: mbelinky <[email protected]> Reviewed-by: @mbelinky
rodrigogs
pushed a commit
to rodrigogs/openclaw
that referenced
this pull request
Feb 20, 2026
…penclaw#22123) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 401fbe8 Co-authored-by: mbelinky <[email protected]> Co-authored-by: mbelinky <[email protected]> Reviewed-by: @mbelinky
Hansen1018
added a commit
to Hansen1018/openclaw
that referenced
this pull request
Feb 21, 2026
…penclaw#22123) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 401fbe8 Co-authored-by: mbelinky <[email protected]> Co-authored-by: mbelinky <[email protected]> Reviewed-by: @mbelinky
vincentkoc
pushed a commit
that referenced
this pull request
Feb 21, 2026
…22123) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 401fbe8 Co-authored-by: mbelinky <[email protected]> Co-authored-by: mbelinky <[email protected]> Reviewed-by: @mbelinky
dgarson
pushed a commit
to dgarson/clawdbot
that referenced
this pull request
Feb 21, 2026
…penclaw#22123) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 401fbe8 Co-authored-by: mbelinky <[email protected]> Co-authored-by: mbelinky <[email protected]> Reviewed-by: @mbelinky
mmyyfirstb
pushed a commit
to mmyyfirstb/openclaw
that referenced
this pull request
Feb 21, 2026
…penclaw#22123) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 401fbe8 Co-authored-by: mbelinky <[email protected]> Co-authored-by: mbelinky <[email protected]> Reviewed-by: @mbelinky
obviyus
pushed a commit
to guirguispierre/openclaw
that referenced
this pull request
Feb 22, 2026
…penclaw#22123) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 401fbe8 Co-authored-by: mbelinky <[email protected]> Co-authored-by: mbelinky <[email protected]> Reviewed-by: @mbelinky
mreedr
pushed a commit
to mreedr/openclaw-custom
that referenced
this pull request
Feb 24, 2026
…penclaw#22123) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 401fbe8 Co-authored-by: mbelinky <[email protected]> Co-authored-by: mbelinky <[email protected]> Reviewed-by: @mbelinky
6 tasks
hughdidit
pushed a commit
to hughdidit/DAISy-Agency
that referenced
this pull request
Mar 1, 2026
…penclaw#22123) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 401fbe8 Co-authored-by: mbelinky <[email protected]> Co-authored-by: mbelinky <[email protected]> Reviewed-by: @mbelinky (cherry picked from commit f52476f) # Conflicts: # apps/ios/Sources/OpenClawApp.swift
hughdidit
pushed a commit
to hughdidit/DAISy-Agency
that referenced
this pull request
Mar 3, 2026
…penclaw#22123) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 401fbe8 Co-authored-by: mbelinky <[email protected]> Co-authored-by: mbelinky <[email protected]> Reviewed-by: @mbelinky (cherry picked from commit f52476f) # Conflicts: # apps/ios/Sources/OpenClawApp.swift
zooqueen
pushed a commit
to hanzoai/bot
that referenced
this pull request
Mar 6, 2026
…penclaw#22123) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 401fbe8 Co-authored-by: mbelinky <[email protected]> Co-authored-by: mbelinky <[email protected]> Reviewed-by: @mbelinky
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NodeAppModelquick-reply flowFiles
apps/ios/Sources/OpenClawApp.swiftapps/ios/Sources/Model/NodeAppModel.swiftValidation
xcodebuild -project apps/ios/OpenClaw.xcodeproj -scheme OpenClaw -destination 'generic/platform=iOS' CODE_SIGNING_ALLOWED=NO buildcurrently fails on existing baseline issue inGatewayConnectionController.swift(ntohlsymbol), not introduced by this PRGreptile Summary
Implemented iOS notification bridge to route mirrored watch prompt actions into the quick-reply flow. When watch notifications fail immediate delivery, the system schedules equivalent iOS notifications with actionable buttons, queuing actions until
NodeAppModelis available.UNUserNotificationCenterDelegateprotocol conformance to handle notification actionsWatchPromptNotificationBridgeenum with notification scheduling and category managementNodeAppModelwithhandleMirroredWatchPromptActionto bridge actions intoWatchQuickReplyEventflowConfidence Score: 4/5
apps/ios/Sources/OpenClawApp.swiftline 439 for the force unwrap fixLast reviewed commit: 06c1ca1