feat(i18n): added korean locale#21617
Closed
Jaejuna wants to merge 3 commits into
Closed
Conversation
- Add ko-KR.ts with full Korean translations - Add koKR language entry to all locale files (en, zh-CN, zh-TW, pt-BR) - Register ko-KR in SUPPORTED_LOCALES and setLocale dynamic import - Add browser language auto-detection for Korean (navigator.language startsWith 'ko') Relates to issue openclaw#3460 Related to pr openclaw#18508
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| "{command}로 토큰이 포함된 URL을 다시 복사하거나 토큰을 업데이트한 후 연결을 클릭하세요.", | ||
| }, | ||
| insecure: { | ||
| hint: "이 페이지는 HTTP이므로 브라우저가 기기 식별을 차단합니다. HTTPS(Tailscale Serve)를 사용하거나 Gateway 호스트에서 {url}을 직접 여세요.", |
Contributor
There was a problem hiding this comment.
typo: "직접 여세요" appears incomplete - "여세요" is not a valid Korean verb
Suggested change
| hint: "이 페이지는 HTTP이므로 브라우저가 기기 식별을 차단합니다. HTTPS(Tailscale Serve)를 사용하거나 Gateway 호스트에서 {url}을 직접 여세요.", | |
| hint: "이 페이지는 HTTP이므로 브라우저가 기기 식별을 차단합니다. HTTPS(Tailscale Serve)를 사용하거나 Gateway 호스트에서 {url}을 직접 열어보세요.", |
Prompt To Fix With AI
This is a comment left during a code review.
Path: ui/src/i18n/locales/ko-KR.ts
Line: 99
Comment:
typo: "직접 여세요" appears incomplete - "여세요" is not a valid Korean verb
```suggestion
hint: "이 페이지는 HTTP이므로 브라우저가 기기 식별을 차단합니다. HTTPS(Tailscale Serve)를 사용하거나 Gateway 호스트에서 {url}을 직접 열어보세요.",
```
How can I resolve this? If you propose a fix, please make it concise.
Author
There was a problem hiding this comment.
It's not a typo. My translation conveys the full meaning more concisely and effectively.
10 tasks
Jaejuna
changed the title
|
This pull request has been automatically marked as stale due to inactivity. |
Member
|
See #3460 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SUPPORTED_LOCALESand the language selector in the UI, but no translation file existedko-KR.tswith full Korean translations; registeredko-KRin thesetLocaledynamic import chain; addedkoKRdisplay name entry to all existing locale files (en, zh-CN, zh-TW, pt-BR)Change Type
Scope
Linked Issue/PR
User-visible / Behavior Changes
navigator.languagestarting withkowill now have Korean auto-detected on first visit instead of falling back to EnglishSecurity Impact
Repro + Verification
Environment
Steps
Expected
Actual
Evidence
Failing test/log before + passing after
Trace/log snippets
Screenshot/recording
Perf numbers (if relevant)
Build passes:
pnpm buildcompletes successfully (8241ms, 0 errors)Human Verification
koKRkey structure, translation keys match en.ts exactlyTranslator note: Translations were authored by a native Korean speaker working as a localization engineer at Nexon. Technical terms (Gateway, WebSocket, Skills, CLI, Canvas, Tailscale, Cron, etc.) are intentionally kept in English per the convention established in #18508.
Compatibility / Migration
Failure Recovery
ko-KR.ts, revertkoKRentries from all locale files, removeko-KRbranch fromsetLocaleui/src/i18n/locales/ko-KR.ts,ui/src/i18n/locales/en.ts,zh-CN.ts,zh-TW.ts,pt-BR.ts,ui/src/i18n/lib/translate.tsRisks and Mitigations
Greptile Summary
Added complete Korean (ko-KR) locale support to the Control UI. Registered
ko-KRinSUPPORTED_LOCALES, added language detection for Korean browser locales, and implemented dynamic import loading. All existing locale files updated with thekoKRdisplay name entry.navigator.language.startsWith("ko"))One typo found in Korean translation that should be corrected before merge.
Confidence Score: 4/5
Last reviewed commit: 8c4d504
(2/5) Greptile learns from your feedback when you react with thumbs up/down!