fix(heartbeat): constrain 24-hour sentinel to 24:00 only in regex#21410
Merged
gumadeiras merged 2 commits intoopenclaw:mainfrom Feb 20, 2026
Merged
fix(heartbeat): constrain 24-hour sentinel to 24:00 only in regex#21410gumadeiras merged 2 commits intoopenclaw:mainfrom
gumadeiras merged 2 commits intoopenclaw:mainfrom
Conversation
gumadeiras
force-pushed
the
fix/infra-heartbeat-regex-24-hour
branch
from
bcc75c5 to
54d3189
Compare
The previous pattern /^([01]\d|2[0-3]|24):([0-5]\d)$/ matched 24:01-24:59 because the 24 alternative was not restricted to :00. Restructured the regex so only the literal string "24:00" is accepted as the end-of-day sentinel. Co-Authored-By: Claude Opus 4.6 <[email protected]>
gumadeiras
force-pushed
the
fix/infra-heartbeat-regex-24-hour
branch
from
54d3189 to
7b8fe75
Compare
Member
|
Merged via squash. Thanks @adhitShet! |
vignesh07
pushed a commit
to pahdo/openclaw
that referenced
this pull request
Feb 20, 2026
…enclaw#21410) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 7b8fe75 Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
anisoptera
pushed a commit
to anisoptera/openclaw
that referenced
this pull request
Feb 20, 2026
…enclaw#21410) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 7b8fe75 Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
rodrigogs
pushed a commit
to rodrigogs/openclaw
that referenced
this pull request
Feb 20, 2026
…enclaw#21410) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 7b8fe75 Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
Hansen1018
added a commit
to Hansen1018/openclaw
that referenced
this pull request
Feb 21, 2026
…enclaw#21410) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 7b8fe75 Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
vincentkoc
pushed a commit
that referenced
this pull request
Feb 21, 2026
…1410) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 7b8fe75 Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
vincentkoc
pushed a commit
that referenced
this pull request
Feb 21, 2026
…1410) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 7b8fe75 Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
mmyyfirstb
pushed a commit
to mmyyfirstb/openclaw
that referenced
this pull request
Feb 21, 2026
…enclaw#21410) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 7b8fe75 Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
obviyus
pushed a commit
to guirguispierre/openclaw
that referenced
this pull request
Feb 22, 2026
…enclaw#21410) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 7b8fe75 Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
6 tasks
zooqueen
pushed a commit
to hanzoai/bot
that referenced
this pull request
Mar 6, 2026
…enclaw#21410) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 7b8fe75 Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Claude Code
Greptile Summary
Fixed regex pattern to only accept
24:00as the end-of-day sentinel value. The previous pattern incorrectly matched24:01through24:59because the alternation allowed the24hour with any valid minute pattern[0-5]\d. The new pattern uses top-level alternation to treat24:00as a literal special case, correctly restricting 24-hour time to exactly24:00.Confidence Score: 5/5
Last reviewed commit: bcc75c5