fix: remove duplicate comment in orderProfilesByMode#21409
Merged
gumadeiras merged 3 commits intoopenclaw:mainfrom Feb 20, 2026
Merged
fix: remove duplicate comment in orderProfilesByMode#21409gumadeiras merged 3 commits intoopenclaw:mainfrom
gumadeiras merged 3 commits intoopenclaw:mainfrom
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
src/agents/auth-profiles/order.ts
Outdated
| @@ -145,7 +145,6 @@ function orderProfilesByMode(order: string[], store: AuthProfileStore): string[] | |||
| } | |||
|
|
|||
| // Sort available profiles by lastUsed (oldest first = round-robin) | |||
Contributor
There was a problem hiding this comment.
comment on line 147 is now misleading - it suggests only lastUsed sorting happens, but the code below primarily sorts by type (oauth > token > api_key), then by lastUsed within each type. lines 155-156 have the accurate explanation.
Suggested change
| // Sort available profiles by lastUsed (oldest first = round-robin) | |
| // Sort available profiles by type preference, then by lastUsed (oldest first = round-robin within type) |
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/agents/auth-profiles/order.ts
Line: 147
Comment:
comment on line 147 is now misleading - it suggests only `lastUsed` sorting happens, but the code below primarily sorts by type (oauth > token > api_key), then by `lastUsed` within each type. lines 155-156 have the accurate explanation.
```suggestion
// Sort available profiles by type preference, then by lastUsed (oldest first = round-robin within type)
```
How can I resolve this? If you propose a fix, please make it concise.
Contributor
Author
|
Fixed in latest push: Updated the comment on line 147 to accurately reflect both sort criteria — |
Two consecutive identical comments "Sort available profiles by lastUsed (oldest first)" were present on lines 147-148. Removed the redundant second line. Co-Authored-By: Claude Opus 4.6 <[email protected]>
… sort criteria Comment now accurately describes that sorting is by type preference (oauth > token > api_key) then by lastUsed oldest-first for round-robin within type. Co-Authored-By: Claude Opus 4.6 <[email protected]>
gumadeiras
force-pushed
the
fix/agents-auth-profiles-duplicate-comment
branch
from
b9d5145 to
0427165
Compare
Member
|
Merged via squash. Thanks @adhitShet! |
vignesh07
pushed a commit
to pahdo/openclaw
that referenced
this pull request
Feb 20, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 0427165 Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
anisoptera
pushed a commit
to anisoptera/openclaw
that referenced
this pull request
Feb 20, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 0427165 Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
rodrigogs
pushed a commit
to rodrigogs/openclaw
that referenced
this pull request
Feb 20, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 0427165 Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
Hansen1018
added a commit
to Hansen1018/openclaw
that referenced
this pull request
Feb 21, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 0427165 Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
vincentkoc
pushed a commit
that referenced
this pull request
Feb 21, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 0427165 Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
vincentkoc
pushed a commit
that referenced
this pull request
Feb 21, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 0427165 Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
mmyyfirstb
pushed a commit
to mmyyfirstb/openclaw
that referenced
this pull request
Feb 21, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 0427165 Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
obviyus
pushed a commit
to guirguispierre/openclaw
that referenced
this pull request
Feb 22, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 0427165 Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
6 tasks
hughdidit
pushed a commit
to hughdidit/DAISy-Agency
that referenced
this pull request
Mar 1, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 0427165 Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras (cherry picked from commit 399781a)
hughdidit
pushed a commit
to hughdidit/DAISy-Agency
that referenced
this pull request
Mar 3, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 0427165 Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras (cherry picked from commit 399781a)
zooqueen
pushed a commit
to hanzoai/bot
that referenced
this pull request
Mar 6, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 0427165 Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Claude Code
Greptile Summary
removed duplicate comment on line 148 that redundantly described the sorting behavior already explained on lines 155-156
Confidence Score: 5/5
Last reviewed commit: 0a9fbd1