fix(config-cli): correct misleading --json flag description#21332
Merged
gumadeiras merged 2 commits intoopenclaw:mainfrom Feb 20, 2026
Merged
fix(config-cli): correct misleading --json flag description#21332gumadeiras merged 2 commits intoopenclaw:mainfrom
gumadeiras merged 2 commits intoopenclaw:mainfrom
Conversation
9b27577 to
bb7bb8a
Compare
…g set The description said "Parse value as JSON5 (required)" which incorrectly implied the flag was mandatory. JSON5 is always attempted; --json only controls whether parse failure throws an error or falls back to raw string. Co-Authored-By: Claude Opus 4.6 <[email protected]>
bb7bb8a to
b6c8d1e
Compare
Member
|
Merged via squash. Thanks @adhitShet! |
vignesh07
pushed a commit
to pahdo/openclaw
that referenced
this pull request
Feb 20, 2026
…#21332) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: b6c8d1e Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
anisoptera
pushed a commit
to anisoptera/openclaw
that referenced
this pull request
Feb 20, 2026
…#21332) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: b6c8d1e Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
rodrigogs
pushed a commit
to rodrigogs/openclaw
that referenced
this pull request
Feb 20, 2026
…#21332) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: b6c8d1e Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
Hansen1018
added a commit
to Hansen1018/openclaw
that referenced
this pull request
Feb 21, 2026
…#21332) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: b6c8d1e Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
vincentkoc
pushed a commit
that referenced
this pull request
Feb 21, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: b6c8d1e Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
vincentkoc
pushed a commit
that referenced
this pull request
Feb 21, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: b6c8d1e Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
mmyyfirstb
pushed a commit
to mmyyfirstb/openclaw
that referenced
this pull request
Feb 21, 2026
…#21332) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: b6c8d1e Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
obviyus
pushed a commit
to guirguispierre/openclaw
that referenced
this pull request
Feb 22, 2026
…#21332) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: b6c8d1e Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
Closed
6 tasks
zooqueen
pushed a commit
to hanzoai/bot
that referenced
this pull request
Mar 6, 2026
…#21332) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: b6c8d1e Co-authored-by: adhitShet <[email protected]> Co-authored-by: gumadeiras <[email protected]> Reviewed-by: @gumadeiras
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--jsonflag onopenclaw config setdescribed itself as"Parse value as JSON5 (required)"— incorrect in two ways:false)--jsononly enables strict mode--json: JSON5 tried, falls back to raw string on failure--json: JSON5 tried, throws error on failure"Strict JSON5 parsing (error instead of raw string fallback)"Test plan
openclaw config set --help— verify updated description🤖 Generated with Claude Code
Greptile Summary
Corrected the
--jsonflag description foropenclaw config setcommand. The previous description incorrectly stated the flag was "required" and misleadingly suggested it controlled whether JSON5 parsing was attempted. In reality, JSON5 parsing is always attempted regardless of the flag - the flag only controls whether to throw an error or fall back to treating the value as a raw string when parsing fails.Confidence Score: 5/5
Last reviewed commit: 9b27577